From: Joseph Myers <joseph@codesourcery.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: Florian Weimer <fweimer@redhat.com>,
Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3] Add new C.UTF-8 locale (Bug 17318)
Date: Wed, 28 Apr 2021 17:36:05 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2104281733080.115529@digraph.polyomino.org.uk> (raw)
In-Reply-To: <ae1c23f9-55a2-4c87-3c8e-ac455b6ef0a3@redhat.com>
On Wed, 28 Apr 2021, Carlos O'Donell via Libc-alpha wrote:
> >> diff --git a/localedata/locales/i18n_ctype b/localedata/locales/i18n_ctype
> >> index c63e0790fc..c92bb95148 100644
> >> --- a/localedata/locales/i18n_ctype
> >> +++ b/localedata/locales/i18n_ctype
> >> @@ -26,7 +26,7 @@ fax ""
> >> language ""
> >> territory "Earth"
> >> revision "13.0.0"
> >> -date "2020-06-25"
> >> +date "2021-02-17"
> >> category "i18n:2012";LC_CTYPE
> >> END LC_IDENTIFICATION
> >
> > Those date changes seem spurious. Is this no-op file regeneration
> > really needed?
>
> The protocol is:
>
> cd localedata/unicode-gen
> make install
>
> The spurious regeneration is not needed, but it's easier to run the
> above commands. It gives a date for the last generation for all files
> consistently.
Is it required to have a date in the file at all?
For anything that's generated during the glibc build and ends up
installed, we'd avoid having such dates to allow for reproducible builds.
As this is a maintainer generation of something checked in as a source
file, rather than regenerated from makefile dependencies in a normal glibc
build, that doesn't strictly apply, but I still think it would be a good
idea to avoid having dates or other such non-reproducible output in
maintainer-generated files as far as possible.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2021-04-28 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 3:27 [PATCH v3] Add new C.UTF-8 locale (Bug 17318) Carlos O'Donell via Libc-alpha
2021-02-19 3:34 ` Carlos O'Donell via Libc-alpha
2021-02-19 8:47 ` Andreas Schwab
2021-03-11 19:05 ` Florian Weimer via Libc-alpha
2021-03-11 19:19 ` Florian Weimer via Libc-alpha
2021-03-11 22:55 ` Carlos O'Donell via Libc-alpha
2021-04-28 11:54 ` Carlos O'Donell via Libc-alpha
2021-04-28 17:36 ` Joseph Myers [this message]
2021-04-29 11:43 ` Carlos O'Donell via Libc-alpha
2021-04-29 11:57 ` Carlos O'Donell via Libc-alpha
-- strict thread matches above, loose matches on Subject: below --
2021-02-19 3:26 Carlos O'Donell via Libc-alpha
2021-02-19 3:22 Carlos O'Donell via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2104281733080.115529@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).