From: Joseph Myers <joseph@codesourcery.com>
To: Martin Sebor <msebor@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] more out of bounds checking improvements
Date: Mon, 26 Oct 2020 16:08:24 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2010261556330.102486@digraph.polyomino.org.uk> (raw)
In-Reply-To: <176ba75f-4299-073f-8319-66dbf9fe3f42@gmail.com>
On Mon, 26 Oct 2020, Martin Sebor via Libc-alpha wrote:
> The patch introduces the _L_tmpnam macro to avoid polluting
> the POSIX <unistd.h> namespace with L_tmpnam when the latter is
> only supposed to be defined in <stdio.h>. This in turn causes
> the a number of POSIX conformance test failures that I haven't
> been able to figure how to deal with and need some help with.
>
> In file included from ../include/unistd.h:2,
> from /tmp/tmpzm39v4n3/test.c:1:
> ../posix/unistd.h:1159:32: error: ‘_L_ctermid’ undeclared here (not in a
> function)
> extern char *ctermid (char __s[_L_ctermid]) __THROW
> ^~~~~~~~~~
>
> I expected adding the new macros to stdio-common/stdio_lim.h.in
> would do the trick but clearly something else is needed and I'm
> at a lost as to what that might be. I haven't been able to find
<unistd.h> doesn't include <bits/stdio_lim.h>, and you're making
<unistd.h> use _L_ctermid, and you're only defining _L_ctermid in
<bits/stdio_lim.h>. You need to define it in a header that <unistd.h>
includes - which also needs to be one whose contents are namespace-clean
for inclusion in <unistd.h> (which <bits/stdio_lim.h> isn't).
The obvious way would be to have a new installed (i.e. add to "headers" in
the relevant Makefile) header for the new macros that can be included in
both <stdio.h> and <unistd.h>. Suggestion: the existing scheme for
automatic generation of bits/stdio_lim.h is overly complicated, it would
be better to use sysdeps headers in the normal way like for other bits/
headers where the values may depend on the glibc configuration (and then
to have testcases that verify consistently of OPEN_MAX and FOPEN_MAX / of
PATH_MAX and FILENAME_MAX, when both are defined).
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2020-10-26 16:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 15:01 [PATCH] more out of bounds checking improvements Martin Sebor via Libc-alpha
2020-10-26 15:41 ` Florian Weimer via Libc-alpha
2020-12-09 0:18 ` Martin Sebor via Libc-alpha
2020-10-26 16:08 ` Joseph Myers [this message]
2020-12-09 21:46 ` Martin Sebor via Libc-alpha
2020-12-18 16:56 ` Ping: " Martin Sebor via Libc-alpha
2021-01-04 15:54 ` Ping 2: " Martin Sebor via Libc-alpha
2021-01-10 20:44 ` Ping 3: " Martin Sebor via Libc-alpha
2021-04-22 21:36 ` Ping 4: " Martin Sebor via Libc-alpha
2021-04-23 10:31 ` Florian Weimer via Libc-alpha
2021-04-23 15:06 ` Martin Sebor via Libc-alpha
2021-04-23 16:01 ` Florian Weimer via Libc-alpha
2021-05-04 19:58 ` Martin Sebor via Libc-alpha
2021-05-06 17:03 ` Martin Sebor via Libc-alpha
2021-05-06 18:15 ` Joseph Myers
2021-05-06 19:40 ` Martin Sebor via Libc-alpha
2021-05-07 9:20 ` Andreas Schwab
2021-05-07 9:24 ` Florian Weimer via Libc-alpha
2021-05-07 11:48 ` Andreas Schwab
2021-05-07 19:30 ` Tulio Magno Quites Machado Filho via Libc-alpha
2021-05-10 17:23 ` Joseph Myers
2021-05-10 8:45 ` Florian Weimer via Libc-alpha
2021-05-10 17:14 ` Martin Sebor via Libc-alpha
2021-05-10 17:49 ` Florian Weimer via Libc-alpha
2021-05-10 18:37 ` Martin Sebor via Libc-alpha
2021-05-10 19:22 ` Andreas Schwab
2021-05-10 19:50 ` Florian Weimer via Libc-alpha
2021-05-10 20:31 ` Martin Sebor via Libc-alpha
2021-05-11 10:53 ` Florian Weimer via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2010261556330.102486@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).