From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EA69F1F934 for ; Mon, 12 Oct 2020 22:04:09 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D3553857C5B; Mon, 12 Oct 2020 22:04:07 +0000 (GMT) Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 7C4193857C5B for ; Mon, 12 Oct 2020 22:04:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7C4193857C5B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: VvxUSn41KwG6VFhJWP7OdJpk3Ammi5Nq47YqdQ1a0GjMO50tF02YBPa2GII6+x/OWDEo/qaME7 QoT0ORBxmM4NeeK0RuHA/zTk/v56jJ7PEzq4B8Gbn2qUx1eCzJaCone/7EhocRiBCEi1DjgCPp 2V6hJ5nUx4cUFeneyCOIs8ztMgzDPU+PDRFmfHKGEB6/lujqxtRD041/eymfqN4mDGL7Xztb9d 2tMoquZuGNAUvfTLnkmnyucgX/feJpscqJ+bzUMoaiPgAYv39y4/LlOi/EAKFZ1fwqEqGJrC6j ZHE= X-IronPort-AV: E=Sophos;i="5.77,368,1596528000"; d="scan'208";a="56112845" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 12 Oct 2020 14:04:03 -0800 IronPort-SDR: hEsbB85HwgEkESkZoj1QLRX8P43mzNzCgu4AlQdcf499TWWaOu5sDtkUmJvPtIRuCQiXtVwuF5 K8h4rNlaZ5uoLTbeoVZG4geWNJ2+kJvxuAc/CKaG0Wy93HxCd9tLtxLFDjIUj6vzRGyGGTO+uZ iwpoII9pQlEsbs9iRoiQZoW8lVnleMpbEpPavoZ5RIibb+gk+VLF9yznagLAWlKmsfDKg6n5aj MtvMa4Gz/6ob4Q/twXqeT6ic5o3dJ6YyX74YvK4yW4LUnPC+1+1EdC9XwFXUF6pmkSo9b2FtjS gc4= Date: Mon, 12 Oct 2020 22:03:57 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: "H.J. Lu" Subject: Re: [PATCH] sysconf: Add _SC_MINSIGSTKSZ/_SC_SIGSTKSZ [BZ #20305] In-Reply-To: <20201010121935.3263605-1-hjl.tools@gmail.com> Message-ID: References: <20201010121935.3263605-1-hjl.tools@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-06.mgc.mentorg.com (139.181.222.6) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Sat, 10 Oct 2020, H.J. Lu via Libc-alpha wrote: > +* Add _SC_MINSIGSTKSZ and _SC_SIGSTKSZ. When _SC_SIGSTKSZ_SOURCE is > + defined, MINSIGSTKSZ and SIGSTKSZ are no longer constant on Linux. > + MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) and SIGSTKSZ > + is redefined to sysconf (_SC_SIGSTKSZ). I don't think the _SC_SIGSTKSZ_SOURCE option is a good idea. But in any case, all feature test macros need to be documented in creature.texi, and the new _SC_* constants would need documenting in conf.texi, with appropriate documentation that they are GNU extensions. > +#ifdef __USE_SC_SIGSTKSZ And the internal macros for new feature test macros ought to be tested via __GLIBC_USE (thus, always defined to either 0 or 1) rather than #ifdef. -- Joseph S. Myers joseph@codesourcery.com