From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7AF761F5B1 for ; Wed, 29 Jul 2020 21:09:11 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A66D43857C42; Wed, 29 Jul 2020 21:09:10 +0000 (GMT) Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 730BC3858D35 for ; Wed, 29 Jul 2020 21:09:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 730BC3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=joseph_myers@mentor.com IronPort-SDR: uq0vHsPBOzIkny9UvdnqraiCoZnGwA1szdev90r7AdhjcvOpLae5JbymAgGOPR0re4HEKxidNW 8kM8e6uvCRq+LLz4aE9ChFtY6Hzu8tYN/VkSCV5iUSwvdJ8CeeAMMCKYSl9FbHRz1EkAdr1Zjd zo1ttw13M3aBI1nbir63n7QMuWx/D54WrkGtTGGwmieCUhtRxZStbjIEk6VAiUwRwhtnVCb1vR r+6jjho3jlkA6Et0906eBF2mI9lsMQzaua6ThdiBKsHytAsrALwN/wwfnZY8ra4wkiQcF51aG9 0xY= X-IronPort-AV: E=Sophos;i="5.75,411,1589270400"; d="scan'208";a="51434256" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 29 Jul 2020 13:08:59 -0800 IronPort-SDR: rigNr0EzXlK2QqGUmcB7zo1IKv0VDTahdTVAIT3tqlOQyOEg/j1M1NqDZtk6fUdBC6O1zaxgrZ r5ACQamPlgd53HHyyIKyga1Rp0fFk9fx5GY0itfTFzCaqajNP34SZbqe9QLxeg5dNnCJ77KZQV hgfiVoojOJaJojPA5hpW0byANuV8MEb8KP4SqulQ7I/tq3okpwTuM2QtxsiuU3dU+HxytEndsr ltvwMq7z/JGo123YmV9E/nBESx42Dv2cO3FAPCu9SkeAxYmZApRmD0AeGWlulv9NEWQsqMd8Z6 cYc= Date: Wed, 29 Jul 2020 21:08:53 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Adhemerval Zanella Subject: Re: [PATCH 1/5] login: Consolidate utmp and utmpx headers In-Reply-To: <20200729205117.2925113-1-adhemerval.zanella@linaro.org> Message-ID: References: <20200729205117.2925113-1-adhemerval.zanella@linaro.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Wed, 29 Jul 2020, Adhemerval Zanella via Libc-alpha wrote: > It moves the 'struct lastlog', 'struct utmp', and 'struct utmpx' to > specific files and consolidates the s390-32 utmp.h and utmpx.h headers. > > Checked on x86_64-linux-gnu and i686-linux-gnu. I also checked with > a build for s390-linux-gnu. > --- > bits/struct_lastlog.h | 34 +++++ > bits/struct_utmp.h | 55 ++++++++ An installed header just defining a single type should be bits/types/.h, not bits/.h. -- Joseph S. Myers joseph@codesourcery.com