From: Joseph Myers <joseph@codesourcery.com>
To: DJ Delorie <dj@redhat.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [patch] ldconfig: trace origin paths with -v
Date: Wed, 19 Feb 2020 18:09:42 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2002191808220.18335@digraph.polyomino.org.uk> (raw)
In-Reply-To: <xnftf6h3fd.fsf@greed.delorie.com>
On Wed, 19 Feb 2020, DJ Delorie wrote:
> @@ -344,7 +346,12 @@ add_single_dir (struct dir_entry *entry, int verbose)
> if (ptr->ino == entry->ino && ptr->dev == entry->dev)
> {
> if (opt_verbose && verbose)
> - error (0, 0, _("Path `%s' given more than once"), entry->path);
> + {
> + error (0, 0, _("Path `%s' given more than once"), entry->path);
> + fprintf (stderr, "(from %s:%d and %s:%d)\n",
> + entry->from_file, entry->from_line,
> + ptr->from_file, ptr->from_line);
This looks like it's a message, for human readers rather than for
automated parsing, giving extra information about the previous message.
That previous message is marked up with _() for translation, and as this
new message includes English words, it should be marked up for translation
as well.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2020-02-19 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 17:50 [patch] ldconfig: trace origin paths with -v DJ Delorie
2020-02-19 18:00 ` Carlos O'Donell
2020-02-19 18:09 ` Joseph Myers [this message]
2020-02-19 20:45 ` DJ Delorie
2020-03-12 15:26 ` Carlos O'Donell via Libc-alpha
2020-03-12 19:08 ` DJ Delorie via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2002191808220.18335@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).