From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1376C1F45E for ; Mon, 10 Feb 2020 22:34:43 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=XCDdc beM/Q9eh7g0SzWUPByAMHEGjGlcmcg/bLQQhFS9RLgoUXsttZ4sGWf7EAF2iEL2S me6c2v1uA9daP4JFWyfphyxGE45hRKA+vpNRYV9puUfvjnYX7Zh1K14Z9d12KFqT l6Zuc9Zpk8zclvcPd2X+5qbJPrsoJHYxHcsEwg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=kgX0nriFA23 74hOYsZ5zZOuDJ90=; b=dQC17F2BA9ykSOg55t92O/6SgBj5zE6ZSSTDrZK11w0 RQwW//fNQiKstvvDSV1bf/ADvLnNjyM0Qso4lP9v9rA+G9Jsa5i+4UkDGcrGmrCI gexY+HEl2J3H1suBVJIQpXobuT2JrWJCoywudUCc8cx6IDTbkwHSWXsSoZF21icc = Received: (qmail 72460 invoked by alias); 10 Feb 2020 22:34:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 72452 invoked by uid 89); 10 Feb 2020 22:34:40 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: esa4.mentor.iphmx.com IronPort-SDR: 24CY+YO7x4Si2xBgtVyN1V+RQ9/DFgYIwpI6wF4ZzvpkpfgFplFhTXzj88kvl7jwY1sTewUCQQ DT7sxMYnUBu45yZBOJlMbaBicmkeRvWHiYt6kd2cztLS+lc82Kd/avGaw/KBnVbnPzyBQWcezV ogdYyfuSr18EGQC0wcVAe0qSNH+tKoC3BL9CPy7OU6Kz+IJTYvdfC6boEEpW5eFBaGOS0I8z// C+XLsg71/u9iyiM2qDje7OME9gVWkTt77iLLWTuULK9qc53glw5O9ncRS2yo7zIDMxaNgb4Ccb Lrg= IronPort-SDR: enrc7XgGleCVR7GRzBiyjT8g5AHWetE0/BV6qqIesJQkxsNoY2gOU01ZOIjN7o3b7eCLuw52yw g/OG2W5l4yFDkl14Lx6qJnUCZEz7Syp9DEMoV1MCG/13uT3WBho1e69x+u+enIuPuuajpOgLRy slgOD1xeqvwLySUty91trsgugF/6CfLDUM9TqeAhGvw8UsMdpGasXJ96YOTdEBxCxsPjuFG7lo WrDrGxZGS38YSI3/D/1vw1Q23fRTksE0Y0ifPdljuetscHcjgaaOT2Csv0NoH1/H4TwzTOKlX0 B4Y= Date: Mon, 10 Feb 2020 22:34:32 +0000 From: Joseph Myers To: WANG Xuerui CC: Subject: Re: [PATCH] mips: Fix argument passing for inlined syscalls on Linux [BZ #25523] In-Reply-To: <20200209185729.15896-1-git@xen0n.name> Message-ID: References: <20200209185729.15896-1-git@xen0n.name> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Mon, 10 Feb 2020, WANG Xuerui wrote: > diff --git a/sysdeps/unix/sysv/linux/mips/mips32/sysdep.h b/sysdeps/unix/sysv/linux/mips/mips32/sysdep.h > index beefcf284b..c275d63f67 100644 > --- a/sysdeps/unix/sysv/linux/mips/mips32/sysdep.h > +++ b/sysdeps/unix/sysv/linux/mips/mips32/sysdep.h > @@ -178,10 +178,11 @@ union __mips_syscall_return > long _sys_result; \ > \ > { \ > + long _arg1 = (long) (arg1); \ The glibc style is to use "long int" in place of "long", so I think the new variables should do that throughout the patch (and likewise "long long int"). Please post a revised patch, and say if you need someone to commit it for you. -- Joseph S. Myers joseph@codesourcery.com