From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 661A61F4B5 for ; Tue, 12 Nov 2019 17:40:54 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=at3v6 979dFJp6QZU/ATSMW7BTLN+kqIy7mTLIBs2Y6jM9nqv13vJZYGZ0y00hjwZ69yeg eaSPDVGue+8SFM7Uxjz3uGRTciWJMdJs5LXhg5VP9fKFWYRvSlg/9hJ5Y95fehF7 NFvBv4ZonjRmClhLYsi+jX8Cm1PMCeW8MRwrtI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=S9cnjW6gIKE aUPQOtHKbXbpH4io=; b=rgCGbA78X+4Os1ugXne+H+Jr6603Dwia6UQunK9hykT QoRJ5uzL+/YEO8zzvJWXPg43lJhW7KSeM13MHsxPWs2CUpMAfhZUDZKs6UxPltrd yzo/S6VqMtZFNsJT/podqgLo6rTsxNjuFeKvPlKc1sCWW5JCl41ZSNmTqFBkInK8 = Received: (qmail 59081 invoked by alias); 12 Nov 2019 17:40:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 59072 invoked by uid 89); 12 Nov 2019 17:40:51 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: esa4.mentor.iphmx.com IronPort-SDR: vogSBVvYNoN3e2ci0y1plNY4dOOoQAvmUg8qfrORL2fDoPL72h9jqPfnxJUdvWCopoofvADXcH R0a6DKdDoNimH/AmlID7FE2O9YY/t0BUX+QUTlz3b6fD5SMEzSPuODyDXQHxb4UhhpvoN9pDVb rjCMOiiz8QIREq0QZYomyAqWS2UbtNWHH6LRfYTNyVdvWItj2Fd2rtiViRShpQG3ff/fUvL1Eg y8dh+mDfQnPr02l4eRS66kqqPkROAZ+idEwli7HqOQP3+n8E6Ep17LMYp9M4U2UEZ+m6xRVRSG TXk= IronPort-SDR: Ju2byXL/KIz/abHh4oqAwvmlztxQtAFtB7lo+Ped+X8Su2a53gqrYbzK08vDY/f97bnT1+gI9D IcDaekgOYlNOjveDulNCAipcTetb5CVJ9+BONewYLUTT1fAElRcAdzHRR7IbbvkLG/25MCemBu C6TwL0/h6GAdkVfwwSgefiUaoGlmhsYTKCO+lui/vDQPc9SvH4/p4KCs7H+ew7S8mA185O1OQq ivDkS5vycxO8uATxyjGKhHfNB7SoDd6L6DwcHbbFbANj/omKInlBlEmrEIuZXZd6JgMGTTg/qp tac= Date: Tue, 12 Nov 2019 17:40:44 +0000 From: Joseph Myers To: Carlos O'Donell CC: libc-alpha , Florian Weimer Subject: Re: How to keep Reviewed-by lines in git commits with gerrit. In-Reply-To: <7b4aa5d2-14e7-c0aa-a258-bbd60455fae5@redhat.com> Message-ID: References: <7b4aa5d2-14e7-c0aa-a258-bbd60455fae5@redhat.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Tue, 12 Nov 2019, Carlos O'Donell wrote: > In the meantime I can do two things as a reviewer to help you keep > the Reviewed-by lines. > > 1. If I am about to grant +2 review I edit the commit and generate > a new patchset version, and add my Reviewed-by line. > 2. I submit my review of +2. > > Then when you push, you just need to make sure your new commit message > matches and it should close the review. That seems overly complicated. I thought the Change-Id was how gerrit told whether something was the same change, so would have expected that simply adding the Reviewed-by to the commit message when doing the final commit, but keeping the same Change-Id, would suffice, without extra patch set versions being needed unless there is an actual need for a new version to be reviewed. -- Joseph S. Myers joseph@codesourcery.com