From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5B5681F4C0 for ; Mon, 28 Oct 2019 23:00:53 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=QhXcw zRNNwnbABXn/698xDXvxWaeLY3vSQOiG8az1qsJTNp/oSkQC0z98SsRMwO/gBIGs sG+ELJyZ2mSgeDLNl84bji5ikRY4OIQL5g67JoE7gLROLX6BNQ3FspNh1lHZtIpt M7Ls4gj7I2bF4uqwxMoWtyJk1R5bgJeF6hsz1U= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=IhTgZaOXvOd QavsRJFq1NUdewns=; b=MagQR3jUEfv+uhtbenKebDHqGe4OPPmFtlGZlvMHyzy AIKJ8Hy8/fTU2H8Cv97KqlRKppf8ytKCsM8PmfkFOFosVQ0q1oIv7i2BBkGBP11o BKgSL1vdedgQkZdC6Hn5UODhnOo0iuWwOcHZCtwDRaBZlL5BQIgqsu3Jr/Kjd8QM = Received: (qmail 93233 invoked by alias); 28 Oct 2019 23:00:07 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 93186 invoked by uid 89); 28 Oct 2019 23:00:05 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: esa3.mentor.iphmx.com IronPort-SDR: kdzE1Uqo7AmjLEXLfnM+dR4mRJhMCPBoHvCNryDB5xwn/jp3KX/7MDLvIKXdqGzkA4NKrXhmqF 8hgiHGDML1KUeoIsb4KvCj6enRKA97OFVrXedUdo4+TgvOmxiFRskNoDWVoiKghYOFfZT+feyp utdHFo+UUymZvvUOi6ZNkBMrqsW3UCcEdkQml6Cdmz7cRCXiSERxmqOKfSrQMwq8Ye9wOsfmWt hSDu5tToS88UrbxgfflTjtQxmYynUBVMy/ulc5ZNFuWYg9yN96Zx4XKCk7QgdazPt1AtK8l5V5 828= IronPort-SDR: goEEr1IgBlKsx4VGQGcu4aF8qjcWreyw4WLCFmtf6+TxX7eClfXYYbQ6U2T63fBv14ldykH/QH IncW2KheWv9Wkhyyvtrn9mjRxEd9GtvHEX1U5CxgpARHNHOCN2iRrvCa2AYgTYcGHfXzpHxUGw tb9fbuueFfiQEeG2dc2xl90upAKnfENo6BuSidDd3pbc8mT8BA4Om49gj1LeEblzakzgVGwqMw P/8sL9KYncxJF2DIYNCSFyJV2e+n1xN4AHEdZmR9qvu/YAAw85HFpbtFHRRoUV6/M9/4BoVFQe JCI= Date: Mon, 28 Oct 2019 22:59:56 +0000 From: Joseph Myers To: Jonathan Nieder CC: Sergio Durigan Junior , Carlos O'Donell , libc-alpha Subject: Re: Setup non-pushing gerrit instance for glibc. In-Reply-To: <20191028191749.GA12487@google.com> Message-ID: References: <2e93ece9-386b-c587-9355-33a4695a3f02@redhat.com> <875zkcpxpd.fsf@redhat.com> <87r230o7qm.fsf@redhat.com> <877e4pon1t.fsf@redhat.com> <20191028191749.GA12487@google.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Mon, 28 Oct 2019, Jonathan Nieder wrote: > > (b) not losing the quoted text > > being replied to which is important to understanding the replies. > > Can you say more about this (e.g. do you have an example)? My example is from GDB. https://sourceware.org/ml/gdb-patches/2019-10/msg00942.html was a message sent to gerrit, in reply to a comments message. Now look at that one in gerrit - https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/126 - or as it came back to the list from gerrit - https://sourceware.org/ml/gdb-patches/2019-10/msg00943.html - and note that in gerrit's version, the first paragraph "On 2019-10-26 7:10 p.m., Tom Tromey (Code Review) wrote:" is followed by the next paragraph *after* the quoted text - the quoted text in between has been lost (Simon's comment in gerrit two comments later clarifies for gerrit readers, "I replied by email, so that's the header my email client added when replying to Tom's comment, and Gerrit interpreted it as part of my comment."). The problem of course isn't that gerrit kept that heading text, it's that it lost the quoted text after it. Removing quoted text at the end of the message makes sense, but removing quoted text that's followed by comments doesn't. (The examples in the gerrit documentation of email handling suggest it's already *supposed* to handle inline replies interspersed with quoted text, not just pure top-posting, but it evidently mishandled this particular email.) > > * Handle email replies to notifications of new patches, not just to > > comments on them. > > I would expect this to already work as well. So would I; only handling replies to comments seems an odd limitation. I haven't verified if it does or not; I'm just going on what https://sourceware.org/ml/libc-alpha/2019-10/msg00812.html says about "We will also have to warn the user that replying directly to a new change message will not work; gerrit can only understand email replies to comments.". > > * Include diff hunks in emails with comments on changed code (we now have > > more context in the code quoted, which is an improvement, but seeing the > > actual *changes* being commented on, rather than just one version of the > > code, is important to provide sufficient information in many cases). > > This is related to https://crbug.com/gerrit/11804, but it's not quite > the same. It sounds like you'd like the snippets to be in unified > diff format (which makes sense to me). Yes. Giving snippets in diff format (assuming there actually are changes around the code in question rather than someone commenting on unmodified code) is a reasonable heuristic to give the relevant information in 90% of cases. (The remaining 10% includes cases that already exist where e.g. reordering code in the file means the diff output isn't very helpful anyway, and whatever gerrit does then would be no worse than quoting an unhelpful diff in a manually sent email.) -- Joseph S. Myers joseph@codesourcery.com