From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 33C821F462 for ; Thu, 25 Jul 2019 20:54:56 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=RxYZm /sCuTPCSMuYs9hN6QWVhdbg19MnHrI4NyTuBW32wSmpiYPKbhEhAjiSyY3bUC0jh 5+AtosQKdmKrOhcVsXCtSEFSGKgfwyfEBrcQ5xcmQvAcbUBusUGCDS08Pvkivxms uiuP3cySRU+aW+U5Pc83ALOcOtTdXDsOA5QJls= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=SKZNhq3sCxJ NJpRhzJrqAfAyEWc=; b=UC8YzXuGCO4PX8lJGCeqLQaLrhYZ3WT+dhnhcSe0tV2 mzb6kyAIpBjK2qQGORyv7IbaIySOUwsHOdZPJqOsWyGe0r6sNQCGQasSaxCsjEDH fhgwBeVpoJEFUro9mdB4f3injUn91sootttadTh4o8AIV+BWX6ruFwV+ijjrdQOs = Received: (qmail 115192 invoked by alias); 25 Jul 2019 20:54:53 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 115184 invoked by uid 89); 25 Jul 2019 20:54:53 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Thu, 25 Jul 2019 20:54:41 +0000 From: Joseph Myers To: Rich Felker CC: Florian Weimer , Alistair Francis , , , , , , , Subject: Re: [RFC v3 02/23] sysdeps/gettimeofday: Use clock_gettime64 if avaliable In-Reply-To: <20190720032049.GX1506@brightrain.aerifal.cx> Message-ID: References: <87lfwxcf3f.fsf@oldenburg2.str.redhat.com> <20190720032049.GX1506@brightrain.aerifal.cx> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Fri, 19 Jul 2019, Rich Felker wrote: > > And the kernel folks really want us to call clock_gettime when the user > > calls the 32-bit function, for tracability of legacy processes. > > May or may not be relevant to glibc plans, but I want to chime in to > mention that this (kernel tracability of legacy processes) is not > going to work with musl, except possibly static-linked programs with > old libc. Our legacy compat functions are just going to be thin, > implementation-agnostic wrappers around the new functions, so even if > a program is still calling the old clock_gettime symbol with 32-bit > timespec, it's going to be executing the new one as its backend, and > thereby calling the 64-bit syscall or vdso if available. And as far as I'm concerned glibc should do likewise (I have a sustained objection to duplication of nontrivial function implementations at either the source and binary level for time_t variants when thin wrappers would do the job just as well, given the principle that the particular choice of syscalls for a given function is not a stable interface). (Where a function is defined entirely in syscalls.list, it might continue to use the old syscall, subject to working out the best way to set up function aliasing for that case.) > In any case, just grepping dynsym tables for references to legacy > symbols seems like a more effective way of finding problems than > grepping for syslog spam... Yes. -- Joseph S. Myers joseph@codesourcery.com