From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AC90420248 for ; Wed, 17 Apr 2019 22:22:02 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=G3oP+ mhBmDEV92bLOCy5GesLdIhc87hFnwuZ7TYM+8jIuVd8v+hLIIKGhGItZhAsfONEE BvyOimS4C3KqJvvfUznJGf7iLb4ijOGxuyXQyc/3btpoMD5cp3BJ78rbd4cYIo1f /OBNO552FOWCXWTvJOITu1pnOlOluiXCJcD7Go= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=hNKq+tcBdSL yEdB1GhL+QtoECVs=; b=W6esdZkMGMj3F3rFnDD3Lrdk0cNE7bR1LQmaHBIZvbB DD8OADI+W0OVcQWwhmbjyZXeBNMXmxu/bn1Kbf/GrA/5C8dO3ZW6/3bkRwIpF50n 0NEvG6/y6BpXzm1i3P0H15d/yJbYnMQ3nHL/0uCo1O6JkMAzZ0eOLEYzy63jIbd8 = Received: (qmail 126266 invoked by alias); 17 Apr 2019 22:22:00 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 126258 invoked by uid 89); 17 Apr 2019 22:21:59 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Wed, 17 Apr 2019 22:21:52 +0000 From: Joseph Myers To: Carlos O'Donell CC: libc-alpha , Mark Wielaard , Nick Clifton , Jeff Law , "Frank Ch. Eigler" , Pedro Alves , Florian Weimer Subject: Re: glibc git commit hooks update. In-Reply-To: <56d46408-8314-aa01-91da-f8e32f2f56d1@redhat.com> Message-ID: References: <56d46408-8314-aa01-91da-f8e32f2f56d1@redhat.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Mon, 15 Apr 2019, Carlos O'Donell wrote: > * Sending an email and updating bugzilla are the same process, > and so you either get both or you get none. You cannot have > commit emails without bugzilla updates. Therefore we have opted > to have only commit emails and bugzilla updates for release and > master. This can be fixed but it needs extending in the existing > scripts to make the two operations distinct. For example if anyone > wants user branches to generate email commit messages then we'll > need to work on this. I think user branches should generate emails (as I see it the point of having such branches in this repository at all is visibility of the work going on there, and that should include generating emails). I'm not clear on whether the hooks were configured with any limit on the size of diffs mailed, but if there is such a limit it should be at least several MB. One problem with the old hooks was that they did not generate a Content-Type header, which was unhelpful when the mails also weren't pure ASCII. I see the new ones are generating 'Content-Type: text/plain; charset="us-ascii"'. Will they also be smart about specifying an appropriate character set (so UTF-8 if the commit message / author name / diff contents are valid UTF-8 but not ASCII, for example)? -- Joseph S. Myers joseph@codesourcery.com