From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2518A20248 for ; Wed, 17 Apr 2019 21:10:26 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=LeomR wNCVn7242tQxglJjovwR24FxTbMqBSpzdmNBNDGAxyNlJAHRV4WBNozm/Uatnm5V AcRB5TLem4N8v4jsH2AeAcZXiwft5rEBwwaHfQUxaaO208tEBwIW4+VETaJfC5Mu +3PSTkALNZ5c1vKW2hmkIxIya3s+UWQ+DM/4BU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=pAHtphlcgAG DcT/ERz2kaPL3C+I=; b=uYc6aYP4ZDc8QmqhEdR+jIIlL6BaBapYyioP6u7cQj5 SFNppikW2CrubY7krGdCbZf33LnncwcTFlzF2WEMPQKYK8I9AFW6y2Erfq8HGFB/ x3WFObGbGg5+CNAnTaZ5xLH/9+8QqxyL/UgWqdPjgzgbAdhZc71GbEtzvJJxH9Rg = Received: (qmail 4303 invoked by alias); 17 Apr 2019 21:10:23 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 4293 invoked by uid 89); 17 Apr 2019 21:10:23 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Wed, 17 Apr 2019 21:10:15 +0000 From: Joseph Myers To: Adhemerval Zanella CC: Subject: Re: [PATCH 02/28] powerpc: fma using builtins In-Reply-To: <9b1b57d3-50ff-30c1-6aff-1854a83c643e@linaro.org> Message-ID: References: <20190329133529.22523-1-adhemerval.zanella@linaro.org> <20190329133529.22523-3-adhemerval.zanella@linaro.org> <9b1b57d3-50ff-30c1-6aff-1854a83c643e@linaro.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Wed, 3 Apr 2019, Adhemerval Zanella wrote: > On 02/04/2019 03:05, Joseph Myers wrote: > > On Fri, 29 Mar 2019, Adhemerval Zanella wrote: > > > >> +double __fma (double x, double y, double z) > > > > This is not a correctly formatted function definition (return type should > > be on its own line). > > Fixed locally. > > > > >> +float __fmaf (float x, float y, float z) > > > > Likewise. > > > > Ditto. The committed changes appear to be the wrong version, as they still have the incorrect formatting. -- Joseph S. Myers joseph@codesourcery.com