From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 71C0020248 for ; Mon, 1 Apr 2019 20:17:40 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=jWffJ SZFXQualOGQztOA7u2pW+/1CyjeqJ8wTW13SBpD71fslyW/hBf6dkRAUN2/w8gQW i4KYd0j6cLPAMTgPKU0CCGxMFOVQpXFFXOg13bOIZ0xpMivTIZ9FDLwj8OdkFfXm 6h4uAcOsCkZAc0waq617vWASLJPtexSMCLlegw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=9r/rO/G8o2w A25nE27+nrX+m15U=; b=AkUDBBko8rPJRBF7syMZsfY/3CTwsdgBF2ficjVaQhl JpsUlcdvwwS0lpyKq4dH45Cpx5FrYMrBQ1B3PMI332z8S1+1Qda0RaNicom5PZYi 1qJ5jf5dAqibR50XGJlQpqIY0vVh3XoWUtpvlVcFdlE25o8oiKYCVRMQVa4nZnEg = Received: (qmail 39612 invoked by alias); 1 Apr 2019 20:17:38 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 39602 invoked by uid 89); 1 Apr 2019 20:17:37 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Mon, 1 Apr 2019 20:17:28 +0000 From: Joseph Myers To: Lukasz Majewski CC: Paul Eggert , Subject: Re: [PATCH v2 1/2] Y2038: make __mktime_internal compatible with __time64_t In-Reply-To: <20190329152452.19d7b78c@jawa> Message-ID: References: <20190227112042.1794-1-lukma@denx.de> <20190312075856.33ac3c5b@jawa> <20190319143956.52f83a48@jawa> <910c75f2-86ea-34cd-7279-71fcbf5edabc@cs.ucla.edu> <20190323125906.699ce15e@jawa> <20190328095905.5900ddd9@jawa> <20190329152452.19d7b78c@jawa> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Fri, 29 Mar 2019, Lukasz Majewski wrote: > I've proposed to install struct __timespec64/__timeval64 > in ./include/bits/types directory of glibc (and as fair as I understand > those would be private). Almost all include/bits headers are single-line wrappers round the installed header. Given that is a namespace specifically for *installed* header fragments included from other installed headers, you need a very good reason to put actual type definitions in include/bits/. > But also, those can be placed in ./include/time.h Yes, that's a more appropriate place for internal type definitions. -- Joseph S. Myers joseph@codesourcery.com