From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5316820248 for ; Tue, 12 Mar 2019 00:36:23 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=jrhnE 30AX3We4SB8Cu9xXnXgINuZTk0Uz0/qe7L3W2PKoKUfEcbLsNVh8n7CcvgShMHPm 1Nk3vZjdSzU0lCVyQ3hmgXcJHzYUk1FryU/0P0HxhLsXzNEi3fJXMLU+IyE9Gvc2 ZP8pcT3itus0U3uYOv9+ojFu48okX9UwugOUtA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=zBOtjTwN4KD oYb27qIn64wQvybA=; b=B1mhav+36c0b58srQdrDCfAgux1JGrPPhZxzj996IWT KqsUljPe6yRlMCDhp7HB5s5ykhA4C40up6+P0tMuXovE+UznGtWrjAYQtCcMUI5S n5byduZa7QnYIIpWoe6JmbYaiwfBUyRV5FQIW5iP/z9zSJyrrxTbYb4utzkmRliE = Received: (qmail 21874 invoked by alias); 12 Mar 2019 00:36:21 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 21863 invoked by uid 89); 12 Mar 2019 00:36:21 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Tue, 12 Mar 2019 00:36:11 +0000 From: Joseph Myers To: Paul Eggert CC: Lukasz Majewski , Subject: Re: [PATCH v2 1/2] Y2038: make __mktime_internal compatible with __time64_t In-Reply-To: Message-ID: References: <20190227112042.1794-1-lukma@denx.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Mon, 11 Mar 2019, Paul Eggert wrote: > On 2/27/19 3:20 AM, Lukasz Majewski wrote: > > +/* Another name for `__mktime64'. */ > > +extern __time64_t __timelocal64 (struct tm *__tp) __THROW; > > In hindsight the name 'timelocal' was a mistake: it's not a portable > name and its use has not caught on. Although we need to keep 'timelocal' > for backwards compatibility, there's no need to define 'timelocal64', as > the very few people who need such a function can just call mktime64. So > I suggest removing all traces of timelocal64, __timelocal64, etc. from > the patch. Neither timelocal64 nor mktime64 will be a public API; the public API is to define _TIME_BITS=64 (and _FILE_OFFSET_BITS=64 because we don't want to support the combination of 64-bit times with 32-bit offsets) before including any system headers, then call the existing function names. Given timelocal as part of the __USE_MISC API in time.h, it should be part of the __USE_MISC __TIME_BITS=64 API there as well - but it's fine for that case to redirect to __mktime64 (and thus not need __timelocal64 as another alias). -- Joseph S. Myers joseph@codesourcery.com