From: Joseph Myers <joseph@codesourcery.com>
To: GT <tnggil@protonmail.com>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] PPC64: Addition of SIMD cosf function for POWER8.
Date: Wed, 6 Mar 2019 21:02:55 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1903062057360.30459@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1v44fML8uPvIYTJ46wzoIRRXfK_ZbimL1qXr4pthJenC2ZfEm8QtPXwzAgE6bIemC5MygZZpPkkRC4_MDyvjGql8yrWg55YGXVjPMIR153U=@protonmail.com>
On Sun, 3 Mar 2019, GT wrote:
> diff --git a/NEWS b/NEWS
> index 2f0e2f51c2..42b5aca08b 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -6,13 +6,18 @@ Please send GNU C library bug reports via <https://sourceware.org/bugzilla/>
> using `glibc' in the "product" field.
> \f
>
> -* Start of implementing vector math library libmvec on PPC64/POWER8.
> - The double-precision cosine now has a vector version.
> +* Continuing implementation of vector math library libmvec on PPC64/POWER8.
> + The following functions now have vector versions:
> + - cos (double-precision cosine)
> + - cosf (single-precision cosine)
> +
"Continuing implementation" does not make sense here. NEWS entries for
2.30 need to be relative to the state of 2.29, which didn't have this
functionality at all.
(Also, it appears the text you're changing here is above the heading for
2.30. It needs to be below the "Major new features:" heading for 2.30, or
whatever version gets the feature. So patch 1 in the series needs to be
revised with that fix to NEWS.)
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2019-03-06 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 10:07 [PATCH] PPC64: Addition of SIMD cosf function for POWER8 GT
2019-03-05 21:59 ` Joseph Myers
2019-03-06 21:02 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1903062057360.30459@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=tnggil@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).