unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH v4 1/5] ldbl-opt: Add arpg_error and argp_failure (bug 23983)
Date: Thu, 28 Feb 2019 18:35:18 +0000	[thread overview]
Message-ID: <alpine.DEB.2.21.1902281828140.20103@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20190221205706.12225-2-gabriel@inconstante.eti.br>

s/arpg_error/argp_error/ in the subject.

OK with that change.  This is on the basis that, while this patch is 
missing additions to libnldbl_nonshared.a, that library probably isn't 
useful (it's for the case of -mlong-double-64 with compilers not 
supporting asm redirection, but there is evidence that case has been 
broken for a long time) and so isn't worth adding additional exports 
solely for its use (it would require va_list versions of the new functions 
to be exported, much like __nldbl___vstrfmon and __nldbl___vstrfmon_l 
exist even though there is no normal public vstrfmon interface).

We should perhaps consider removing support for libnldbl_nonshared.a and 
officially requiring asm redirection support for any compiler used with 
glibc for configurations with more than one long double format (or more 
generally for any compiler used with glibc headers at all), but that 
should not be a requirement for these patches.

-- 
Joseph S. Myers
joseph@codesourcery.com

  reply	other threads:[~2019-02-28 18:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21 20:57 [PATCH v4 0/5] Add missing nldbl functions to libc Gabriel F. T. Gomes
2019-02-21 20:57 ` [PATCH v4 1/5] ldbl-opt: Add arpg_error and argp_failure (bug 23983) Gabriel F. T. Gomes
2019-02-28 18:35   ` Joseph Myers [this message]
2019-02-21 20:57 ` [PATCH v4 2/5] ldbl-opt: Reuse argp tests that print long double Gabriel F. T. Gomes
2019-02-28 18:36   ` Joseph Myers
2019-02-21 20:57 ` [PATCH v4 3/5] ldbl-opt: Add err, errx, verr, verrx, warn, warnx, vwarn, and vwarnx (bug 23984) Gabriel F. T. Gomes
2019-02-28 18:38   ` Joseph Myers
2019-02-21 20:57 ` [PATCH v4 4/5] ldbl-opt: Add error and error_at_line " Gabriel F. T. Gomes
2019-02-28 18:40   ` Joseph Myers
2019-02-21 20:57 ` [PATCH v4 5/5] ldbl-opt: Reuse test cases from misc/ that check long double Gabriel F. T. Gomes
2019-02-28 18:41   ` Joseph Myers
2019-02-28 14:02 ` Ping. Re: [PATCH v4 0/5] Add missing nldbl functions to libc Gabriel F. T. Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1902281828140.20103@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=gabriel@inconstante.eti.br \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).