From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6982F1F405 for ; Wed, 19 Dec 2018 00:02:25 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=mN6ii jCsaPyNyPdW+wBEusEZRn//Iuie6bGCl78Xsd28uPXvtulWmlc5MSQsmiG0bjj6w IBP4QRuYHJykGYREBAIYGUr2Ut6i/WpNkLK/rjUIsfzJioB3/kNU0Ef0jBnSybLi t4beB01e9ciJTxDO5Lr+87OPX9QW7OF+AMbdBM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=FnJn9PThUwI 8h37oIyOeDOI7rns=; b=XgjUY4ym3RjSu6qxrcPxMX4nrwt/wd1Zf7PkZFBKENw RpDvaX3hML3JT3uf5eV/FAdUuk0ViCDZfyyRi36IWFbrJ3hutfrosVo/AP7avgjh QyA7ZqQBrUOZEwhHzIFgnsAKRGWawzltCV6Lqy55iAVxcIaSpIelDqEW2FrZKQ2g = Received: (qmail 74045 invoked by alias); 19 Dec 2018 00:02:19 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 73850 invoked by uid 89); 19 Dec 2018 00:02:05 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Wed, 19 Dec 2018 00:01:58 +0000 From: Joseph Myers To: Vineet Gupta CC: , Subject: Re: [PATCH 07/21] ARC: math soft float support In-Reply-To: Message-ID: References: <1545167083-16764-1-git-send-email-vgupta@synopsys.com> <1545167083-16764-8-git-send-email-vgupta@synopsys.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Tue, 18 Dec 2018, Joseph Myers wrote: > On Tue, 18 Dec 2018, Vineet Gupta wrote: > > > +#if defined(__ARC_FPU_SP__) || defined(__ARC_FPU_DP__) > > Missing spaces before '(' (should have such spaces in most cases between > an identifier or keyword and '(' - calls to "defined", calls to functions, > calls to macros, __attribute__, etc. - except for a few cases of calls to > macros such as ElfW where the result is logically used like an > identifier). Or, of course, just omit the parentheses in the "defined" case, which is very common for calls to "defined" in glibc. (Function-like macro definitions are a case where you *can't* have the space because the syntax of C requires no space between the name of the macro being defined and the '(' before the list of argument names.) -- Joseph S. Myers joseph@codesourcery.com