From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 07C341F405 for ; Tue, 18 Dec 2018 23:23:11 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=oFECx 8tmoEpyNQeQ3blXkHlsv7WpWr8Zcm88gKJcfxFvrYM3hMyqzLVsytiRnLAdFOl2o VqZPXAb4q0Hz3NL3RK7DooDa1dgmnkpGpS0tWWH+f6UUMb+QHdY2bmsScM9K8E3c imFvtPwzljcSmgSxZpnb/0Nhc5V6IJMIqTcixs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=/wHa086m/uV zM0UfWNQxK2n4ylo=; b=o+dly4R+KLxS5NhltcC80tt223aGZRUjRkX+U7EW/xt PEKaQAOD1wo+EFw4DGQFV9fUUMAOwy7w/5RYldTygQTzZVivTPPi9nKOi4eo0mYF 1AEX8+U1TwFtMQR7AVtFiXlvx6iKP8DvSl50RH5FD8iKjfSvhDJ04AJL6ig8fe78 = Received: (qmail 123157 invoked by alias); 18 Dec 2018 23:23:08 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 123137 invoked by uid 89); 18 Dec 2018 23:23:08 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Tue, 18 Dec 2018 23:23:01 +0000 From: Joseph Myers To: Vineet Gupta CC: , Subject: Re: [PATCH 07/21] ARC: math soft float support In-Reply-To: <1545167083-16764-8-git-send-email-vgupta@synopsys.com> Message-ID: References: <1545167083-16764-1-git-send-email-vgupta@synopsys.com> <1545167083-16764-8-git-send-email-vgupta@synopsys.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Tue, 18 Dec 2018, Vineet Gupta wrote: > +#if defined(__ARC_FPU_SP__) || defined(__ARC_FPU_DP__) Missing spaces before '(' (should have such spaces in most cases between an identifier or keyword and '(' - calls to "defined", calls to functions, calls to macros, __attribute__, etc. - except for a few cases of calls to macros such as ElfW where the result is logically used like an identifier). > +/* In the soft-float case, only rounding to nearest is supported, with > + no exceptions. */ To confirm: hard-float and soft-float are always different ABIs; you don't support hard-float compilation using the soft-float function calling ABI (like is supported for ARM and RISC-V, for example)? (If you support hard-float compilation with the soft-float ABI, it would be problematic to have different FE_TONEAREST values in the two cases - ARM and RISC-V both define all the FE_* macros independently of whether hard or soft float is used, because they support that case.) > diff --git a/sysdeps/arc/math_private.h b/sysdeps/arc/math_private.h This file should not be needed now. > diff --git a/sysdeps/arc/nofpu/math-tests-exception.h b/sysdeps/arc/nofpu/math-tests-exception.h This file does nothing (the name is wrong, the name actually used is math-tests-exceptions.h). And it should not be needed unless you support hard-float compilation with the soft-float ABI (and thus define all the FE_* names in bits/fenv.h even for soft-float). > diff --git a/sysdeps/arc/nofpu/math-tests-rounding.h b/sysdeps/arc/nofpu/math-tests-rounding.h Again, not needed unless hard-float compilation with the soft-float ABI is supported and bits/fenv.h has corresponding contents. -- Joseph S. Myers joseph@codesourcery.com