From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7D7D41F405 for ; Tue, 18 Dec 2018 23:10:06 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=J+0Dw caBQD7fw9NQv7uyulTChOcNVznhMAiM359/v29Ut7nLJna2W8ZeHxbUlWkNDpCY8 QbEDFVqNw1Yag/BJx9xIlOe6R9J5CmyykO8FH5vYfmZaF0xZ7QanRUNcINOkKU2c zoIkfatv5iALprb20nwubvnqyyZVqqlvVir0QM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=mDxfchqRANt /EoTCaZc/aTzxZOU=; b=lXLo7KiK/rbqyKBMuYFO4ZLSGt+2YSDZop8uYNanfmr d9aMCHEGtvdsT9nS4tcBzWppe7DJHD1W+KdalWSbrNS1CIbGYCwjW6CBfwA29LJ2 KxDzpJy9L/6CBT/1BZbg14sW41LnqYBrQN2+as9QdS22hXS1aoIVXAjExXe0jW+o = Received: (qmail 10343 invoked by alias); 18 Dec 2018 23:10:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 10308 invoked by uid 89); 18 Dec 2018 23:10:03 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Tue, 18 Dec 2018 23:09:55 +0000 From: Joseph Myers To: Vineet Gupta CC: , Subject: Re: [PATCH 03/21] ARC: ABI Implementation In-Reply-To: <1545167083-16764-4-git-send-email-vgupta@synopsys.com> Message-ID: References: <1545167083-16764-1-git-send-email-vgupta@synopsys.com> <1545167083-16764-4-git-send-email-vgupta@synopsys.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Tue, 18 Dec 2018, Vineet Gupta wrote: > +/* FLAG 1 is privilege mode only instruction, hence will crash any program */ Generally, throughout the port, make sure comments end ". " (full stop, two spaces, end of comment). I won't remark on other places with this formatting issue. > diff --git a/sysdeps/arc/crti.S b/sysdeps/arc/crti.S As a new port I think it would be best to use init_array in your Implies file so you don't need these crti / crtn files, and make GCC generate init_array / fini_array exclusively. (See RISC-V and C-Sky discussions of this issue.) > +#ifdef __A7__ > +#define ARC_PLT_SIZE 12 > +#else > +#define ARC_PLT_SIZE 16 > +#endif Except for the multiple-include guards round a whole header file, preprocessor directives inside #if should have indentation in glibc, so "# define" (and "# define" inside two levels of #if, etc.). (As usual, fix this throughout the port; I won't list other individual places with this issue.) > +#define reloc_index \ > +({ \ > + unsigned long plt0 = D_PTR (l, l_info[DT_PLTGOT]); \ > + unsigned long pltn = reloc_arg; \ > + /* exclude PL0 and PLT1 */ \ Note the first letter of a comment should be capitalized (in addition to ending with ". "). > + unsigned long idx = (pltn - plt0)/ARC_PLT_SIZE - 2; \ glibc style uses "unsigned long int", not just "unsigned long". > diff --git a/sysdeps/arc/tls-macros.h b/sysdeps/arc/tls-macros.h > new file mode 100644 > index 000000000000..51855edef6e7 > --- /dev/null > +++ b/sysdeps/arc/tls-macros.h > @@ -0,0 +1,29 @@ > +/* Macros to support TLS testing in times of missing compiler support. */ Any file more than ten lines long should have copyright and license notices. -- Joseph S. Myers joseph@codesourcery.com