From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A68BB1F405 for ; Tue, 18 Dec 2018 22:59:59 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=pvALa NURoTS9tKM+CcoECZk5Uj0JIsrx4U/itRpwJLjUSUEF79z0VRqewz9/NoC45WH7i eIey73EfhFdV/kys3ISIu5GuR0eanCPzR1P+1BsvCQ6ZkQgKsk7Yejb0iYTkLgJc 0/hN4EYP2GQth+/aXNhb4GhchzOMZnQnM6zmEQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=CUeXXt07ANs rR/qIWunPfK2vcPg=; b=VJrzcUowGhpdXWgAUQ+mdsaomEFWynMAShfThJ8Qfp1 Id5sM99GVrGqX614jc54WZjwVA5i1QWfTmnqg1SlONDKKWU9+RBJkuR1hlUJR6mI Ouean2H89GxDCNNsMQnxk6MQJmJre5wwp9EDwcARqH/Li3NkQWCBxqg7EvBIf/QE = Received: (qmail 126379 invoked by alias); 18 Dec 2018 22:59:57 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 126365 invoked by uid 89); 18 Dec 2018 22:59:56 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Tue, 18 Dec 2018 22:59:49 +0000 From: Joseph Myers To: Vineet Gupta CC: Florian Weimer , "libc-alpha@sourceware.org" , "linux-snps-arc@lists.infradead.org" Subject: Re: [PATCH 14/21] ARC: Enable __start as entry point vs. canonical _start In-Reply-To: Message-ID: References: <1545167083-16764-1-git-send-email-vgupta@synopsys.com> <1545167083-16764-15-git-send-email-vgupta@synopsys.com> <87h8fay17b.fsf@oldenburg2.str.redhat.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Tue, 18 Dec 2018, Vineet Gupta wrote: > On 12/18/18 1:28 PM, Florian Weimer wrote: > >> ARC linker scripts have defined __start as entry point so to not break > >> ABI for uClibc et al we allow __start for glibc as well > > I think this change and the test suite fixes should be folded into the > > initial addition of these files. Or is there a reason for not doing > > this? > > I deliberately kept them out to call out the fixes, sometimes these help > new ports which stumble into similar issues. And also ~2 years worth of > work gets squashed into a single blob is a shame :-) Postings of a new port should generally post each new file in the form in which it is intended to be committed (and, thus, the form in which it should be reviewed); you should never post a known-buggy version and a subsequent fix to the bug; that wastes reviewers' time. (The actual commit of the port should be a single commit with everything, modulo possible separate earlier commits for changes to architecture-independent files, as the port isn't useful with only a subset of the new files added.) -- Joseph S. Myers joseph@codesourcery.com