From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,URIBL_RED shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1A4781F597 for ; Wed, 25 Jul 2018 10:29:44 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; q=dns; s=default; b=kYJGj Rpm6jL6tFBeOFUqwOV0NWgvau5tgoYlEYR0NXAja+Dk26LCwbqvF/CDZKhu7TBu3 rsFX3k+3jq0KDcCMekZTFIOKMbf/8XNhofeYrFV/w+9WUusUkSX+sa7F19d4uTjK uFGzgVzGxR9D27oyZELqd7uRHS9Rt9xa63uuA8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version:content-type; s=default; bh=M7aGxAEH+zS Lj0UBgFtcgHl8UpU=; b=jmow4qLv+0fJIeSLp0lOVmy5yQZ2MTfzSMoEUjo2Mx/ dQmImu1QjjuvrJaIRBkWUjdWIVa5k6KftZpGfAln5Ktz+qTlur8r7sGWo+CIFxv6 5mMbWivPAmFE/wC3uKRN4qY1WxXWTTLf4x1OTk81rCs7An8dkXJJm/DMrU7DIpMc = Received: (qmail 96522 invoked by alias); 25 Jul 2018 10:29:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 96503 invoked by uid 89); 25 Jul 2018 10:29:40 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: relay1.mentorg.com Date: Wed, 25 Jul 2018 10:29:32 +0000 From: Joseph Myers To: Andreas Schwab CC: Adhemerval Zanella , Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions In-Reply-To: Message-ID: References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" On Wed, 25 Jul 2018, Andreas Schwab wrote: > On Feb 02 2018, Adhemerval Zanella wrote: > > > @@ -197,7 +197,8 @@ linknamespace-libs-xsi = $(linknamespace-libs-posix) \ > > $(common-objpfx)crypt/libcrypt.a > > linknamespace-libs-ISO = $(linknamespace-libs-isoc) > > linknamespace-libs-ISO99 = $(linknamespace-libs-isoc) > > -linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) > > +linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) \ > > + $(common-objpfx)nptl/libpthread.a > > linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) \ > > $(common-objpfx)crypt/libcrypt.a > > You have reverted commit e69d994a63, which breaks --disable-crypt > builds. Also, the hardcoded reference to $(common-objpfx)nptl/libpthread.a should be $(static-thread-library). As-is, the patch has broken the testsuite build for Hurd (not just introduced the expected failures from lack of support for C11 threads in HTL). -- Joseph S. Myers joseph@codesourcery.com