From: Mark Wielaard <mark@klomp.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org,
"Andreas K . Huettel" <dilfridge@gentoo.org>,
Siddhesh Poyarekar <siddhesh@gotplt.org>,
Paul Eggert <eggert@cs.ucla.edu>
Subject: Re: [PATCH] Make sure INSTALL is ASCII plaintext again
Date: Tue, 30 Apr 2024 11:36:02 +0200 [thread overview]
Message-ID: <ada022abe8049d617485fd139ed9eb7def4dc97a.camel@klomp.org> (raw)
In-Reply-To: <87v840uy8d.fsf@oldenburg.str.redhat.com>
Hi,
On Mon, 2024-04-29 at 14:53 +0200, Florian Weimer wrote:
> Looks reasonable, thanks.
>
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks, pushed as:
commit ebfd73a80f15559fe59fee32a7844c6b8fa99576
Author: Mark Wielaard <mark@klomp.org>
Date: Sun Apr 28 16:59:39 2024 +0200
Make sure INSTALL is ASCII plaintext again
This reverts commit 84e93afc7 ("Switch to UTF-8 for INSTALL") and
reinstates commit c14f2e4aa ("Make sure INSTALL is ASCII plaintext")
and regenerates INSTALL.
It turns out that different versions of makeinfo (texinfo/texi2any),
at least versions 7.0.3 and 7.1, put unicode quote glyphs in different
places (specifically whether contractions like you'd, don't, aren't or
you'll use ’ or '). This breaks the make dist target as used for
(snapshot) releases, which have a check on the regenerated INSTALL
file. Using --disable-encoding generates the same plaintext ASCII on
all versions.
An alternative would be to regenerate INSTALL with texinfo 7.1 and
require at least that version. But that seems too soon while various
distros don't have 7.1 yet. We can try again to use UTF-8 for INSTALL
in a couple of years.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
This makes the snapshots builder green again:
https://builder.sourceware.org/buildbot/#/builders/glibc-snapshots-trunk
https://snapshots.sourceware.org/glibc/trunk/latest/
Cheers,
Mark
prev parent reply other threads:[~2024-04-30 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 14:59 [PATCH] Make sure INSTALL is ASCII plaintext again Mark Wielaard
2024-04-29 12:53 ` Florian Weimer
2024-04-30 9:36 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada022abe8049d617485fd139ed9eb7def4dc97a.camel@klomp.org \
--to=mark@klomp.org \
--cc=dilfridge@gentoo.org \
--cc=eggert@cs.ucla.edu \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).