From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Carlos O'Donell Newsgroups: gmane.comp.lib.glibc.alpha Subject: Re: [PATCH 0/2] nptl: Update struct pthread_unwind_buf Date: Wed, 14 Mar 2018 22:20:57 -0600 Message-ID: References: <20180201205757.51911-1-hjl.tools@gmail.com> <87tvu59o21.fsf@mid.deneb.enyo.de> <87po4t9mxt.fsf@mid.deneb.enyo.de> <3764b0a1-9f26-6f5f-1bc5-d374f2672f3a@redhat.com> <86d5d5ba-2b53-1904-dada-3efe2b3ad501@redhat.com> <304b73fa-bda0-f0a9-e252-e5a062d1182f@redhat.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1521087548 27151 195.159.176.226 (15 Mar 2018 04:19:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Mar 2018 04:19:08 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Cc: "Tsimbalist, Igor V" , Florian Weimer , GNU C Library To: "H.J. Lu" Original-X-From: libc-alpha-return-91045-glibc-alpha=m.gmane.org@sourceware.org Thu Mar 15 05:19:03 2018 Return-path: Envelope-to: glibc-alpha@blaine.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=F+GpjJzWBKGo9Qfy 0ibFuY/ogkuvwKFpLQSyVv3xU86wJakf0s6MMXZrGqM3BGtqPgsXUOLzESfQcSnz 6FZdACC0tor7F8lSy7H5RV8JylQz8AcQm+xbpVLP8MlkkSd3l3b3nE/KcBqxAl7m HJqKqgkFtQBw6oNbgmzYeGEny4A= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=vDORbM0e3GbXkHLDpmHJzm 8EkX4=; b=WczaMCSCRvBJ/df+aLTGi922QD/+GWADRPjXwjdh6VuYgbPs1qsupO asxBCkt7cC+pV3xtdBPK9fK96ai/uYFQC74Naf+FW1KUVmHmf0yd76OoWp8bDKLE yiM/BAF6qogGnZjhuV0RhCJlBCwPqQGAqrn55xJoVza8vSFY78doc= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=cancellation X-HELO: mail-qt0-f194.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AB2kwvRNhYR7qFKyMmxa4Y1g7EaxJcTt0dM5WWUzWrg=; b=ODWB8VORiMor+8tdwfviW8msiXWiYAqG1x/ceSichxst7PrYOhT7bIl6nZ7ImgIDgM hbSQ7mgbOSWDY6CZMwUC4Cy/aPj89zzi11jfmfXDdzsDOQGkJdSLy5D5rZPnDGKyNh0g Colo09hU9sTFVDF8vXZqQKLhnuTNNUtdEp62eYmNsJ410/Q2a5Z5O4IeOJo7K3Jl0y/i sqlFotXFRO8OYkpnsWN1j9eGzq6gzKiG9AndKe23znlEYQu3idoban5UewXvgiPZ7jNd icdn9h3qFoBT7x4FfufiAlx28f4wUV4x9q34gxdtMlTIsvWI/k58QdzXkV7wQSGrKyQz BcvA== X-Gm-Message-State: AElRT7Ee+kiHSFcdGXJ44tp+16ADkr9uH0VmmHisJnuCy0hmv42PP6+U Jw7y/0vKex+hVGuNQ1580So4SPVg8jU= X-Google-Smtp-Source: AG47ELuMGQ/Gnj0C/hbhJ1ap6VHFNAOjT510SBesLwV3bnCKmXcArcwRrEAM3uzkyEmNRwklXKpUqA== X-Received: by 10.200.14.75 with SMTP id j11mr1617880qti.302.1521087661830; Wed, 14 Mar 2018 21:21:01 -0700 (PDT) In-Reply-To: Xref: news.gmane.org gmane.comp.lib.glibc.alpha:83388 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewKM1-0006uR-WF for glibc-alpha@blaine.gmane.org; Thu, 15 Mar 2018 05:19:02 +0100 Received: (qmail 14295 invoked by alias); 15 Mar 2018 04:21:05 -0000 Received: (qmail 14286 invoked by uid 89); 15 Mar 2018 04:21:05 -0000 On 03/08/2018 10:23 PM, H.J. Lu wrote: > On Thu, Mar 8, 2018 at 4:47 PM, Carlos O'Donell wrote: >> On 03/08/2018 04:48 AM, H.J. Lu wrote: >>> True. This is the patch I have tested: >>> >>> https://github.com/hjl-tools/gcc/commit/e98087865405f051e93d5f35588789ef9686db4a >> >> I assume NOTRACK prefix is what Intel calls 'NO_TRACK_EN' in the CET >> documentation since binutils uses the 0x3E prefix for it and that matches >> the Intel CET docs. Please correct me if I'm wrong. > > That is correct. > >> In which case I agree, using NOTRACK is going to prevent a useful use >> of CET against writes to the cancellation jump buffer. > > True. > >> This patch looks good to me, but is not a *correctness* issue, it is >> simply that we want to extend coverage to the private cancellation >> setjmp/longjmp buffers. >> >> Is there any way we can do this with source markup instead of via >> a fragile list in the compiler? >> >> Presumably users may want to markup their own code like this also >> if they have custom implementations of functions that behave like >> setjmp/longjmp? >> > > Yes, we can use __attribute__((__returns_twice__)). I updated > hjl/setjmp/cancel branch to do that. No GCC changes are needed. Is the next step for me to do another round of review on this branch? Cheers, Carlos.