unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Stefan Liebler <stli@linux.ibm.com>,
	GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Get rid of Werror=maybe-uninitialized in res_send.c.
Date: Mon, 20 Jan 2020 13:57:40 +0530	[thread overview]
Message-ID: <aba65713-62b0-1ecc-f390-a664e104db15@gotplt.org> (raw)
In-Reply-To: <03d65724-d69b-d553-18a5-dece072e5a45@linux.ibm.com>

On 03/12/19 2:20 pm, Stefan Liebler wrote:
> Hi,
> 
> the commit 446997ff1433d33452b81dfa9e626b8dccf101a4 introduced
> this new usage of resplen. If build with gcc 9 -march>=z13 on s390x,
> the following warning occurs:
> res_send.c: In function ‘__res_context_send’:
> res_send.c:539:6: error: ‘resplen’ may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
> 539 |   if (resplen > HFIXEDSZ)
> |      ^
> 
> Therefore this patch adds a further DIAG_IGNORE_NEEDS_COMMENT in the
> same way as it was previously done for usages of resplen or n.
> See commit d1bc2cbbed9aea2017ef941f63c8786571da5b4f.

This is fine.  OK to commit to master.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

PS: Please send patches inline (using git send-email) since it's easier
to add review comments that way.

  parent reply	other threads:[~2020-01-20  8:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03  8:50 [PATCH] Get rid of Werror=maybe-uninitialized in res_send.c Stefan Liebler
2019-12-09 13:00 ` Stefan Liebler
2019-12-13 12:43   ` Stefan Liebler
2020-01-08  7:47     ` Stefan Liebler
2020-01-14  8:22       ` Stefan Liebler
2020-01-20  8:17         ` Stefan Liebler
2020-01-20  8:27 ` Siddhesh Poyarekar [this message]
2020-01-20 10:02   ` Stefan Liebler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aba65713-62b0-1ecc-f390-a664e104db15@gotplt.org \
    --to=siddhesh@gotplt.org \
    --cc=libc-alpha@sourceware.org \
    --cc=stli@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).