From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-5.2 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 58C461F8C6 for ; Fri, 6 Aug 2021 21:48:05 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D0AF3AAA0CA for ; Fri, 6 Aug 2021 21:48:03 +0000 (GMT) Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68]) by sourceware.org (Postfix) with ESMTPS id 589BA3861038 for ; Fri, 6 Aug 2021 21:47:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 589BA3861038 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.ucla.edu Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A609A1600AF; Fri, 6 Aug 2021 14:47:51 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id O7SIHOy6z-iR; Fri, 6 Aug 2021 14:47:50 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9B5621600CC; Fri, 6 Aug 2021 14:47:50 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HCCDFvqcfRgC; Fri, 6 Aug 2021 14:47:50 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 748C81600AF; Fri, 6 Aug 2021 14:47:50 -0700 (PDT) Subject: Re: glob vs '*/' vs GLOB_ONLYDIR vs xfs To: DJ Delorie References: From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Fri, 6 Aug 2021 14:47:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 8/5/21 11:10 AM, DJ Delorie wrote: > Paul Eggert writes: >> Isn't that a bug in XFS? readdir should set d_type to DT_UNKNOWN if it >> doesn't know the type. It shouldn't set d_type to garbage. > > XFS sets d_type to DT_UNKNOWN for most entries, not garbage. Ah, sorry, I misunderstood your previous email. >> Doesn't glob do the right thing if d_type is DT_UNKNOWN? > > No, if by "right thing" you mean "call lstat and find out the right > type". Thanks for reporting the problem. I plan to address this by merging recent glibc glob changes into Gnulib (these were for 64-bit time_t), fixing the bug in Gnulib, and then we can talk about merging back. The fix won't be trivial, unfortunately. On the bright side, I think we can remove some more stat/lstat calls from glob.