From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C44B11F44D for ; Mon, 11 Mar 2024 18:03:10 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VDOTb4ux; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E09533858438 for ; Mon, 11 Mar 2024 18:03:09 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3A10B3858D20 for ; Mon, 11 Mar 2024 18:02:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A10B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A10B3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710180169; cv=none; b=qB80J2FWpDyYoGI+VAPOtzSNSGuA3Ef1E1R4ox1RW/EHvOqAOth/Sabnclt3GRr2lgGX/6PLYTUa/FExzcAtaEd6QwYNtVRaaaogjeCyo0T+F+hQrfGvgcIjV+kyx5jz+c0acvImcmjOZ3LXfa5Nt3sqGJcs3OuppFHKk0la1S4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710180169; c=relaxed/simple; bh=I4WuAAIVepZJ0Fax+J7BcHrvUK8iXJetoeAUR9qjhvY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=PckO1bzeCPrbjVP54MY/hyN+L5B4vSvR8Qt5nmx7kgy/m+Z6V07J5XQuuSRPa+1dIUPvRga9Ixor7f0KBjcGd3V3G4CbDt4qMBkan0/kaBjryOAO/z3pvEBn5IeKHpHiED8IOGi7ZuwYVHbvdlddcUJtAJ29RkpuYLZPSPPYbI0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710180158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5rSUlA+0OiPBU3YVWGqGx0yauabsmVbhjOcDA2tLtVY=; b=VDOTb4uxZlrmrqE1FytiMIukdBnR534q0u7Oloi8eBxS4xlNcURuksP5abC5LYUrwlW3qq 5Iqj8yyvB5DJAp3vN6uMGhnDPIv33/3zWT3pNq1LyNmvWlaKHV3UeVoXWs1TQwk3JhlbiH rTVXgBRvsRSaWen467OxSNdrtV7IGLw= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-YU0Ngte5MS2H7dto00AQVg-1; Mon, 11 Mar 2024 14:02:36 -0400 X-MC-Unique: YU0Ngte5MS2H7dto00AQVg-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5131c91bbc3so3437755e87.0 for ; Mon, 11 Mar 2024 11:02:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710180153; x=1710784953; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5rSUlA+0OiPBU3YVWGqGx0yauabsmVbhjOcDA2tLtVY=; b=CT0hAHQQr3l41zhZmLFhQXmNaDeog53WGdWBo/yjsmDCx0GdMs8ViLH1aZCYGK6L4r +dI+BCwCVbFbr/+G80RyYZM1fYpiLS3KHORSdW1QJ01r3hUCrzf0wyI7o3+cRIOZ+2ob YlL/DLbP8A2q8kpKDJVwsw07DylUn/dnaEME7OxCxF9lFYyAqMiTn0B9+E/v1N+BVP+7 SnoqrUPz+WCpiTjQj+z6LRIMZlVkhXXiNMshxwTKfXX9UiCWC8JzSrmDoYijhDRM2qEQ 7b7BXvZGktkRNndn5wdgLM3Son+Xq2dU4LEpwJolutinxTsib8pcMVeXIMQgUiLBRSRD IX+g== X-Gm-Message-State: AOJu0YxoRTHLAf8qVcSc3GsLB7PS9llYx7HSLFmbZmNOyx+1POpEjV48 8wKyS/5BpzwWvXZ8cZLv79NJrRG9V3V9LNCfzuBzyQi4LsN677tYq9p5aJdEsL6WL5WmxDjGwZU MXxiGPKX+1u6nb0siGoJIdMeawFOJjji821dREPdIjWcimAw4Stp0YVttcgvJVoEHmQ== X-Received: by 2002:ac2:4da4:0:b0:513:9b6d:ab0e with SMTP id h4-20020ac24da4000000b005139b6dab0emr4633681lfe.5.1710180153529; Mon, 11 Mar 2024 11:02:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETnJu0e3N8VmiokKsVW5XDaT1zcxqKDDXAYnJVHfgyfutwQZWbXlppEYlTi9cMmUHBcc/BfA== X-Received: by 2002:ac2:4da4:0:b0:513:9b6d:ab0e with SMTP id h4-20020ac24da4000000b005139b6dab0emr4633667lfe.5.1710180153121; Mon, 11 Mar 2024 11:02:33 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id fm10-20020a05600c0c0a00b0041330de9587sm604284wmb.40.2024.03.11.11.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 11:02:32 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rjjyp-000uwj-Bc; Mon, 11 Mar 2024 18:02:31 +0000 Date: Mon, 11 Mar 2024 18:02:31 +0000 (UTC) From: Joseph Myers To: Florian Weimer cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 03/32] elf: Remove _dl_sysdep_open_object hook function In-Reply-To: <87il1slkzi.fsf@oldenburg.str.redhat.com> Message-ID: References: <659f5e52d04c2293d020eda2827212186dfbf92d.1701944612.git.fweimer@redhat.com> <16b2b5a-b0c5-1b4b-9930-5e4564f98ae8@redhat.com> <87v85slm9j.fsf@oldenburg.str.redhat.com> <346f6d6f-ddb1-78b9-2727-c229aadc95f7@redhat.com> <87il1slkzi.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On Mon, 11 Mar 2024, Florian Weimer wrote: > > It's probably helpful also to clearly mark the ones that need a fresh > > review (the ones that I commented on but didn't give a specific "OK" or > > "OK subject to these changes" to). > > I thought that the other category was just the rest? If there is a > third category, maybe that's easier to mark for me? I think there are just two categories: (a) approved (possibly subject to changes) and (b) others (all of which should have either questions or requested changes). But I also think it's useful to be explicit for each patch which category it's in (rather than just marking (a) with Reviewed-By and having (b) implied by the absence of Reviewed-By). -- Joseph S. Myers josmyers@redhat.com