From: Aurelien Jarno <aurelien@aurel32.net>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, Joseph Myers <josmyers@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
"H . J . Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH v3 2/7] math: Fix i386 and m68k fmod/fmodf on static build (BZ 31488)
Date: Sat, 11 May 2024 11:59:05 +0200 [thread overview]
Message-ID: <Zj9BaVwfCpAPKDhP@aurel32.net> (raw)
In-Reply-To: <20240402140644.2172819-3-adhemerval.zanella@linaro.org>
On 2024-04-02 11:06, Adhemerval Zanella wrote:
> The commit 16439f419b removed the static fmod/fmodf on i386 and m68k
> with and empty w_fmod.c (required for the ABIs that uses the newly
> implementation). This patch fixes by adding the required symbols on
> the arch-specific w_fmod{f}_compat.c implementation.
>
> To statically build fmod fails on some ABI (alpha, s390, sparc) because
> it does not export the ldexpf128, this is also fixed by this patch.
>
> Checked on i686-linux-gnu and with a build for m68k-linux-gnu with
> 'make test t=math/test-{float,double}-modf-static build-math-static-tests=yes'.
> ---
> sysdeps/i386/fpu/w_fmod_compat.c | 7 ++++---
> sysdeps/i386/fpu/w_fmodf_compat.c | 7 ++++---
> sysdeps/ieee754/ldbl-opt/s_ldexpl.c | 4 ++--
> sysdeps/m68k/m680x0/fpu/w_fmod_compat.c | 5 +++--
> sysdeps/m68k/m680x0/fpu/w_fmodf_compat.c | 7 ++++---
> 5 files changed, 17 insertions(+), 13 deletions(-)
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Tested-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://aurel32.net
next prev parent reply other threads:[~2024-05-11 9:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 14:06 [PATCH v3 0/7] Fix some libm static issues Adhemerval Zanella
2024-04-02 14:06 ` [PATCH v3 1/7] math: Add support for auto static math tests Adhemerval Zanella
2024-05-20 16:48 ` H.J. Lu
2024-05-20 17:21 ` Adhemerval Zanella Netto
2024-04-02 14:06 ` [PATCH v3 2/7] math: Fix i386 and m68k fmod/fmodf on static build (BZ 31488) Adhemerval Zanella
2024-05-11 9:59 ` Aurelien Jarno [this message]
2024-05-21 12:40 ` H.J. Lu
2024-05-21 12:54 ` Adhemerval Zanella Netto
2024-04-02 14:06 ` [PATCH v3 3/7] math: Fix i386 and m68k exp10 on static build Adhemerval Zanella
2024-05-11 9:59 ` Aurelien Jarno
2024-05-21 12:48 ` H.J. Lu
2024-05-21 12:54 ` Adhemerval Zanella Netto
2024-04-02 14:06 ` [PATCH v3 4/7] math: Fix isnanf128 " Adhemerval Zanella
2024-05-20 16:51 ` H.J. Lu
2024-05-20 18:53 ` Adhemerval Zanella Netto
2024-05-20 21:34 ` H.J. Lu
2024-05-21 12:32 ` Adhemerval Zanella Netto
2024-05-21 12:36 ` H.J. Lu
2024-05-21 12:56 ` Adhemerval Zanella Netto
2024-04-02 14:06 ` [PATCH v3 5/7] math: Provided copysignf128 for static libm on alpha, s390, and sparcv9 Adhemerval Zanella
2024-05-20 16:55 ` H.J. Lu
2024-05-20 19:04 ` Adhemerval Zanella Netto
2024-04-02 14:06 ` [PATCH v3 6/7] math: Provide frexpf128 " Adhemerval Zanella
2024-05-20 16:57 ` H.J. Lu
2024-05-20 19:06 ` Adhemerval Zanella Netto
2024-04-02 14:06 ` [PATCH v3 7/7] math: Provide modf128 " Adhemerval Zanella
2024-05-20 16:59 ` H.J. Lu
2024-05-20 19:07 ` Adhemerval Zanella Netto
2024-05-21 15:40 ` H.J. Lu
2024-05-21 16:41 ` Adhemerval Zanella Netto
2024-05-20 16:31 ` [PATCH v3 0/7] Fix some libm static issues Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj9BaVwfCpAPKDhP@aurel32.net \
--to=aurelien@aurel32.net \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=josmyers@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).