From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0A1701F44D for ; Thu, 21 Mar 2024 14:52:32 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=VTuHLoaR; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=VTuHLoaR; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4CF80385840E for ; Thu, 21 Mar 2024 14:52:31 +0000 (GMT) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2052.outbound.protection.outlook.com [40.107.20.52]) by sourceware.org (Postfix) with ESMTPS id 992743858D28 for ; Thu, 21 Mar 2024 14:52:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 992743858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 992743858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.20.52 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1711032732; cv=pass; b=Q/TpgTEbhWw5O56ozIcmdyHfwEPfDlqLxcTRs9MAecMztSVgPJGYAvUlkeSZCNlPLiJVgsLJ+YFA2CPBSWK78pZj01Ek4K8b8ntewPWnWAvVyRvIsWerRvMxOzP391oTqUxcldHhmojliaWAMl/CxtkqkM8ZQghDYvbbduzy8wQ= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1711032732; c=relaxed/simple; bh=hZX5q0Fk7xLS73+WeqZL/VpnV6Vv1bCl4PGh5rdNsww=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:Message-ID: MIME-Version; b=GHTm4xNoDNcif5l57At1N8Lmf/zQboF1baem5Ug853JLP84xdb0s/rjoL4k9busI9WpZZsPFwuDfLY7mgBqf9jCTWM4Js2thneC4R7il5Uyuxc/3NcnuAw7OxqdnNpXGbCnm9KtrMGLZwmQ3c42bmWCk4zCvTbO5+xgU7Td/CYI= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YmnslrtQdMjLlzQFM0n4Uaon4Y3y/5mbTrg1DrlKOS+xE0jpy9dD51ggRUiexl1CpPyYxRAsMMhPOC6LTZyAzvZKn2ZoCB9NzZV49/xDBXnSOPAGT/yqnf9NDgXb1jpIew2KKWX4fJp+ASu27BO1ALAmyG6CvEy2k1PTmcsWA4bIm9E/wJ5ODZYTtnEkl9ZJTsCpfexi6KSbxWTJoYZPx/cBP4qeGIS2QlDSWs9BscXlMZ4SRr5InJGWwqTO3j8HsGV8sHH1jjSnT9IoxCj7KOOmKqbUBzFc1BXay4iGw6dJ+4OuEJg9cOoaxaoAXXkd0inKn1mfaN4oPEo9lAqROQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Dbbb66wtZIxxUUFwfwt04pOZn4v6ZcA1/oXzVWqfNw=; b=Z1yuQJBXp+vExfFK7b36QJNDY9pR+7FCKu4LkmxbpmBz4lMgBvc/9LpEGya/XKEao7hArcsD3zd9Uv3jWsGhp966PEsdWcCYwfqjLB+uBsrTyjBNfFLNo7MQ7wo+kHr/l1cXKxrrobS9mvTaZzQhZzNroHWQJJJcTR/jYigPqGIlIobNBqgRFrCxaZze6gjFBWXQTc6TG4iGx/eqeScJ5ELjXT0oxY6QIdOddUM83pHHFxkLIcnnjUHGLWATZa3+fwsfnRX86JY/Uw388+BuPTFYRW1k4AIkvnhLRdOBqWwC0DH096GfRWHms/QufCOhZcL9vM+MKBcNIfAu9nePVg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Dbbb66wtZIxxUUFwfwt04pOZn4v6ZcA1/oXzVWqfNw=; b=VTuHLoaRkGTgQoRu/dqR+cf5FfCZ6F2T5aSeRZt+fk+6at3zAZvyhCaAWGSc0eEOCvy3y+vVrvYiTIn23Ebd4joBukWbSkQo6XMmRlyCZaKjaxkEopz4tNw0XwkAG4MdnQXkD/1vN0NOjnSsKia8ejKXG23o1g75CWLMIW5IDI4= Received: from DUZPR01CA0083.eurprd01.prod.exchangelabs.com (2603:10a6:10:46a::19) by AM9PR08MB6082.eurprd08.prod.outlook.com (2603:10a6:20b:2dc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.31; Thu, 21 Mar 2024 14:52:08 +0000 Received: from DU2PEPF00028D0B.eurprd03.prod.outlook.com (2603:10a6:10:46a:cafe::3b) by DUZPR01CA0083.outlook.office365.com (2603:10a6:10:46a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.28 via Frontend Transport; Thu, 21 Mar 2024 14:52:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU2PEPF00028D0B.mail.protection.outlook.com (10.167.242.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.10 via Frontend Transport; Thu, 21 Mar 2024 14:52:07 +0000 Received: ("Tessian outbound 9b7417e2a8eb:v300"); Thu, 21 Mar 2024 14:52:07 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f0d945a1a4352e1a X-CR-MTA-TID: 64aa7808 Received: from b3da0f18ed7a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A145EE62-6590-4678-A5CC-5528D3E3068A.1; Thu, 21 Mar 2024 14:52:01 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b3da0f18ed7a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Mar 2024 14:52:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ygxxb2/t1w3pqDZKlBGlh82YpEvN8bzTJbwPsC+Nfjzmzm3b5yDaJN8GVc9ZIyOOals8Ql3K3oLVpAoGAiGslb+NI+5eKllAXX1/RqO4q0SoFBMMEPLrigGMgbyiEcXpoYB+905Gva5EcDu+rRUflZctFWzgrSNEAZdmVdfyXzz7rbenbHfABZWSHM+RiSdSkAY/XqHW/aUH2gc+IhAcq3wZ6bij5jy91i66w8GhpRid2Qz29TtZqcVQcHw9iFypjunHl3+15LbB2u4iWaiwOiPzykWdBzcqj59EpRz2sVD5m0BFBjxTC2Lf3wLJKWBg4uxAPhi47yANtueSIlo9ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Dbbb66wtZIxxUUFwfwt04pOZn4v6ZcA1/oXzVWqfNw=; b=eG5svazrRqI7aMgsbwX3H9Rjjz0CzT74k1lO7eOBBeImPxRUBJwLjgrs10mbG4P/+EMmw3jTcPkwjdEgNDijnEZserbNuB8RJU1UbNJSF/cHTaE2LhzcwVmSGf/jvyiXZysh62s1QBXDb/QGDZrx2f0eca3ZcxKrkBdyHxjNpK+EBpDrjNaylE7g/RddfQwj6IGhaVDA5i7fNg5UwE9/HCLEUsxelCefIZ6eaXvzY4QIScfuuJtq73KJ97GiSNdkRgTkL9voT8Q0PHUaW6462N+GU3NRTLJSA6oxhPy13uqzkxnhXorjXG1bSBSIqmVP/hpgvG/fm1N9U4sFBC8jrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Dbbb66wtZIxxUUFwfwt04pOZn4v6ZcA1/oXzVWqfNw=; b=VTuHLoaRkGTgQoRu/dqR+cf5FfCZ6F2T5aSeRZt+fk+6at3zAZvyhCaAWGSc0eEOCvy3y+vVrvYiTIn23Ebd4joBukWbSkQo6XMmRlyCZaKjaxkEopz4tNw0XwkAG4MdnQXkD/1vN0NOjnSsKia8ejKXG23o1g75CWLMIW5IDI4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DBBPR08MB6091.eurprd08.prod.outlook.com (2603:10a6:10:1f4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.15; Thu, 21 Mar 2024 14:51:59 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::8c23:46ef:c2c9:ea91]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::8c23:46ef:c2c9:ea91%4]) with mapi id 15.20.7386.030; Thu, 21 Mar 2024 14:51:59 +0000 Date: Thu, 21 Mar 2024 14:51:46 +0000 From: Szabolcs Nagy To: Joe Ramsay , Subject: Re: [PATCH 7/8] aarch64/fpu: Add vector variants of tanh Message-ID: References: <20240220165945.21585-1-Joe.Ramsay@arm.com> <20240220165945.21585-7-Joe.Ramsay@arm.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240220165945.21585-7-Joe.Ramsay@arm.com> X-ClientProxiedBy: LO2P265CA0444.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::24) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|DBBPR08MB6091:EE_|DU2PEPF00028D0B:EE_|AM9PR08MB6082:EE_ X-MS-Office365-Filtering-Correlation-Id: b41c1ec8-89a1-4780-6027-08dc49b67b1e x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Z1nJ+1ERLweTvSPlVoduTg1wa5sPWyC9bPkK7OSq/JL7h/YE7T9NtDeALbuDiMTLeSc5Ky/muSWCSvAjCg4pYAuF+m1Da4AjhNc3ylNSgSKePwykp3pWLL3Rscjmbfi/PG2pxMW9haZfZAKmQPa2iRXCSGjGWMU07R9BfHShG1vFXnoysSJbHZTu5gz0gVfc0dAJ18rniU9KjCLqFBy9gfD6avBvXYrR4hgQaBSxW8/Vbb9jr1pDWqmq3TpYnQc1hkz+0LdH8Ooyjp5JrNqyrjlxoiKvqY4yC4tkmpL7RwIrUATVt00Tm0c3vTechkywQDhgxcl1jLqfHXur4saOYsvtY+ULeTnVSrqQ1ddWfSY8Nnw4/8d2mCSsdAI99baYmLWpzZrnLf+U3/3Yp7U2lBt66LsxDIVLiE8tu6le2LLs+FnbpAgySS3ztHDbTAJLJlfhbBXiANF1tOJQKJUHsOkquR+cOZu/xm+j3s/wRJgBiGPjW/B6B+VFUyB0Q7NmS2RYFe317Wo3dHaVany04Ctf9V0KhjkxQ2qfCBwgc8bb3s/01m9dtJiwcjVmhWxhTU4QYw3CirWwAhEVtxpgNpWaEhBkT5gBKu0+c+63+idHRniGn7K68fNO0D+GMptUwZPDRJXaRfT3lsSm5Ex46swSXwHQoXmcBhGntz8C4Ss= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6091 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028D0B.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1efce0c7-7d61-41a8-210c-08dc49b675f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d//eQUmbJz3fsvsUzr7LAnXQISelUDPLsIrT3W/sFxnIWhcakWbSdQgceJKhr6nUiLRqcBrsB1WM8HvgjXiDxxqyxxwNKJiYBh/EgRu9lMkez+xv0hrAL14Wmch9kuiIv+IPdKnvryZ99Tbf5fNDa35stJZB5YSULo0jMkwjq0zPmFAztxunt8IzrjDugUtva2hJIpTWHxXMFEjh4m5Prxvn4X5n9HZBkGrOim0idahnq08rzI3iEefm0FYXqseWTqfIfRj/6jMYmAe/d0xdRpZtaUD+jEE5GvEVtm06zHlBVOjeo2wa1mDRTSXPu7izEY8HZ1U/xdDPA+JKKa8YDVFLHupcckRIvDyM6VIE2NiTI8K6S6ffBzoucGDyKlog4lTqNEYHQiDms/IeYNzRaBwQWvRe23wf48llQCjEw2DlXKi6Xvujof/egBsWxvYDpuI6NmJS8VuroMxjhEMGbBXM+TEbhj20gf8YUHTec+olHcaTk3Vf3t6qgmMD/42+PUCYK8wlPQAwNCWRF2e8hqP8iWWw0FSAyzDSorjtNsPTyGAJDwslqAY8RU9kzk9bJfuOk28/bBOLs9e/N25/5LxQABbjYNLNRxRPVlvNth6VIMHUTyphSs9qgEnTAdBavubEyCrRpk3k/fKGQeYlFMyUikYA2EBIOiAeZl41Y2+ynDj4qYF1XVqp1l9idF2HQqa3w+E3NXIDxU3tzcEUMsNzo88+Wl5vkJJQRN2Z53fXf1kMjEWAkg5ODTHlnvyZ X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(376005)(36860700004)(82310400014)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2024 14:52:07.8075 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b41c1ec8-89a1-4780-6027-08dc49b67b1e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D0B.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6082 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org The 02/20/2024 16:59, Joe Ramsay wrote: > --- OK. (non-aarch64 changes look OK too) Reviewed-by: Szabolcs Nagy > Thanks, > Joe > math/auto-libm-test-in | 2 +- > math/auto-libm-test-out-tanh | 50 ++++---- > sysdeps/aarch64/fpu/Makefile | 3 +- > sysdeps/aarch64/fpu/Versions | 5 + > sysdeps/aarch64/fpu/advsimd_f32_protos.h | 1 + > sysdeps/aarch64/fpu/bits/math-vector.h | 8 ++ > sysdeps/aarch64/fpu/tanh_advsimd.c | 109 ++++++++++++++++++ > sysdeps/aarch64/fpu/tanh_sve.c | 100 ++++++++++++++++ > sysdeps/aarch64/fpu/tanhf_advsimd.c | 76 ++++++++++++ > sysdeps/aarch64/fpu/tanhf_sve.c | 61 ++++++++++ > .../fpu/test-double-advsimd-wrappers.c | 1 + > .../aarch64/fpu/test-double-sve-wrappers.c | 1 + > .../aarch64/fpu/test-float-advsimd-wrappers.c | 1 + > sysdeps/aarch64/fpu/test-float-sve-wrappers.c | 1 + > sysdeps/aarch64/libm-test-ulps | 8 ++ > .../unix/sysv/linux/aarch64/libmvec.abilist | 5 + > 16 files changed, 405 insertions(+), 27 deletions(-) > create mode 100644 sysdeps/aarch64/fpu/tanh_advsimd.c > create mode 100644 sysdeps/aarch64/fpu/tanh_sve.c > create mode 100644 sysdeps/aarch64/fpu/tanhf_advsimd.c > create mode 100644 sysdeps/aarch64/fpu/tanhf_sve.c > > diff --git a/math/auto-libm-test-in b/math/auto-libm-test-in > index d728f97770..05d7ae5002 100644 > --- a/math/auto-libm-test-in > +++ b/math/auto-libm-test-in > @@ -7747,7 +7747,7 @@ tan min_subnorm > tan -min_subnorm > > tanh 0 > -tanh -0 > +tanh -0 no-mathvec > tanh 0.75 > tanh -0.75 > tanh 1.0