From: Stafford Horne via Libc-alpha <libc-alpha@sourceware.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 4/6] linux: Implement pipe in terms of __NR_pipe2
Date: Sat, 27 Nov 2021 08:03:21 +0900 [thread overview]
Message-ID: <YaFnuecg9Aw3eCor@antec> (raw)
In-Reply-To: <20211122185437.1934590-5-adhemerval.zanella@linaro.org>
On Mon, Nov 22, 2021 at 03:54:35PM -0300, Adhemerval Zanella wrote:
> It removes the arch-specific implementation for alpha, ia64,
> mips, sh, and sparc which requires a different kernel ABI
> than the usual one.
>
> Checked on x86_64-linux-gnu and with a build for the affected ABIs.
> ---
> sysdeps/unix/alpha/pipe.S | 30 --------------
> sysdeps/unix/mips/pipe.S | 31 ---------------
> sysdeps/unix/sysv/linux/alpha/pipe.S | 1 -
> sysdeps/unix/sysv/linux/ia64/pipe.S | 36 -----------------
> sysdeps/unix/sysv/linux/mips/pipe.S | 1 -
> sysdeps/unix/sysv/linux/{generic => }/pipe.c | 5 ++-
> sysdeps/unix/sysv/linux/sh/pipe.S | 42 --------------------
> sysdeps/unix/sysv/linux/sparc/sparc32/pipe.S | 38 ------------------
> sysdeps/unix/sysv/linux/sparc/sparc64/pipe.S | 39 ------------------
> sysdeps/unix/sysv/linux/syscalls.list | 1 -
> 10 files changed, 3 insertions(+), 221 deletions(-)
> delete mode 100644 sysdeps/unix/alpha/pipe.S
> delete mode 100644 sysdeps/unix/mips/pipe.S
> delete mode 100644 sysdeps/unix/sysv/linux/alpha/pipe.S
> delete mode 100644 sysdeps/unix/sysv/linux/ia64/pipe.S
> delete mode 100644 sysdeps/unix/sysv/linux/mips/pipe.S
> rename sysdeps/unix/sysv/linux/{generic => }/pipe.c (87%)
> delete mode 100644 sysdeps/unix/sysv/linux/sh/pipe.S
> delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc32/pipe.S
> delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/pipe.S
This patch all looks good to me.
We might want to mention in the commit message that this is allowed because:
The syscall pipe2 was added in linux 2.6.27 and glibc requires linux 3.2.0.
For reference, these patches set the tree wided minimum required version most
recently. I dont know what it was before but its fare to say using pipe2 is
safe.
2016: 5b4ecd3f95 ("Require Linux 3.2 except on x86 / x86_64, 3.2 headers everywhere.").
2017: 139ace9575 ("Require Linux kernel 3.2 or later on x86 / x86_64.").
-Stafford
next prev parent reply other threads:[~2021-11-26 23:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 18:54 [PATCH 0/6] linux: Some syscall refactors Adhemerval Zanella via Libc-alpha
2021-11-22 18:54 ` [PATCH 1/6] linux: Add fanotify_mark C implementation Adhemerval Zanella via Libc-alpha
2021-11-24 21:45 ` Stafford Horne via Libc-alpha
2021-11-25 12:55 ` Adhemerval Zanella via Libc-alpha
2021-11-22 18:54 ` [PATCH 2/6] linux: Add prlimit64 " Adhemerval Zanella via Libc-alpha
2021-11-25 23:39 ` Stafford Horne via Libc-alpha
2021-11-30 11:51 ` Adhemerval Zanella via Libc-alpha
2021-11-22 18:54 ` [PATCH 3/6] linux: Implement mremap in C Adhemerval Zanella via Libc-alpha
2021-11-26 0:26 ` Stafford Horne via Libc-alpha
2021-11-30 11:55 ` Adhemerval Zanella via Libc-alpha
2021-11-22 18:54 ` [PATCH 4/6] linux: Implement pipe in terms of __NR_pipe2 Adhemerval Zanella via Libc-alpha
2021-11-26 23:03 ` Stafford Horne via Libc-alpha [this message]
2021-11-30 14:53 ` Adhemerval Zanella via Libc-alpha
2021-11-22 18:54 ` [PATCH 5/6] linux: Add generic syscall implementation Adhemerval Zanella via Libc-alpha
2021-11-22 18:54 ` [PATCH 6/6] linux: Add generic ioctl implementation Adhemerval Zanella via Libc-alpha
2021-12-04 7:50 ` Stafford Horne via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaFnuecg9Aw3eCor@antec \
--to=libc-alpha@sourceware.org \
--cc=adhemerval.zanella@linaro.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).