From: Aurelien Jarno <aurelien@aurel32.net>
To: libc-alpha@sourceware.org
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH v2] posix: Fix attribute access mode on getcwd [BZ #27476]
Date: Tue, 14 Sep 2021 16:06:11 +0200 [thread overview]
Message-ID: <YUCsU2BtkwZtnAAj@aurel32.net> (raw)
In-Reply-To: <20210910183822.1458644-1-aurelien@aurel32.net>
Any opinion about that patch? Florian maybe given you have reviewed v1?
Thanks
Aurelien
On 2021-09-10 20:38, Aurelien Jarno wrote:
> There is a GNU extension that allows to call getcwd(NULL, >0). It is
> described in the documentation, but also directly in the unistd.h
> header, just above the declaration.
>
> Therefore the attribute access mode added in commit 06febd8c6705
> is not correct. Drop it.
> ---
> posix/bits/unistd.h | 5 ++---
> posix/unistd.h | 3 +--
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
> Note: I am aware of BZ #26545, however while it is being discussed, the
> bug is still there, so I don't think we should block on a decision to
> fix it.
>
> diff --git a/posix/bits/unistd.h b/posix/bits/unistd.h
> index f0831386c7..622adeb2b2 100644
> --- a/posix/bits/unistd.h
> +++ b/posix/bits/unistd.h
> @@ -199,10 +199,9 @@ __NTH (readlinkat (int __fd, const char *__restrict __path,
> #endif
>
> extern char *__getcwd_chk (char *__buf, size_t __size, size_t __buflen)
> - __THROW __wur __attr_access ((__write_only__, 1, 2));
> + __THROW __wur;
> extern char *__REDIRECT_NTH (__getcwd_alias,
> - (char *__buf, size_t __size), getcwd)
> - __wur __attr_access ((__write_only__, 1, 2));
> + (char *__buf, size_t __size), getcwd) __wur;
> extern char *__REDIRECT_NTH (__getcwd_chk_warn,
> (char *__buf, size_t __size, size_t __buflen),
> __getcwd_chk)
> diff --git a/posix/unistd.h b/posix/unistd.h
> index 3dca65732f..8224c5fbc9 100644
> --- a/posix/unistd.h
> +++ b/posix/unistd.h
> @@ -528,8 +528,7 @@ extern int fchdir (int __fd) __THROW __wur;
> an array is allocated with `malloc'; the array is SIZE
> bytes long, unless SIZE == 0, in which case it is as
> big as necessary. */
> -extern char *getcwd (char *__buf, size_t __size) __THROW __wur
> - __attr_access ((__write_only__, 1, 2));
> +extern char *getcwd (char *__buf, size_t __size) __THROW __wur;
>
> #ifdef __USE_GNU
> /* Return a malloc'd string containing the current directory name.
> --
> 2.30.2
>
>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2021-09-14 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 18:38 [PATCH v2] posix: Fix attribute access mode on getcwd [BZ #27476] Aurelien Jarno
2021-09-14 14:06 ` Aurelien Jarno [this message]
2021-09-16 8:28 ` Florian Weimer via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUCsU2BtkwZtnAAj@aurel32.net \
--to=aurelien@aurel32.net \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).