From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-1.7 required=3.0 tests=AWL,BAYES_00, DATE_IN_FUTURE_06_12,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, DKIM_VALID_EF,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C2AE81F8C6 for ; Thu, 9 Sep 2021 02:21:07 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6A10F386486C for ; Thu, 9 Sep 2021 02:21:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6A10F386486C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631154066; bh=a3LUCyizlRYZlBWBylsWhcpnG2Xc58755/W12SzlXY0=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=i6HxEVkgIh8iWv0SaaGSTKfkfhWePv5Cg+6rMD37vpKMkc6/7kySoPOteM7swzAdD jv1Ar2XaU23tyLSQ6mlugnBW0IS91awxU0cjmuSIcmo8yfbHU1xFfqxYHSNp5zUPFV d8D06T4jBnH9mPkR30SxJpYE2n5m3Tof+Iszzm4I= Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2091.outbound.protection.outlook.com [40.107.236.91]) by sourceware.org (Postfix) with ESMTPS id 3766E384F00D for ; Thu, 9 Sep 2021 02:20:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3766E384F00D ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mct4l4Jm4wwsy4C76DhYNr4zHOvSLIZrzmu1v9vqdNnVQq369Yhpa77bNFCo2nWUASz1/T9j/7tR5UHKTZay7njZn/rEcdjhURV6MlC7BobxAFNYFdqz+m0BuP3lvwomcsTZONakuvnrrtkpQgmRVa4N/uhIukJgkDs8hZ2+sX8ObIWArW6/q/PI1YeLNGoA/cfvFHdpsxPrJwa2zJioY8wL2Hv01KjVjpbwVZ2MthV5tYKC8cTsLkuU230Yya+kaMPPOLAavghzqw0ulEc9fanlcOXqQs4xhgV2GfYA6i70XKUq1+6ZwGRhn+I5jcynVpD/4oEhaxl+O6/HGVoVPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=a3LUCyizlRYZlBWBylsWhcpnG2Xc58755/W12SzlXY0=; b=hgtQeWUWSb5xGXQWPvNBA8OR9bxh4GEylHg35waKbXicHIbC7Nt+Iuj3tQpf+21A5/3NstBz1W7IMYxuymHp+RWQOlCirKASDk9G7tyZE2W0eIKLk5//NHCkvKcpB7/HwzCbgf9WERde2tnBrezxeLW0eks4rjGTj5sBjkyPI5WhyWbrlJfxpe6e+nnm35VotfKS9II1YPEwC5zF+pq/fCr3r/w82MDUGI/9lTlFMdQDmjLxIRmxB7LWSfEToHuQZrjCdNELx1MAaApdA45RuLnXeMPsImS+LAIVicZsaA/9rECBXle76wkY02dHRw1zfELz4RzWJ7GBTJhN1QlzHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none Received: from MWHPR0101MB3165.prod.exchangelabs.com (2603:10b6:301:2f::19) by MW4PR01MB6148.prod.exchangelabs.com (2603:10b6:303:7d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Thu, 9 Sep 2021 02:20:43 +0000 Received: from MWHPR0101MB3165.prod.exchangelabs.com ([fe80::ed89:1b21:10f4:ed56]) by MWHPR0101MB3165.prod.exchangelabs.com ([fe80::ed89:1b21:10f4:ed56%3]) with mapi id 15.20.4478.022; Thu, 9 Sep 2021 02:20:43 +0000 Date: Thu, 9 Sep 2021 10:19:09 +0000 To: Florian Weimer Subject: Re: [PATCH] Add LD_NUMA_REPLICATION for glibc Message-ID: References: <20210903121434.12162-1-shijie@os.amperecomputing.com> <87bl5a6ul2.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bl5a6ul2.fsf@oldenburg.str.redhat.com> X-ClientProxiedBy: CY4PR06CA0058.namprd06.prod.outlook.com (2603:10b6:903:13d::20) To MWHPR0101MB3165.prod.exchangelabs.com (2603:10b6:301:2f::19) MIME-Version: 1.0 Received: from hsj (180.167.209.74) by CY4PR06CA0058.namprd06.prod.outlook.com (2603:10b6:903:13d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 02:20:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3eed63fa-633f-4751-8313-08d973386c9f X-MS-TrafficTypeDiagnostic: MW4PR01MB6148: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e3DpVCmSd+R119oOxB02lTu7KzgLvSdNaZJ8I2buj/XfZAsfwGSMyE5zq6SG0iGgSApzc8aXDhm5ioZdro9jFpTFcdpDprlxrpfX4ulN1orRgMVVTCPyfYBAuYM+QIPwl4eZxqvLs7XRa4MKhz1MKDAyjpJXNX2BDjZpUOPIEv9tXgzTN7Im3803jGNT6N85gEZPB3yGI/Obv1K+jVgusQh6bm2+2nJu6yWZHoQ7N9XvP4iDq6xNRvpQs3ZTchjkfHm7aIgTZKbwZP0Jdk2j25fHkke4Skrn78eM3WtfPaW22QA2LLxrrQkQqKJNhVe534slIsvVisP2nwCiYLFvrGQ/Fr5omU/y8Ue/3l6AcJ2eIr4r09MeBr8UnYIc3nS/Y+bXPmhvYE9LykLiIbt3xKjWX5coucXhTzGB5lwbc4YZFwnxuMktZL690ZjembVkLn/7nec4/FJZknFvWugCDhg7ePwbHEVQl4WTeAZtVRvnDqh20QQG3EOQs7ieGKsfyR+3xHE1wsiXxxuvXmQvsj4NA0x+pK48q5KREKiUAB77MPpo6LBeXTpiiLLPBVzgJv4jMUiRrE2uwk0Q7AIFByM1Z8vBaDlW51fZMb55rWEO3gciDZgwR9maRBJYruq0b0eVxe4b7ea5XIRpD2qv9h76MlP1fQ3SZ8FOPhFE1vW52nbXGlliw6BvpAcV6NeRbWPOuurRxjrtPeCHkmE4JCI353WxUXywSIGReI1kuvPEToAUSjO2hmXNeEeZFnafhtA6rTWfxJPVhAu8n1qmnQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR0101MB3165.prod.exchangelabs.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(396003)(376002)(346002)(136003)(366004)(5660300002)(2906002)(107886003)(26005)(33716001)(66556008)(83380400001)(66476007)(6666004)(4326008)(52116002)(8676002)(8936002)(316002)(6496006)(9576002)(66946007)(478600001)(38350700002)(9686003)(186003)(966005)(86362001)(38100700002)(956004)(6916009)(55016002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/MXblQOwkUHbWS/qGw8mdfB1KvPMcGKwiut2XuX9mm3DKF4l3/9L+0j1b3HO?= =?us-ascii?Q?Na2OLh8bxOK/lUMeYtUtSbV5XsxexRpWlzW+uOly45OxjG/T0eNcGf3wJqz1?= =?us-ascii?Q?pgRJ9E1vt8i9hMzMDLZHkQ9T8AQ1RKYUXVUua7iHbbPIugw4WeODp6TYq7Pj?= =?us-ascii?Q?GkTyFBAtZ+641A9x/+xBmGN5kAnwtm4KJY9PDtiZvxVcsvgPLV2r2n2rlixk?= =?us-ascii?Q?b6EmVhtGaz0VYcWTAkTtnbzHwB3mfDmlWOTiD+vpFU71vrb4l02qV58LvYds?= =?us-ascii?Q?tkwnYZITlqkzPlo8//Xw1hP88O71VY/rV21Ki4wb1YnfuQQC5XYJJBqHsJF/?= =?us-ascii?Q?TCWEJL7Pjy0gE9lWdA9ArNxJHfzrc0zNdkvuQw6+h7BD7npx0tf27RR4ox5m?= =?us-ascii?Q?VkSsXjP4oiNu+11A5yNESXfGb780bFMKJFVD3N44SKUu+OrUe/E7aCCyfCp5?= =?us-ascii?Q?WmVFKoeKLw1R8qyZlS8ziCzO+IssTIGPzg1qulHGQTnuK+e5wIXHRnetf8Sv?= =?us-ascii?Q?88Ys9/4GXNpGAZtGNhFALfQQYJUMrOJRUVLlKXbRKnPPDE6LtDzMvOGPzmGM?= =?us-ascii?Q?e7RctBl9iLDINxDZ5/Q1b/f1nUmo0M0V3Mbd5UhTkTa1Y5drg2+O0XDyjGu9?= =?us-ascii?Q?dSsJOtKU9j+speSnV8BlPJPyWkDg9Xaj7VG54Ol+J7OvU1yLtn5cjOa8TEgW?= =?us-ascii?Q?vcxeFCUiATRKh0/WjmeRxAfXo+vsHaS3GalNiijb088FXPlfu/UDmv2e2Hvk?= =?us-ascii?Q?yaG7JNKfwWeOOUKAoO1s/Se4oL/kh332cZoT4q1PJR4dvZ8DZx/KoiSxFZJj?= =?us-ascii?Q?jQgD7sQvkXJfEJgsO4ezDIyItwHkOKA7Du28AjeS9GJowKxndF3+VXj5+8ci?= =?us-ascii?Q?SoVUhRzLwAbDV4NbKCg4nMDjWDhRIAEM7wS+xoTvoFnfna8wGEir9SB91cSL?= =?us-ascii?Q?ZFwEyUlZr22mwyfCzJT0QMDWpWBevKav79ATLAkgr/EgKxSMQG/28t/caOnq?= =?us-ascii?Q?Z5OisYYWjzxZ8eVDtM+i3qImSU7MVHAHoDhxAShusI8tAMkzVe9mM6YeL3+b?= =?us-ascii?Q?4dIe9zbmNjR1KiS9Y5DGzl/agGaFPCpLb9sGs9ozWL121ylrx3+ABRCdtTWs?= =?us-ascii?Q?7LHD1xWroF73QgYPqzAJaxs7bn7pZjrvnnlDx/620IwTct9T6kdhEhIGt6XD?= =?us-ascii?Q?5ohF78FEGapfJ4DJI1DQdP+Oa01FVq5moL/wkkyFrGYhRk2BYwNEaYEWuuZ3?= =?us-ascii?Q?nAiOQfm3HPDlQuyzPb2z5273GoNWWtIejzcLkuGSMW103f6MjAEXdEgGRKCS?= =?us-ascii?Q?04O8z4K+yJX7xZapC57Gge+8?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3eed63fa-633f-4751-8313-08d973386c9f X-MS-Exchange-CrossTenant-AuthSource: MWHPR0101MB3165.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 02:20:43.0180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YJH0XJ0XJOIlo8K3bd+YEKzf4/fwzEjJp+w23DXwXW3rD5y7fUcfMfqSCTrnWVEA+Rh9wGgfGfSpNDzyaYHzCXj/nAQFucikUZ7mLC2szw9GYIZaymCbWHL6Cd104CLy X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR01MB6148 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Huang Shijie via Libc-alpha Reply-To: Huang Shijie Cc: zwang@amperecomputing.com, Huang Shijie via Libc-alpha , patches@amperecomputing.com Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Hi Florian, On Fri, Sep 03, 2021 at 08:28:57AM +0200, Florian Weimer wrote: > * Huang Shijie via Libc-alpha: > > > This patch adds LD_NUMA_REPLICATION which influences the linkage of shared libraries at run time. > > > > If LD_NUMA_REPLICATION is set for program foo like this: > > #LD_NUMA_REPLICATION=1 ./foo > > > > At the time ld.so mmaps the shared libraries, it will uses > > mmap(, c->prot | PROT_WRITE, MAP_COPY | MAP_FILE | MAP_POPULATE,) > > for them, and the mmap will trigger COW(copy on write) for the shared > > libraries at the NUMA node which the program `foo` runs. After the > > COW, the foo will have a copy of the shared library segment(mmap > > covered) which belong to the same NUMA node. > > > > So when enable LD_NUMA_REPLICATION, it will consume more memory, > > but it will reduce the remote-access in NUMA. > > I think the kernel could do this in a much better way, avoiding > duplicating the pages within the same NUMA node. https://marc.info/?l=linux-kernel&m=163070220429222&w=2 Since Linus did not think it a good choice to do it in kernel, glibc is the only place to do it now. So could you please re-evaluate this patch? > > The other issue is the temporary RWX mapping, which does not > interoperate well with some security hardening features. Could you please tell me in detail? I am confused at it. Thanks Huang Shijie