From: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
To: GNU C Library <libc-alpha@sourceware.org>,
GDB <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH v2] gdbserver: Check r_version < 1 for Linux debugger interface
Date: Mon, 16 Aug 2021 13:30:50 -0700 [thread overview]
Message-ID: <YRrK+nOJmShP932/@gmail.com> (raw)
Update gdbserver to check r_version < 1 instead of r_version != 1 so
that r_version can be bumped for a new field in the glibc debugger
interface to support multiple namespaces. Since so far, the gdbserver
only reads fields defined for r_version == 1, it is compatible with
r_version >= 1.
All future glibc debugger interface changes will be backward compatible.
If there is ever the need for backward incompatible change to the glibc
debugger interface, a new DT_XXX element will be provided to access the
new incompatible interface.
PR gdb/11839
* linux-low.cc (linux_process_target::qxfer_libraries_svr4):
Check r_version < 1 instead of r_version != 1.
---
gdbserver/linux-low.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc
index 5c6191d941c..fc7a995351d 100644
--- a/gdbserver/linux-low.cc
+++ b/gdbserver/linux-low.cc
@@ -6845,7 +6845,7 @@ linux_process_target::qxfer_libraries_svr4 (const char *annex,
if (linux_read_memory (priv->r_debug + lmo->r_version_offset,
(unsigned char *) &r_version,
sizeof (r_version)) != 0
- || r_version != 1)
+ || r_version < 1)
{
warning ("unexpected r_debug version %d", r_version);
}
--
2.31.1
next reply other threads:[~2021-08-16 20:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 20:30 H.J. Lu via Libc-alpha [this message]
2021-08-16 22:02 ` [PATCH v2] gdbserver: Check r_version < 1 for Linux debugger interface H.J. Lu via Libc-alpha
2021-08-16 22:08 ` H.J. Lu via Libc-alpha
2021-08-17 13:17 ` Simon Marchi via Libc-alpha
2021-08-17 13:48 ` Florian Weimer via Libc-alpha
2021-08-17 14:04 ` H.J. Lu via Libc-alpha
2021-08-17 13:13 ` Simon Marchi via Libc-alpha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRrK+nOJmShP932/@gmail.com \
--to=libc-alpha@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).