From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 65A761F8C6 for ; Wed, 11 Aug 2021 06:52:41 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6331B396EC85 for ; Wed, 11 Aug 2021 06:52:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6331B396EC85 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628664760; bh=+TJ+OhWlcauXosQOChSoJMT/KlxIYxXclJjR2Oz27tM=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=AYw9pTEWG1RLYKSPNu0xV1tHiVDB/a55Z9ac3MDE7dtrRwSWQXuUFXXQ9aRMELsiC R06Pb/5k7hY8t0NAz4kRNy21onKF1n9OMVvCvD/g/D99NLDv4D8aijlSablZwxaFBS lmHnPP5cicvw2Zr5/kH5wPZFLzhd1mp/Qw2W+uTU= Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by sourceware.org (Postfix) with ESMTPS id 92E5D3854834; Wed, 11 Aug 2021 06:52:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 92E5D3854834 X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="278814461" X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="278814461" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 23:52:17 -0700 X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208";a="675920822" Received: from pmccarty-dev.jf.intel.com (HELO intel.com) ([10.54.74.125]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 23:52:17 -0700 Date: Tue, 10 Aug 2021 23:52:11 -0700 To: Siddhesh Poyarekar Subject: Re: [PATCH] iconvconfig: Fix behaviour with --prefix [BZ #28199] Message-ID: References: <20210809062740.322823-1-siddhesh@sourceware.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210809062740.322823-1-siddhesh@sourceware.org> X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Patrick McCarty via Libc-alpha Reply-To: Patrick McCarty Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 2021-08-09 at 11:57:40 +0530, Siddhesh Poyarekar wrote: > The consolidation of configuration parsing broke behaviour with > --prefix, where the prefix bled into the modules cache. Accept a > prefix which, when non-NULL, is prepended to the path when looking for > configuration files but only the original directory is added to the > modules cache. > > This has no effect on the codegen of gconv_conf since it passes NULL. > > Reported-by: Patrick McCarty > Reported-by: Michael Hudson-Doyle > Signed-off-by: Siddhesh Poyarekar > --- > iconv/gconv_conf.c | 2 +- > iconv/gconv_parseconfdir.h | 21 +++++++++++++++------ > iconv/iconvconfig.c | 16 ++++++++++++---- > 3 files changed, 28 insertions(+), 11 deletions(-) Testing the patch locally, I see that the prefix is now absent from the modules cache, so this change looks good on my end. Regards, -Patrick