From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5F7EA1F910 for ; Mon, 7 Nov 2022 16:41:59 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="kl4h+8sh"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 72F323858C39 for ; Mon, 7 Nov 2022 16:41:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72F323858C39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667839315; bh=EvFzxWLLtKEqanbS1tGZlgy0I9mvqD8NHeeg5iKYCdQ=; h=Date:To:Cc:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=kl4h+8shz+XmiZfzJuSzOdvFixaQJ2LPwxogYrIn2RdTQiP8+oE+3SQ25EBBeX9i2 2+9FTzcHQsXPfESCIfIVTPPTwFriHoL9YHpuJ+XWrIBXoK+S/FV2W5psElVx68CoRq gAMdCLccQLOLpyo9NRf68qep6IxCHZzUk6c4gDbY= Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2068.outbound.protection.outlook.com [40.107.247.68]) by sourceware.org (Postfix) with ESMTPS id 495603858D3C for ; Mon, 7 Nov 2022 16:41:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 495603858D3C ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XL9mTMbb03+9ityO7y1bCcxyt5wX4gQTzUbvC3G6/N5zSdl0Or2pU+OPKUdGweK5Ih3Ks54ImIZEhW9/zCOa+mEsRnQhybw70RSKZ9xy8MPi7x0GMfsaN3ZF8EJWtnLnZyqBEV60D9UqS0nV3NfhzfrGNekPQPcPj6U/BYGVE2wmg0Rjwbrau4yynjD599nojM1GP38CfGuWUYFDaqDqlfxrE2w9KvQA6j4spiIea3K/hBlo/lUiXKCcFpt+yGDZq+U1e3Mn+qsymHpSd/sPPzuxu1gMiU3i7PQR790KB7E46WwIjsb1Xv3GBFNWFQjbNxlGqWLNdiQUNe/BxPIJMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EvFzxWLLtKEqanbS1tGZlgy0I9mvqD8NHeeg5iKYCdQ=; b=DeaW2IWHtxcMl7AJTf0etA4jXt/+GBgaSMUKm4LPsBQcwfotsniTQGegEbyLLgEWENPa0gcU86nR5XdfS60sVACqtK/RyTSUlpVP4tGSd78/yIOmCifmefiw9pFDLFLWESUBYgtysffSqZ7CWG/8eiILJk5neSQ08WscJC8P26E/mY/1oXcc+tZRDaI0TV91TEtMQEdJCqUWRPvuAH69E9tDeFANo3LhvPekKuGAaqIsjm7ZSHyhgJNzcWsX857HurPHRlOcNwORa39MP8kfneaIDlQq4oja8joNgGx0yLAmH2n6FOpe4EgKAoBlcZ20DcYESHD8AcL3bo1eTXPpVQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DU2PR04CA0154.eurprd04.prod.outlook.com (2603:10a6:10:2b0::9) by AS8PR08MB8350.eurprd08.prod.outlook.com (2603:10a6:20b:56c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 16:41:23 +0000 Received: from DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b0:cafe::2d) by DU2PR04CA0154.outlook.office365.com (2603:10a6:10:2b0::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 16:41:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT023.mail.protection.outlook.com (100.127.142.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 16:41:23 +0000 Received: ("Tessian outbound 2ff13c8f2c05:v130"); Mon, 07 Nov 2022 16:41:23 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 74a1c2407eb8c2be X-CR-MTA-TID: 64aa7808 Received: from 3158083c4ae0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1F236116-B30D-4AFA-9A88-2B735790DD2C.1; Mon, 07 Nov 2022 16:41:16 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3158083c4ae0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 07 Nov 2022 16:41:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TdDH8kdzFAPLCgEQW/aZfDjGItq+E8TROrPU/iV6EkdQZfKqjLdculWc00+/sTOAsn+1di4DLxGEcawkapLu0nPCNgHWHqPBehnK8TENRWFG4J36tpnSICXTjmmPqox6/iyFDrfAFUx8A0GULZuecO1n783zb2fmW/z7pYCgkY9SeEujhVfBHATmSgkl0C/ot9cEJB/uOKePojRVpycnUqTJUr8nx/0QMUMeG7ma3EWfpgcXugVWeg9riftOEfNe3KIrnSK2g440pYEOFxkEkz1ASmDGk7FimHFT2cMgBRJo62kpLMqQ51eZcTjEve/pyq+/XthM7+m60v0Qpofbfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EvFzxWLLtKEqanbS1tGZlgy0I9mvqD8NHeeg5iKYCdQ=; b=FsKnwthr2Elg+ao23YvwJd/yLy0sWVj8VjcVWBxUd5IqWH3vGohPHlSgFaIkkCszu3gZ+yghLBW+fJbqh5UXcROLqfE72qQZF+2jc+P/tx7HQKLEkI7L0ofubp1Hq3ldWCcNA7HHPcLInLYdk7m1iHsf2prKSIHOoPBuSVTtpOIqbAl2xA2dDtBM3PReYnlqn+RlvzXUnl9qQ9Y9nTpIZAK8sqzNYCLEVUIZE9vpDGL8hegJMQDzdJCAecDLByJGsqNRijFLtZW62UCiaasJimsFnfpq91E4s/oTx77SG5fmvhJ7m/n58OvGmtPCz2FuLczKRvmp0qD5IaWudelE/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by DB8PR08MB5321.eurprd08.prod.outlook.com (2603:10a6:10:11c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11; Mon, 7 Nov 2022 16:41:13 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::81ce:94a0:632d:7016]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::81ce:94a0:632d:7016%3]) with mapi id 15.20.5813.011; Mon, 7 Nov 2022 16:41:12 +0000 Date: Mon, 7 Nov 2022 16:40:52 +0000 To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, "H . J . Lu" , Christian Brauner Subject: Re: [PATCH v2 02/11] linux: Extend internal clone3 documentation Message-ID: References: <20221104190112.2566409-1-adhemerval.zanella@linaro.org> <20221104190112.2566409-3-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221104190112.2566409-3-adhemerval.zanella@linaro.org> X-ClientProxiedBy: SN4PR0501CA0050.namprd05.prod.outlook.com (2603:10b6:803:41::27) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|DB8PR08MB5321:EE_|DBAEUR03FT023:EE_|AS8PR08MB8350:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e83ff45-5ec3-41a7-ee5f-08dac0dee7e9 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mWQu2EzRRRBQHPd282dhNSOp3cdUJ327oS+SKYZoe2S+dfomfUIEbmrHmkUzNYcx0c8zXaMYPA9BbG9Pr4Z0zLB7EqxljJEcrmQnQ9i1QJbtTRtO6ngirgsDPcEEFl8ca1g1KNRj//eyrIJvcTsSecuhvL6VSiwA+PbY010JD602QjgOAFsNEd6f4e0XZBpGKBEeyBDNCF1KzB/HwVBoA3euKBAE5o4c6awsFOtxciqsXTxSzVqtfai8AGkyoQI7HqN+/1RauDgt7RlWf7f7gm6XxQh2FU/lb3O+8eUuXgrSoL2zobZshOtztl/K3PchoktlksKWHxHPD9m+NOQLozcG/F2dwzuAVgCLeiFtlEqt8eI41FVONnSFUl+nwWpB1Hll9PWFXLS2hkO7o8F4ot8V+tO40/iJd90tlW58Lv7ElxUzQ55wwWBBGSz+Jhm1w6ihqP1LGL54fj+9riyfPveg2dYGMwynfrbvmEjMmCQGMwXRR9FZUXgUwGsO2GvAKX2SMJdu5EBnhiqe1Frk6hsJOPqAiD7Wy6RfL4Zv4hnEkF0UXpVzBnkY8yW6VO+Y9wCV8Uexc4NO8DLN8Qe2c4cSiQAOoNjFDZLPZ2/6Bv8g+bGyUDbdeK1Vq16SmDAJFxWK18L70u8ZbBynivkbyyf8Z/bcDKzvyi39XH+DX2jF2GNrxGGuPVmcjfBQiQFUPyZ9elM37aCVICdKeeTcDB8LELcxOV9Wp/GxGtc6ksx1BOMXSq3/xGaPt5d0YVm/ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR08MB7179.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(346002)(396003)(136003)(39860400002)(376002)(451199015)(186003)(2616005)(6506007)(83380400001)(54906003)(26005)(6512007)(5660300002)(44832011)(6666004)(2906002)(478600001)(6486002)(41300700001)(8936002)(8676002)(4326008)(66556008)(66476007)(66946007)(316002)(6916009)(38100700002)(86362001)(36756003)(2004002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5321 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 72dd8213-1ddc-430c-1aed-08dac0dee09b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z0XR0PTztNUIiFqMv8qV9WeEeGDTOk4GmcbvbqK817xEXucjxpZayXmMqCW1SgoJyDZ3Fv/UZ3eI+TEgrgWm9NXaZBs81QCFxfw3DdyWLaRNWioKYm1YzKD/vzZ+maMhLN5QQFjXwR4cyyNNn+gYyLs3naLfJUGnFpIjBzZArfpKOKwBkXD7WFp7ODR76qpqAj9X5la8iAZPmw4L8rs8lhuj4rjiryeWeub1Tqlu0oLI7C0S1mQCUn4pkRzbHmxkxoayR1/TAwfGKlx1fBPWOYKSg8w66ts5qJxszyiwoQeNvQ3+rDDasRw0IYhFlsud/mPboBrGxBP2Esk4gtPziq0X/eyUG4cb0CVciAPVv4AY1qwm352dQmny4wAsIEEzljuKjwxs4JuBMRTqbUEJzwpReOgn6gvfZmLLYnL1WgeJbEzUlxkLgwWvWvQJk7sXf3EKFj2fdsfDyoQg/d2O0zm1MshkPhX+EWuDOV5tKOU4P1fAq8I9Y1RB3JMMfYPsirBswgSgffg10/xqk0de4nklZ0QLdzNWmACLth03BWkz/xk6j4GvO+itbziE/6D71zJPuHSFiG3h1hXR6Drt9sHmFm8Tc91AucI/Y8SpKWny1HLcdU+dpLmcUtzJIutrF4BevE19OJO9advwzXkJISCcioB/EZtL2YfdACWeZ0ANPfYxrG9zQ8wySP3HExpDxvG+jDiEY2X/AJ7v4GIsO36M9dazJv2DgOLL61Gsg56NDOLC4DQOLi2nPqw+ww6DjpbTiEtv8hM2gAMTZ+Qf3Ncxx3PJZ+l60uooAWBlKrM= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(136003)(346002)(376002)(451199015)(46966006)(36840700001)(40470700004)(2906002)(478600001)(8676002)(70586007)(82740400003)(4326008)(8936002)(70206006)(41300700001)(44832011)(6862004)(6486002)(40480700001)(81166007)(316002)(5660300002)(40460700003)(83380400001)(356005)(36860700001)(6666004)(6506007)(107886003)(86362001)(186003)(336012)(47076005)(6512007)(2616005)(54906003)(26005)(82310400005)(36756003)(2004002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 16:41:23.2487 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e83ff45-5ec3-41a7-ee5f-08dac0dee7e9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8350 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Szabolcs Nagy via Libc-alpha Reply-To: Szabolcs Nagy Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" The 11/04/2022 16:01, Adhemerval Zanella wrote: > Different than kernel, clone3 returns EINVAL for NULL struct > clone_args or function pointer. This is similar to clone > interface that return EINVAL for NULL function argument. > > It also clean up the Linux clone3.h interface, since it not > currently exported. > > Checked on x86_64-linux-gnu. this looks reasonable. Reviewed-by: Szabolcs Nagy > --- > include/clone_internal.h | 24 +++++++++++++++++++----- > sysdeps/unix/sysv/linux/clone3.h | 10 +--------- > 2 files changed, 20 insertions(+), 14 deletions(-) > > diff --git a/include/clone_internal.h b/include/clone_internal.h > index 4b23ef33ce..73b8114df4 100644 > --- a/include/clone_internal.h > +++ b/include/clone_internal.h > @@ -1,10 +1,24 @@ > -#ifndef _CLONE3_H > -#include_next > +#ifndef _CLONE_INTERNAL_H > +#define _CLONE_INTERNAL_H > > -extern __typeof (clone3) __clone3; > +#include > > -/* The internal wrapper of clone/clone2 and clone3. If __clone3 returns > - -1 with ENOSYS, fall back to clone or clone2. */ > +/* The clone3 syscall provides a superset of the functionality of the clone > + interface. The kernel might extend __CL_ARGS struct in the future, with > + each version with a diffent __SIZE. If the child is created, it will > + start __FUNC function with __ARG arguments. > + > + Different than kernel, the implementation also returns EINVAL for an > + invalid NULL __CL_ARGS or __FUNC (similar to __clone). > + > + This function is only implemented if the ABI defines HAVE_CLONE3_WRAPPER. > +*/ > +extern int __clone3 (struct clone_args *__cl_args, size_t __size, > + int (*__func) (void *__arg), void *__arg); > + > +/* The internal wrapper of clone/clone2 and clone3. Different than __clone3, > + it will align the stack if required. If __clone3 returns -1 with ENOSYS, > + fall back to clone or clone2. */ > extern int __clone_internal (struct clone_args *__cl_args, > int (*__func) (void *__arg), void *__arg); > > diff --git a/sysdeps/unix/sysv/linux/clone3.h b/sysdeps/unix/sysv/linux/clone3.h > index 889014a6a9..7c7e2cdcb0 100644 > --- a/sysdeps/unix/sysv/linux/clone3.h > +++ b/sysdeps/unix/sysv/linux/clone3.h > @@ -1,4 +1,4 @@ > -/* The wrapper of clone3. > +/* The clone3 kernel interface definitions. > Copyright (C) 2021-2022 Free Software Foundation, Inc. > This file is part of the GNU C Library. > > @@ -23,8 +23,6 @@ > #include > #include > > -__BEGIN_DECLS > - > /* The unsigned 64-bit and 8-byte aligned integer type. */ > typedef __U64_TYPE __aligned_uint64_t __attribute__ ((__aligned__ (8))); > > @@ -58,10 +56,4 @@ struct clone_args > __aligned_uint64_t cgroup; > }; > > -/* The wrapper of clone3. */ > -extern int clone3 (struct clone_args *__cl_args, size_t __size, > - int (*__func) (void *__arg), void *__arg); > - > -__END_DECLS > - > #endif /* clone3.h */ > -- > 2.34.1 >