From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 4080C1F8C6 for ; Mon, 2 Aug 2021 14:38:50 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EE6C8382CC2D for ; Mon, 2 Aug 2021 14:38:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE6C8382CC2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627915129; bh=pJa8+vvAXYIGUi1QMlXFA5fDRuE5IKkxO9qGG/2a2vU=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=KfGNj7GQ0p7lRJt1+fIh6LQpGEQxcgYWNkWduHGD2YTbwXeqTt4NhThIPVpk0L8zQ Ay+/dgpdcORbnz65ZK60XihLToeE/W+cntYEnJLYizq+pfXlDRmnVWYbaJONwvrmna RPAYDg2wMtENSRdZrMRKAHGi9XhFcaO1Aq7EErQw= Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2053.outbound.protection.outlook.com [40.107.20.53]) by sourceware.org (Postfix) with ESMTPS id C1983385782D for ; Mon, 2 Aug 2021 14:38:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C1983385782D Received: from AM5PR1001CA0003.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::16) by HE1PR0802MB2185.eurprd08.prod.outlook.com (2603:10a6:3:ca::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.26; Mon, 2 Aug 2021 14:38:23 +0000 Received: from AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:2:cafe::60) by AM5PR1001CA0003.outlook.office365.com (2603:10a6:206:2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Mon, 2 Aug 2021 14:38:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT014.mail.protection.outlook.com (10.152.16.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Mon, 2 Aug 2021 14:38:23 +0000 Received: ("Tessian outbound 077ab11054bf:v101"); Mon, 02 Aug 2021 14:38:23 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3387abb61f9421d4 X-CR-MTA-TID: 64aa7808 Received: from fb5445f08c11.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1EA36EE6-820F-4562-AFE8-CE98924C03FC.1; Mon, 02 Aug 2021 14:38:16 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fb5445f08c11.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 02 Aug 2021 14:38:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=adUoN459lCsM6mRQ0AwuTvkuWfsOTaWiN9bMsAbnL96nGLAATfggh9ugscKAB0F7SUtzOATt/7p3xWNfOkVTNUXEIFAjUrWHBSpbuU+7Jdec34gZnwxaKeJLCLi3Fi2LReI9oumhVWIqI5yTS/TA5d0xT53vTBYtgESve7mB62Znmxb4R8bcLvh1RNFZqFeFFTj0CKMoynO8pi/J2qAKW2BrSGBqfg0m8/GUfE0WORJJpsJwVkTjfd7ze7YMkcHqtwvCW04bzbjs/Tv3DCoZri3O70wnbcp7S3luwDhOhiQiwhWTEmBKQU+Clmy2PrL/aCD1wvwUMetD7L2D0mfbrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pJa8+vvAXYIGUi1QMlXFA5fDRuE5IKkxO9qGG/2a2vU=; b=ehy89thqON6bonO/wABASl+/kaG4qswuqmN94/wKzNLc7Fm8wcm8ZspBpJyqVfvddQojLDsnoHTLVqLMY88UBbLIErHLGMGzeGQTAtClcI4G7nkLqrkiDy9dXQsnkf7GmQLYZTKX1UroT0T4k4u69ZdOa1XxFIS5esLSUTkSpNds9pUJJrL/XhGRoseS2BHSo8lmBXReaFZDB0v9UEOe31G2IVRc6SJe3AGydSeU32B7ta9B9zf1PEsUPwbQsu+ZIM2zeGAcwfr9oMSVzLySaWxllmZWSSJ6sG53d2DcGKjpwiDwjlIoBM7YEPNxhgtvphVD/lxSwrdySWoUPOeTOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VE1PR08MB5599.eurprd08.prod.outlook.com (2603:10a6:800:1a1::12) by VI1PR08MB3102.eurprd08.prod.outlook.com (2603:10a6:803:3e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Mon, 2 Aug 2021 14:38:14 +0000 Received: from VE1PR08MB5599.eurprd08.prod.outlook.com ([fe80::5ccd:ab57:a64f:e07e]) by VE1PR08MB5599.eurprd08.prod.outlook.com ([fe80::5ccd:ab57:a64f:e07e%7]) with mapi id 15.20.4373.026; Mon, 2 Aug 2021 14:38:14 +0000 To: "naohirot@fujitsu.com" Subject: Re: [PATCH v3 1/5] AArch64: Improve A64FX memset Thread-Topic: [PATCH v3 1/5] AArch64: Improve A64FX memset Thread-Index: AQHXfxJfA7Ac8a4LAESeqDyonguxdKtYES17gAgauZCAACmXYw== Date: Mon, 2 Aug 2021 14:38:14 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=True; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2021-08-02T13:53:22.785Z; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard; Authentication-Results-Original: fujitsu.com; dkim=none (message not signed) header.d=none;fujitsu.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 00022704-1b8f-4cd0-924e-08d955c32e7f x-ms-traffictypediagnostic: VI1PR08MB3102:|HE1PR0802MB2185: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Hjl+zbRtjc4DibYEqBJIrFoRgSL/bzc9JyGOU3ePmS2PKJBs00iCiRw22Z4svn9qqNrp40cvHabmIk+SU7vWB4figvqaMgNjxZE5f+8keU2BMdTYAG/yS3OBWrraBDbpxNMDv/5qQ5qG5DTQ/PJB1JZxHdpgCVbR5Zxsz7BnUZJyNiebBGO/6NknIxA7BCXTJ5kTasoawmdEGoD3aFzVduyKk0ahVH6ZCkbtw+VR9jf/oCgkl4hojU5I+PlI6TDBpfGD/WBQMDl9Gsp0AJ48vOSPvTmkvRZy/nZiFgakrwGzV2gx/xXK9GEyWuvRRe9YN+oY2TsqRnPttiVnw4RJQQre9ZPJZRcgLazjMlPimzP2kgoelktyCu84IDQDNOs/45NU17KQQLQ5/ZijMM/6DleQiSCmumMgrCNKv38L7s2iYq/KLGwQnmp5l58pb4jnDPb7+S05+YAkmT9I+1gvRxVo3hDox3egHnYWueLjzbOF9OsmuHsKE0qKUl7xLJzphTtSSukBVF1pkmgNvK3Gh3UIart5q2c1RgA8pTLb2lNF5liKvPa0T63iN0q3HSrh1Nr1YJkqkoM82YrRa2qBw+3nRoWG8Jitt4PHTv0PboIPhpKwql1FQeMyZq70/7Iz+rSB4Num60WSZR0mXobXDgqjVBdLvlbZVw6D0MNtbTs7cXWizu+t3Xo3WFbEdRHYZFTpHuGJ7fX0J2PgNRsbrQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB5599.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(376002)(366004)(396003)(2906002)(8676002)(186003)(26005)(6506007)(316002)(7696005)(8936002)(38100700002)(83380400001)(4326008)(86362001)(76116006)(91956017)(33656002)(55016002)(122000001)(38070700005)(66446008)(66556008)(66476007)(9686003)(6916009)(52536014)(66946007)(64756008)(5660300002)(71200400001)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?SxLHIlA8tyPY1qi8huJnnIYSUaw/ao3oeaDsjwViiq3FSWCfLeJCOlwIrT?= =?iso-8859-1?Q?v9xNNBEwnOf8pyrXbOHkoXC4Z7WJGtOYoQoIxqEBV3NMKP4Ui0V9dsSBuP?= =?iso-8859-1?Q?zqdtX+d+vTLqv5wPOp7baIbAh693UOuMC8lyLoppDDZJzoaVvobmPL5YSK?= =?iso-8859-1?Q?/+qDoN8BpdwJ+TGdhs59z4Qk2gDOCVlzHj6GHeE9tILAutSg/Hqjl/1OOo?= =?iso-8859-1?Q?khI/od+kM5AVae/uwvP5hYRPRzxFgLp7bBjXCM6sj0SBZFtFZbh43cZQXu?= =?iso-8859-1?Q?0K+luqek1eAYPMhe7b7J+GSugSuJOCcm36wNCHongGaQC0o4u7U4590/su?= =?iso-8859-1?Q?GQR5sIhrESbrO3lPeuA5GWq6mxypY8KsPephArXk2CTGRnH1mNXdheQn3v?= =?iso-8859-1?Q?+lt5ZvPGELJd4Z3PA7SqzLTSmzspcwp1mC82KxSOkfrITQIsYkc4TXRqj8?= =?iso-8859-1?Q?AwpGlZ5cCOJhFp59WnXZCJkX/Lg6KDJLWmu072riH5PLu+4FxhdF6lSOfp?= =?iso-8859-1?Q?7h0A1SuZEtQ7iNK6l6Rq7E7I4grvGfWWPVRFYes7sBJdb/d3PlinUSoBrQ?= =?iso-8859-1?Q?li9VQzdBXJKFytIbghrLduXGpXw/NIa6REOCX95mNoMrQelcMtP8dt2AOz?= =?iso-8859-1?Q?IeBClloSO2r+MiZvp+Z9m6zhnxexM49BFrfWhIssSzLR//YxVgR7KyBE88?= =?iso-8859-1?Q?o2kTugi38u1LKZ1QDf8Ivq/xznybFubcFPyIW3mKF8yV/YJd2Z4rxOaZAz?= =?iso-8859-1?Q?r7O/oO/4UsSoz8S6y0UzWsJ+Xoiwo/Zo5PcqrZkEZeaVJU60wxaEoFWlZZ?= =?iso-8859-1?Q?Lf8EFkLWiOcv6kBh6BHsMDWmbt29B6IwdRjwo1jodT9M5/Mgtwr8WaDn+p?= =?iso-8859-1?Q?Q+uimbXcGowWGyO1VIeBaKeLE7H7xUYdK7kL4XA2W4tgev46LLMZyyXknl?= =?iso-8859-1?Q?j2ueIDtJh01SVEGUyGq9sKbLNd/0DnrFCcNS6+mDKpnNjd3e3GjvoNUSqI?= =?iso-8859-1?Q?mXjmAVSp5lyur4q0tByo5fx3mX5oPwNYJ4ZwxLbqDTYLPmrtmtWq00xO6p?= =?iso-8859-1?Q?RWcs1avepYiSjJHwT/6ZmeiXUnDzbfqxIJUXv7PtSSillfSWwNod6t5IOD?= =?iso-8859-1?Q?0Pq/QWnP6kqto5cVl3N+DbiX5Q51Bim4zIVgtCRdx98mJjU4yFmpl6HIY4?= =?iso-8859-1?Q?tCM9hkmdbNF3x9YhmM8VpJ2cX6h3dK7ltuxhP6EyuplWn1nJbQ4r7lB9N3?= =?iso-8859-1?Q?/1DqptWH+dhQg46ccg/RooltYydTgm2uWBF6mIyKzoPjX2I7w3N9Llq365?= =?iso-8859-1?Q?rljRk8+4522qo8OpOHtlPtySM3Zw2iFApe23RXSgXZ8lPWY=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3102 Original-Authentication-Results: fujitsu.com; dkim=none (message not signed) header.d=none;fujitsu.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 87049545-0fca-4227-1f39-08d955c32903 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H7X7238t6PySWgGvvGoExEkvZvOt0nZADe/KxMSn1ngbWiia0tfk0BYsVruqoburOGxFniCaIB4Lnq5X8lbblKE67tRF0DDdM2U/7hnY+DsxyXI3oFGPQNmPohNbN+ByZaTSImfIiGyJR/NlTy2fMlZ/P82C8P14ObwOMoR2Lmr5u4jjincO3ercLTNsy5kJAG+PmhgQAfBbdi4kuaxJb7ddNlggSQSQGBsBGHbQYQbUE4ANWA+MRSx+CqY61PGEQ/BkWE0KVPxGg8Q/BzGAS9kULzD5Lhcp/tbwLEhvlDWkTNCr6vRlQaZUeiTv7C5VSGrLc9AEZYC9U3iGOBphGbStpIV+6N5iWm+hZvI1fXhGsdaP1tfOzwc5gm3URZXqFVEhxYuO8fQneZ8H9Cx6gkfMe5w5P0b6jUJkw8q9kRFwl0sQPUEFP6dSh01Wz+pCTTjf2pdW2wt12d/F//oklY5B9MMgkM9Jwt8XgHF7GtgJU1b3K1KTqaXxy1NlMvTOdb+zxL2oqizTm4/d27AQaZdDtEd0BkFmXu/Y+yH4wcRu0Gcd6Ywi+k28OuPvMUhsiZyIxOXW6can3fVf260YMzNmfCne+/V00W4Q/xPf8iJzDPS0QKRZ1G0LJal0KqLKGPgIk2H/vdcLy6aSmwPU0ts+D2k5SB4nOPiMfPOjvkrH2j4K4BD9jAdbVQOszppJY5t2XA/MRsw1pYBxkcK3/Q== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(396003)(39860400002)(36840700001)(46966006)(6862004)(33656002)(70586007)(70206006)(8936002)(7696005)(82310400003)(4326008)(9686003)(52536014)(83380400001)(86362001)(55016002)(47076005)(6506007)(2906002)(81166007)(36860700001)(5660300002)(316002)(356005)(8676002)(336012)(82740400003)(26005)(186003)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2021 14:38:23.6112 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 00022704-1b8f-4cd0-924e-08d955c32e7f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2185 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Wilco Dijkstra via Libc-alpha Reply-To: Wilco Dijkstra Cc: 'GNU C Library' Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Hi Naohiro,=0A= =0A= > Would you update the commit title so as not to be the same among 5=0A= > patches?=0A= > Because we need to ask distro to backport these patches.=0A= > If all commit titles are the same, it will increase the room to happen=0A= > confusion and mistake.=0A= > =0A= > How about "AArch64: Improve A64FX memset for less than 512B" ?=0A= =0A= Generally the commit title in a patch series would include the series numbe= r,=0A= however it's also easy to add something to the title as suggested. As for= =0A= backporting, one uses the hash of the patch in the cherry-pick rather than= =0A= the title, so once you have the right hashes, there should be no possibilit= y=0A= of confusion.=0A= =0A= > > -#define ZF_DIST=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (CACHE_LI= NE_SIZE * 21)=A0 // Zerofill distance=0A= > =0A= > This caused compile error.=0A= =0A= Sorry, that should be part of the 2nd patch.=0A= =0A= > > -ENTRY (MEMSET)=0A= > > +#undef BTI_C=0A= > > +#define BTI_C=0A= >=0A= > We discussed how should be defined BTI_C macro before, at that time concl= usion=0A= > was "NOP" rather than empty unless HAVE_AARCH64_BTI.=0A= > Now the above code defines BTI_C as empty unconditionally.=0A= > A64FX doesn't support BTI, so this code is OK.=0A= > But I'm just interested in the reason why it is changed.=0A= =0A= We changed to NOP in the generic code, so that works for all string functio= ns.=0A= In this specific case removing the initial NOP as well allows all performan= ce critical=0A= code for <=3D 512 bytes to be perfectly aligned to 16-byte fetch blocks.=0A= =0A= Cheers,=0A= Wilco=0A= =0A=