From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS,UNPARSEABLE_RELAY shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 36D081F8C6 for ; Tue, 27 Jul 2021 17:27:21 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 08FFF383F41E for ; Tue, 27 Jul 2021 17:27:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 08FFF383F41E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627406840; bh=7MYWKGeNkfhIF5tgKTC6aTD5HmZMAfJF3RX2IFHbIPo=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TRlEervOLt/FR6B6xP352hB9LTHkjCWtgS+Jvz9ElG4PzPKfkJV8xAkxr9l+sx2NN 6BGXskbGDiu7RheO3NDODb8dVd62WBEBd2O6sh2i/TTdhXYRkaxBSs6aQpJNU9iwmc ee+3aheHryT3sDO/oGefSJScWc1pRl+1SfSKEt8U= Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60048.outbound.protection.outlook.com [40.107.6.48]) by sourceware.org (Postfix) with ESMTPS id A1AE43855005 for ; Tue, 27 Jul 2021 17:26:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A1AE43855005 Received: from DU2PR04CA0234.eurprd04.prod.outlook.com (2603:10a6:10:2b1::29) by AM0PR08MB4035.eurprd08.prod.outlook.com (2603:10a6:208:134::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.28; Tue, 27 Jul 2021 17:26:56 +0000 Received: from DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::61) by DU2PR04CA0234.outlook.office365.com (2603:10a6:10:2b1::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.26 via Frontend Transport; Tue, 27 Jul 2021 17:26:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT005.mail.protection.outlook.com (10.152.20.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24 via Frontend Transport; Tue, 27 Jul 2021 17:26:56 +0000 Received: ("Tessian outbound 31e6e3649d31:v100"); Tue, 27 Jul 2021 17:26:56 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: c104973a639de1b1 X-CR-MTA-TID: 64aa7808 Received: from 04b083aee010.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5E88FB18-0AD1-4521-923D-334EC231D218.1; Tue, 27 Jul 2021 17:26:49 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 04b083aee010.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Jul 2021 17:26:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UkCrplID66JYMwbaLJ6++Eeq0/hYZN0HNu6QZgrYHqnhKaILKq9Ti9WdG1teYQzsnYgWHQBY7HEo21SKvOxqOnjMcX5vFJijrHoJldUFjjiysMAEgt6TupAOpIcoNvXfalUY9nyMQWljWi94TJryscNTqAMAD3A1Y+PuUfnR96PoerVIelOqQDwaiX4TM7/btg6IIu5KJwnqnmKivvhOBiIHabvi1UrIqw7Q//HnRsZ34KcseXKlrM4WNxKR23cRiiNK6+SbkMvypnh+ui9TvNq+4t8brwcz3JZlWJ2rhiOZUphzn9+SOJw1rWsRkIMyCkBM6ggC5GyZEFxhPzdWJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7MYWKGeNkfhIF5tgKTC6aTD5HmZMAfJF3RX2IFHbIPo=; b=eDKDTHKX8m5FK4k8bfNFD7CqcPbhSsGQOndGjaWD3aYgvI8Tj6stFE11Mlcr/9v/++2fl7ee43psVlet6C6LvyUOi8o0ILbsHlK+QSVUwtFToKbypErNwWwRconp3fYvkSFgYU90Gfo+xzDMUShad1BU7bbTWugj4Jiat9w0VuFvnRD9KNK+WTaM/y8DCWl1wXw/13AWXGyemn9xXz+7/96iO3XvNY68QmCB5DS1C2qdsecQOSgfCfbeJGLIlumG3xllXD4y2HUQ4dFIIuwixj0EDO66mTM+2vG8cg3Dy8UVBJ4+Acypo8aBVb80HKFDSnnCPrUD1Mzaw3STN0Sxvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from VE1PR08MB5599.eurprd08.prod.outlook.com (2603:10a6:800:1a1::12) by VE1PR08MB5872.eurprd08.prod.outlook.com (2603:10a6:800:1aa::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Tue, 27 Jul 2021 17:26:47 +0000 Received: from VE1PR08MB5599.eurprd08.prod.outlook.com ([fe80::5ccd:ab57:a64f:e07e]) by VE1PR08MB5599.eurprd08.prod.outlook.com ([fe80::5ccd:ab57:a64f:e07e%7]) with mapi id 15.20.4373.018; Tue, 27 Jul 2021 17:26:47 +0000 To: "naohirot@fujitsu.com" , Noah Goldstein Subject: Re: [PATCH v2 2/5] benchtests: Add memset zero fill benchtest Thread-Topic: [PATCH v2 2/5] benchtests: Add memset zero fill benchtest Thread-Index: AQHXfTFtkDPP6CGFiUe3tShnooB/HqtME7OAgAFRegCAAAMFAIAAVewAgAAJeyeABzJlgIAAKFfagAEAeACAAOcwHA== Date: Tue, 27 Jul 2021 17:26:46 +0000 Message-ID: References: <20210713082214.307529-1-naohirot@fujitsu.com> <20210720063500.362313-1-naohirot@fujitsu.com> , , , , , In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=True; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2021-07-27T02:24:57.254Z; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard; Authentication-Results-Original: fujitsu.com; dkim=none (message not signed) header.d=none;fujitsu.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 5640c55d-ee75-4e00-033f-08d95123bb97 x-ms-traffictypediagnostic: VE1PR08MB5872:|AM0PR08MB4035: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:2958;OLM:2958; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: SUePRboedG7jANVd9qiCpyg0HCuCtvlkL6IqSZ9qaLrYfncmBSSpx2nzSIfExKV24ttvynb0pR3/yZByMXvs1Nu4GXFPJ7netpZdH2THFIbAkk9pY9Gl3Tnv7weQ4TC+nDJcqW3YsX9+F4AgAIiHZetNK2sil2NQNp03omyiz9yPX95XAJDX/U1LoXJAKxCtDe63j0lMYESsvZ4mh45XZJG8XF0V15dmxYoLP2jh9pnWwh7ooxbEDQdPSBQ3nEVwXpb+sIlCZ1IblN1xPRv68PwI9kUVQBzjznj1TKTOxQ4COKzxgGMWoTiEJF8vtcYvmR83c4mT7wTloPg2ck6scvmgPWEg8l2kh+1Nl3KRY+gkjtsL4+SRP+o+wMZm+hVoF3fXgZiMEA5UARPlD0eImpNd8oAed0Eh+d3FcpAcQEqn5Bv7IsqAxjT4Pxo3S+PjscgiauhIHvMovYo2LvS6eZ7bnBmT7JfHyaqGHpIjIaxWGOBgQLq+cakvSldTSGYllO2qz7B2IaYAFoku7CM3Nv9O2IJhb+YGB0qnVu2x30RhB5mksQTkFoAqESGuH0ogqHbVkhFm21HvHGM/FxS/fNNs/H7FpNyHIxOS8tAuBcQIiw9Ccu0CEUuZD+q+3DkvglCrTvbSJ2ojrjPD6b9V7zhdHgw/3EFQZfxGD6ZfSHP7ZT5xFdFdtzahh342MXQPrE/IuKcVx8NqAAe/aKEW7w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR08MB5599.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(346002)(136003)(39850400004)(366004)(478600001)(122000001)(38100700002)(2906002)(52536014)(7696005)(91956017)(66476007)(71200400001)(9686003)(8936002)(186003)(26005)(55016002)(5660300002)(54906003)(6506007)(86362001)(8676002)(66946007)(66556008)(33656002)(66446008)(4326008)(64756008)(316002)(76116006)(110136005)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Ur29VJUMhzdLfPErrx58KkT2AY7aAfSCs7c3TystHkGDeS3/tbBbxAC2pj?= =?iso-8859-1?Q?aL/JL3cApu1tDSAZDhCH4UyqDZtCgjxA8BwDlAjdFt235/XFT2NszCNmMo?= =?iso-8859-1?Q?VpZVny+l6UX92QCFVvBn9jIRQCkrWLjZOHhUQrWFO7REfUKbqlWJeeIbrP?= =?iso-8859-1?Q?2LQ9VAyMfngVFE619IGcBY/oIMQvLOXt1z5qbbzcxv0PDzKPdbslIIcapx?= =?iso-8859-1?Q?MO9q2yfOO4ouJ+bAnr09RwOOh0W6+MTtyBp1nDvthDnG0yDOCpcJo/fFAO?= =?iso-8859-1?Q?B1zcGr/yroIaoR9gPoYUF2q1sT5HjS1UNCKFZKuWBxCH3XtJEI+XtYumiE?= =?iso-8859-1?Q?fh67VLcjXCAPWoqzQiQ4ZRSBTPjSGaceVJXmyMu6tcrmayW9LN5gVpvyft?= =?iso-8859-1?Q?bz+ynjTsoTulXWkelAt3UgURm8h5PP/JktqF1FJZbfhzxQcoAcCLjzlI8W?= =?iso-8859-1?Q?rFqcOWuFWBOZ+FM+jNTZYyld7z9tdmV/AiNGeha8Z8XK81e7VhM4M+lgQ+?= =?iso-8859-1?Q?hOSL+1O4GIOfOc8gL3xlkeWBA30ANCmHECa1L/9E4YD4uCG8oMepZYsgFU?= =?iso-8859-1?Q?LkqiWo7GWyoKuJmCVWGxuelrmDSoxMYjcye7dGx2VzyXAzn+m30qajXFOG?= =?iso-8859-1?Q?LHQ0dmCu5dG1A70dP0Ofs2GiatIqr38gHHHEaA9O3V5SbRnzb6O5lXKuOC?= =?iso-8859-1?Q?YBAcoAjYDkLKzrS/gdstilXRbtAJeysTgiGU/UlIcnCSAoKeCYyh/3pMWI?= =?iso-8859-1?Q?v8y9FpNwlloJ8xvX6pFMhDbMwguP7U9FOptnGYPjs+dFPIOTgAsF67pk00?= =?iso-8859-1?Q?qTtm3mznLBzGsq9SgeyN+gaMyRbM7+umNB9dBOW5bDq4JWvWg/h56T3TAp?= =?iso-8859-1?Q?aF0jG1DhVgXhPx9ggbQ2YqmvfOkDaJDNA7erSrYvmOWkCDqv1CZN4Z26gK?= =?iso-8859-1?Q?W16GE6w04JydWjXdLd73IA29qegO58YPwjXlzUFFcGKXxNpTyuucCdV3pX?= =?iso-8859-1?Q?3tU3pemSAL096EtJLkvKxPXr38juOYWUtifesb5hodKdUQ812vQdeuFp4x?= =?iso-8859-1?Q?i4c2B5ydnLy2t2I4DyUP9MVNj4Hm4P6tBMtYPKL83ExTRJP4ExwoJ4fIzj?= =?iso-8859-1?Q?bTRgrZSzhgDOGHl+ceJB3P8Nx1fWVB3s3inLQLbVGt0PlyKsrnqSHonaUh?= =?iso-8859-1?Q?uoSMqKeScO/Y9tkJH20coWSWhqrw0A+xqDiewKHg/JwZ0ymhegUS6Lr06p?= =?iso-8859-1?Q?bBMR1w82Bk58NFJCCbtGMwU78GseCWQtNkLcUGCegyiJEQ22n2PHPoj1AL?= =?iso-8859-1?Q?UiWJBhgCAUrDeWduokyHwFg/znHPVxgTY0fnEUrvdGU122g=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5872 Original-Authentication-Results: fujitsu.com; dkim=none (message not signed) header.d=none;fujitsu.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ae9095df-3233-4b25-18ca-08d95123b613 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AVoLzn+PmO7vuT3vYEChqyzh+pB+OhWGYSRs4vpi+6sil2cKuWxi0ovG0y+gbpaqRLkpHfZGFuk7OE/tLKsvsmLSh8AxazS/iLftrJ/4vJhWraMR8RvYifgQcxXoxmQf9eT27GUjbCG3TgvpUUOw4KEd4IjyVftA25Ie9iRtS+stmHF18Wzfa77aP0clO3AS7s50SkehPNUVonsXU04BXxO93cFr63g25ltJpjL606Hnn8gCJEZtmXqbQYOvMCpE8K0T4rpO6S2m3YSYWuhTkYO1oiDqxUQ+SRN2dm89I9w8xasg7U+Ar8hyh3GqheDvG3sqa81RzYpVJgwLvWa3O6AdU4LuCiOLflBn+HFOUHxrXu+Gbl4F8hnroDtST0iqdHGpdEmFNcRgtm0N5RpTQjeznvrdnzRye1y6rZMA/MoiMQjS5FuEHyebIrsypSN2BLg1p9lZJICJOzpvx7f86LbZkJ/SzpMn6rgLY0IzYhYzPuZzXBfNlZEC543f1aVUXlNHi1FcjZKde5h8C3kCr4MICAAtJLkx7qNdhm1mnNRPRI2+1qbYiCRcB51JwS2jvii9i5JcIGCAaj5tENJVdjIREQKgfT8QUwETQVUop/nh64WhJZq+ICu9l3FAOHtBiRePHBHkvvdwricSH9F62E8y4S78egH8q/rRG9Ggm26UK3OCTQ+zJtl6AET7NtvQcBaSUbpxjOIFVopLR9YM3Q== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(39850400004)(376002)(46966006)(36840700001)(86362001)(5660300002)(186003)(33656002)(70206006)(8936002)(36860700001)(54906003)(356005)(2906002)(82310400003)(4326008)(82740400003)(70586007)(26005)(336012)(81166007)(52536014)(6506007)(110136005)(316002)(47076005)(9686003)(478600001)(55016002)(8676002)(7696005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2021 17:26:56.2507 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5640c55d-ee75-4e00-033f-08d95123bb97 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4035 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Wilco Dijkstra via Libc-alpha Reply-To: Wilco Dijkstra Cc: GNU C Library Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Hi Naohiro,=0A= =0A= > There may be miscomminuation.=0A= > The * 16 is already in the outer loop (1).=0A= =0A= The outer loop is in test_main, and it determines 'n' in do_one_test:=0A= =0A= for (i =3D ...)=0A= {=0A= do_test (&json_ctx, 0, c, i);=0A= }=0A= =0A= > Let me copy the code from the mail [1] I put in the previouse mail [2].= =0A= =0A= The key issue is that this loop:=0A= =0A= =A0=A0=A0=A0=A0 for (j =3D 0; j < 16; j++)=0A= =A0=A0=A0=A0=A0=A0=A0 CALL (impl, s + n * j, c2, n);=0A= =0A= is equivalent to:=0A= =0A= CALL (impl, s, c2, n * 16);=0A= =0A= The loop we really want is something like bench-memset-large:=0A= =0A= CALL (impl, s, c, n);=0A= TIMING_NOW (start);=0A= for (i =3D 0; i < iters; ++i)=0A= {=0A= CALL (impl, s, c, n);=0A= }=0A= TIMING_NOW (stop);=0A= =0A= This repeats CALL on data of size 'n' after an initial warmup of the caches= .=0A= =0A= > It doesn't matter what kind of memset is called, but matters the=0A= > function name in the code so that we can understand it is not mesured.=0A= =0A= Then using the standard name 'memset' would be best.=0A= =0A= >> What I mean is something trivial like: CALL (impl, s, memset_array[i & 1= 5], n);=0A= >> This way you can test any kind of pattern (like all zero, all one, and c= ombinations=0A= >> with varying number of zero->non-zero and non-zero->zero transitions).= =0A= >=0A= > I understood, thanks.=0A= > Why don't we separate it to another patch if it is really matter?=0A= =0A= I don't think it matters, however I thought that is what your loops try to= =0A= measure? If not, then why not use the loop from bench-memset-large?=0A= =0A= > From AArch64 point of view, the purpose of this bench is to measure=0A= > "DC ZVA" performance. So non-zero value can be any value except zero.=0A= > Do we have any specific reason to vary the non-zero value?=0A= =0A= Well if that is the goal then bench-memset-large can measure zero performan= ce=0A= with minor changes. If you don't need to do anything completely different t= hen=0A= the existing code is good enough.=0A= =0A= Cheers,=0A= Wilco=