From: naohirot--- via Libc-alpha <libc-alpha@sourceware.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: 'GNU C Library' <libc-alpha@sourceware.org>
Subject: RE: [PATCH v3 4/5] AArch64: Improve A64FX memset
Date: Tue, 3 Aug 2021 03:05:52 +0000 [thread overview]
Message-ID: <TYAPR01MB6025F5144290910848EA242CDFF09@TYAPR01MB6025.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <VE1PR08MB559925E4AA763668AEE7802583E49@VE1PR08MB5599.eurprd08.prod.outlook.com>
Hi Wilco,
Thank you for the patch.
LGTM, I confirmed that no performance change [1][2].
Reviewed-by: Naohiro Tamura <naohirot@fujitsu.com>
Tested-by: Naohiro Tamura <naohirot@fujitsu.com>
Regarding commit title, how about like this?
"AArch64: Improve A64FX memset by removing unroll32"
[1] https://drive.google.com/file/d/1SIw7bXX9Pi2G7wga9j5X9M2xzOHYQlIx/view?usp=sharing
[2] https://drive.google.com/file/d/1gdcuRFZbtlIpnINUMar4DIt9Ao04K36o/view?usp=sharing
Thanks.
Naohiro
> -----Original Message-----
> From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
> Sent: Friday, July 23, 2021 1:03 AM
> To: Tamura, Naohiro/田村 直広 <naohirot@fujitsu.com>
> Cc: 'GNU C Library' <libc-alpha@sourceware.org>
> Subject: [PATCH v3 4/5] AArch64: Improve A64FX memset
>
> Remove unroll32 code since it doesn't improve performance.
>
> ---
> diff --git a/sysdeps/aarch64/multiarch/memset_a64fx.S b/sysdeps/aarch64/multiarch/memset_a64fx.S
> index fce257fa68120c2b101f29b438c397e10b4c275e..8665c272431b46dadea53c63ab74829c3aa99312 100644
> --- a/sysdeps/aarch64/multiarch/memset_a64fx.S
> +++ b/sysdeps/aarch64/multiarch/memset_a64fx.S
> @@ -102,22 +102,6 @@ L(vl_agnostic): // VL Agnostic
> ccmp vector_length, tmp1, 0, cs
> b.eq L(L1_prefetch)
>
> -L(unroll32):
> - lsl tmp1, vector_length, 3 // vector_length * 8
> - lsl tmp2, vector_length, 5 // vector_length * 32
> - .p2align 3
> -1: cmp rest, tmp2
> - b.cc L(unroll8)
> - st1b_unroll
> - add dst, dst, tmp1
> - st1b_unroll
> - add dst, dst, tmp1
> - st1b_unroll
> - add dst, dst, tmp1
> - st1b_unroll
> - add dst, dst, tmp1
> - sub rest, rest, tmp2
> - b 1b
>
> L(unroll8):
> lsl tmp1, vector_length, 3
> @@ -155,7 +139,7 @@ L(L1_prefetch): // if rest >= L1_SIZE
> sub rest, rest, CACHE_LINE_SIZE * 2
> cmp rest, L1_SIZE
> b.ge 1b
> - cbnz rest, L(unroll32)
> + cbnz rest, L(unroll8)
> ret
>
> // count >= L2_SIZE
prev parent reply other threads:[~2021-08-03 3:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 16:03 [PATCH v3 4/5] AArch64: Improve A64FX memset Wilco Dijkstra via Libc-alpha
2021-08-03 3:05 ` naohirot--- via Libc-alpha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB6025F5144290910848EA242CDFF09@TYAPR01MB6025.jpnprd01.prod.outlook.com \
--to=libc-alpha@sourceware.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=naohirot@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).