From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5B5511F8C6 for ; Mon, 26 Jul 2021 09:43:49 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 59B0A388C01D for ; Mon, 26 Jul 2021 09:43:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 59B0A388C01D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1627292628; bh=NWX5uQDvgkIUpwcsNlv7aQupOHpzUlY2L8UBZixCPXE=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=TM+zwEGMWgtRTXhlTsgS/96wynxKrIGne0pbFns+iXIA56PqHuiifCkyKpfxiAm3O NOm0/WZRsjNBt5CUfgrvl95fa58JLcj0PzfFGJdR3luXdHBNPPkH/JShtbCZpz/CRf 1o/2klMx/VpGvnJJaElF188kEV4OJk9DGJdugHFQ= Received: from esa20.fujitsucc.c3s2.iphmx.com (esa20.fujitsucc.c3s2.iphmx.com [216.71.158.65]) by sourceware.org (Postfix) with ESMTPS id 4AB57389043C for ; Mon, 26 Jul 2021 09:42:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4AB57389043C X-IronPort-AV: E=McAfee;i="6200,9189,10056"; a="35491223" X-IronPort-AV: E=Sophos;i="5.84,270,1620658800"; d="scan'208";a="35491223" Received: from mail-ty1jpn01lp2053.outbound.protection.outlook.com (HELO JPN01-TY1-obe.outbound.protection.outlook.com) ([104.47.93.53]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2021 18:42:57 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k6zn5gX+tyxWXa/gRJme7QR0ysrUkBf6FWnU3Em8q6WhbJpTmOShOqvRDM/h2WQwgvD4vSSMMVjJsAO0zaTKCCvPlna1hVBf2P0FT+nzlLM2RvCdh4gVXmOmEcjzw8oV1ocn1EBQufKicbGLCOnsw5gXQdb+Db6VhMQ8betF1WVfgqQ/izF3InQzSwpFqjFRgp5EX90LdxvG2eSpXQWtCVj82nJdMDcnXZOOkm90pBU4gBIr4IHIb/nec9BDXO653VJWGB01XP6zfmLzPLh8J0tT/5F3Sl3MTCVxQzutyapge7Cy53EkRy2phsCq0wpcDjdJpgGFBdQpkUtxiQQNNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NWX5uQDvgkIUpwcsNlv7aQupOHpzUlY2L8UBZixCPXE=; b=b6vOyXG5l65mKKUCfEq/rEM7KxsmV6j5MKAAANyV+tDxaLR1OgveUPYl5AamSVY6QGjrAMk5kRvcaHaBXbGKPYw6yyFbVB3bSLDUw1tVRw+aNkcVmD79B3Y+W72bq7qs4rh0YU38HSw/v8jr6qw+YhchzJVPRj7dWHGV/Cg29MwVqfbsK4vjLJ1ZFzBYZNNWKyZj/tUctDf1/7qtFqD1sDaAMUtRIdK3HjQqupJavIM3uug5kVBw4/ocDxFfTmSx6JXMEujMEKCcXf3fYcLaSRnzChQpuSDRg+nPwK42cnmkUciV+MbURXScMC0RhV9yDfvUoQ8ad+7+uDL9ANXIMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none Received: from TYAPR01MB6025.jpnprd01.prod.outlook.com (2603:1096:402:36::13) by TYAPR01MB5594.jpnprd01.prod.outlook.com (2603:1096:404:8058::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.28; Mon, 26 Jul 2021 09:42:54 +0000 Received: from TYAPR01MB6025.jpnprd01.prod.outlook.com ([fe80::5816:45c1:5336:c108]) by TYAPR01MB6025.jpnprd01.prod.outlook.com ([fe80::5816:45c1:5336:c108%7]) with mapi id 15.20.4352.031; Mon, 26 Jul 2021 09:42:53 +0000 To: 'Andreas Schwab' , Naohiro Tamura via Libc-alpha Subject: RE: [PATCH] config: Remove HAVE_BUILTIN_MEMSET macro Thread-Topic: [PATCH] config: Remove HAVE_BUILTIN_MEMSET macro Thread-Index: AQHXgfkWH6gOAo1lv0e5UUzNPc003atU8kTLgAALLlA= Date: Mon, 26 Jul 2021 09:42:53 +0000 Message-ID: References: <20210713082214.307529-1-naohirot@fujitsu.com> <20210726083433.385572-1-naohirot@fujitsu.com> <87zgu9cvep.fsf@igel.home> In-Reply-To: <87zgu9cvep.fsf@igel.home> Accept-Language: en-001, ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-securitypolicycheck: OK by SHieldMailChecker v2.6.3 x-shieldmailcheckermailid: a879f8cbcebc403480d4d4308495c0c8 msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=true; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2021-07-26T09:29:14Z; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED?; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ActionId=881e0a46-ea5a-4d72-8f22-086ce5fd95ab; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: da5dfac9-112f-4e8d-8875-08d95019bdcf x-ms-traffictypediagnostic: TYAPR01MB5594: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZLx6iyvJg8/ZAdEQzzcVTMdSxhLczPsWkd1Z2fN0XDDG2weXY//AZDI92rrSd+t9qPwRaM8Kf9Nc/lydLUjF4WMPrdXni/2jVeyRI9T50fgTPk5bjqwHVPiRhSIBIIPCbycXYcdALZiXAdVCAP8HdSezPXqQSgfObQTlXDYLxv7dUFB2RT+u+YLR8Q5V0hoyzWybBuAWSH4d3cHEfK/tiQ62d5mHT4tEZuOEOpU0/GIUUdEREWHxO0+bxK+vEqon2WIzpMYHnHGhEpqk82vJnaBAYADRkbwfEvKeClNR1F3zli0pNu1fzp14Pl7U8oSd7t1VhrAfERw7NDrG3gJytKuXCH76MBvvAwKtwpn6TQFGgwMRURgVhWH3rrpR5AilTvT2NDVqNNplBDMjyrk9Yq/Nyo6dax7tiimQ3mEmuDg43PpRK3ccelqfgNIaeNCIQWN0t/yz3y+dFEeOebxaeiOe297+lkJCxJJUNCcH2ftYoxT9mvP65cBJXrxE8cRMVxzTtLpAUQ+hEcB/CaG1DIJGj6bNJziMwPBPlj1e1ci3OhWRPk2drIcmU28DQKhBejpdibt3lfskKarJDS/hM0kWkaYGRVDwmpzyDxVNNfbdSlYhDIHuATrrCbwdX6BACNSFAtRv/fdnXk/0EsYm9NxZj44gAgOMGX5tMWM3arZFJ2e0TsvZ+EmxTxld8k3tZ7whLgqajPi4V/R0XoIv2Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYAPR01MB6025.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(396003)(366004)(346002)(136003)(6506007)(38100700002)(26005)(110136005)(52536014)(316002)(71200400001)(55016002)(8676002)(9686003)(7696005)(478600001)(5660300002)(186003)(85182001)(66446008)(122000001)(86362001)(76116006)(66476007)(66946007)(66556008)(8936002)(33656002)(2906002)(64756008)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?bStnZGt3UkZUNFdoR2VCbXJOd0x3bkIyeHRjYS9zUFJHYUVyVERxdmw5?= =?iso-2022-jp?B?alEybWtZZ0hwa2pDbDRqQnhkMERLNFcxT1pLdnM2NGhoUlNPRTFsZUhC?= =?iso-2022-jp?B?RjA3VUovN0FTTGx5b2Zza3NqakJaQms2MnBYZnpMV2MrYmdXWkFLaVl3?= =?iso-2022-jp?B?b2hzT2g4TmJwUEVUNy84ZVZFQzVQNmlXUmFDTHhTN0tCeUNOaXdUbmNV?= =?iso-2022-jp?B?RHJLQXlIbUFabGZnNFl5aVNtQmZhQ3Q1eHh0YmtLanhUODBWSWlubVc4?= =?iso-2022-jp?B?K0pldTJoRGdTWDdJcVV2ZGRTRGxFVWJoWnV0Rlp5WHJuRXZqN1VoMSt6?= =?iso-2022-jp?B?M0FxM3A3OW5XWE9JNURMMjkrWXVDeEM1M1E2Um9aTnJadmI2WmxvY1N2?= =?iso-2022-jp?B?a3EvMThsTDZ0UTNmMkJtTkt4UFJGcElxSHVHMi9vTzIwbU5IZTJZRlMx?= =?iso-2022-jp?B?L1IzTUhZTXFwSSt5a3g1aHNJdFJtVWNHZVRGbEIwZEorSTJIMWJuVnZa?= =?iso-2022-jp?B?d3hBRE1LTkZUNGZIYzVTTWx4aUxNK2VOTWJTT3IwMDd5eVFjK2FkdS9j?= =?iso-2022-jp?B?UDhKdDZrMDdZS1dUQkxHdnFQLytCZkRjMlV2cEJZVE14WXVXRDdlUjZN?= =?iso-2022-jp?B?Z2M1R0kwbnhEZUxWWERKYjdzYWtxcXBnQWJQb0ZrZ3g1UDZsSzZYb1N2?= =?iso-2022-jp?B?Uy92VDM2TnBQKzVpZklqVzJ6UU40dlN1U0dNWVR3YU8ydkpybU1JNlRm?= =?iso-2022-jp?B?Yk5RcHJ3enBiNmwvdEJ6YU9WSmdmWVdrdjV4SVV6ajNoRnpYMklUSCtG?= =?iso-2022-jp?B?SHdCWjhhNDFlOXMyN2ZxcGZiQ3p0ZVNYY3lWbnNMdjJCc3pSbFZJN2Vm?= =?iso-2022-jp?B?cDJNTzNkZFY2S1BGZW5mcm8wOXVyd1A1RmtvZkFzMHVPNnQ3bElsa3RB?= =?iso-2022-jp?B?Z2N6eTQ1STdac2ZLeEkrbDl0Y21sb0ZJTy9DMklIUEd5RGtnSUxMZDVz?= =?iso-2022-jp?B?ZFNockZXOUM0dUs5RmJCRWIzVXFYYWw3eEdTVVllTHVpY3RNZ1NranVE?= =?iso-2022-jp?B?am1Jeko5RHUzeXF5WmRORHdNRW5sQnpLQ3FJdEZtc290L2RMdWhOMmxa?= =?iso-2022-jp?B?Y3VzOXRCeFV3by9xdStEUFF3aHJKY2dMOGcrWThZY0Npb0M0b3N4TGEw?= =?iso-2022-jp?B?dHE3R0xZS25ST3RxcXBHU0s0b2dGbnd0VlhZVEhJTkc4NmEva2NWbTJi?= =?iso-2022-jp?B?bSs0SEI3MFV6Rnp3YjJRb295N1lSajZaazNqZS9pKzdrQVQ0eEpSbHpi?= =?iso-2022-jp?B?ZTFTbURZU3lpcDNZcm9VOW0rOWtXa2V4czFxUklMcE4rU3F2Mm11WUJt?= =?iso-2022-jp?B?Y1A2QnJiR0F1dHoxTVRUcFVaMDBYZmdrOFVPOG1LSFVEcXBVVXNnS0t6?= =?iso-2022-jp?B?Zy95dCtGdmliNGtibE5LQ3VPNUtWVUwyUGgzaitzd3VaSUxqaGw0aHE1?= =?iso-2022-jp?B?MFp4S0NXSXlzV2h4elpnSzZaeEFVbXNRV25TdGpKSWxMSWRoaHRFdHBM?= =?iso-2022-jp?B?WXErOE11NXJBcDZaZ1dTZzMyeWozNWRxZG5UWlJEeUNGMzI1bFdoU2cy?= =?iso-2022-jp?B?bzZkanFMZmRCL21TSXlYeU1QRHgrbGZ4VWV4L0hFVURsbzdjTnp1YkYv?= =?iso-2022-jp?B?WC9RR2VkcHdIOEFBTC9uMWQ0UDhVWDRQK0t3eEpDanBCWHVqU0JLdlps?= =?iso-2022-jp?B?QVBMS3l5ZS84UDZsMitkYXByaG1uZ281eXBvRFFIMEpPcDloai9vKzJx?= =?iso-2022-jp?B?c0wwa3NxZ2JNVXNpOWZDaFhQR1U2dkdyRjlUdzlRYldwRFQ0ZmozUGg2?= =?iso-2022-jp?B?bEFaV1F2QnFaTllnSzVTaTJ3SHJNPQ==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB6025.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: da5dfac9-112f-4e8d-8875-08d95019bdcf X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2021 09:42:53.7658 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CzsBHEO8M40Yq4CjZBa+KNVaDZox0yxrXTd+7vQzeeqZ9v/q95JpN0c6Mq6cUEzhzAw2zM+ydAHpNHeuZFTSuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB5594 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: naohirot--- via Libc-alpha Reply-To: "naohirot@fujitsu.com" Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Hi Andreas, Thank you for the comment. > From: Andreas Schwab > On Jul 26 2021, Naohiro Tamura via Libc-alpha wrote: >=20 > > Interestingly, removed code had a critical bug that is > > HAVE_BUILTIN_MEMSET macro never be defined, because yes/no assignment > > to libc_cv_gcc_builtin_memset was reversed in configure.ac as below: >=20 > No, the point of the check is that __buildin_memset does *not* expand to > a memset libcall, as explained in the comment you removed. >=20 Is the comment you mentioned below? /* Partly clean the `bootstrap_map' structure up. Don't use `memset' since it might not be built in or inlined and we cannot - make function calls at this point. Use '__builtin_memset' if we - know it is available. We do not have to clear the memory if we - do not have to use the temporary bootstrap_map. Global variables - are initialized to zero by default. */ + make function calls at this point. Use '__builtin_memset' instead. + We do not have to clear the memory if we do not have to use the + temporary bootstrap_map. Global variables are initialized to zero + by default. */ Do you mean that yes/no assignment to libc_cv_gcc_builtin_memset was NOT re= versed? If it was not reversed, config.h never had " #define HAVE_BUILTIN_MEMSET 1"= =20 even if gcc 8.3 is used. Thanks. Naohiro