From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7C59C1F8C6 for ; Tue, 14 Sep 2021 00:44:44 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 766A13858013 for ; Tue, 14 Sep 2021 00:44:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 766A13858013 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631580282; bh=RY2cJPT2DuKBAZyNw5kHWHKyp85TgM9AMgzuoSwPygA=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=OPUpuiuIt07HP7WRSs8TvkNi68ZN1OMzIU1rYQ+g6bB00X6HeaiRBFeJNymLIbjyF LuJ0EUmvvc4kJInVxrXb9UEJAVO4fBtsalN+IorU/7QIK4QgrXDhHMLfd38yyIryMt twGac/hhau7ebsCQBhaTDF3h/x/i5p45cBkv0imE= Received: from esa4.fujitsucc.c3s2.iphmx.com (esa4.fujitsucc.c3s2.iphmx.com [68.232.151.214]) by sourceware.org (Postfix) with ESMTPS id 0FB3E3858408 for ; Tue, 14 Sep 2021 00:44:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0FB3E3858408 X-IronPort-AV: E=McAfee;i="6200,9189,10106"; a="47031158" X-IronPort-AV: E=Sophos;i="5.85,291,1624287600"; d="scan'208";a="47031158" Received: from mail-os2jpn01lp2059.outbound.protection.outlook.com (HELO JPN01-OS2-obe.outbound.protection.outlook.com) ([104.47.92.59]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2021 09:44:20 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XGPTBHuY8cgmXKjqg/OioN03ihdj855NKofoqwVCAz1JYPP36JlS3k48oU0gSYqezpw5rOz9PZ//WMakoYOB0qfYwAM+wm/tRKvEhFKhBX5id9lD75lUiHb1y8JIXWLbSO0cZZoNnjttjMQZXknwb2imnzG+RjT3RT+o0Zx9e7AOpYKpzJCVsZBHr77tJoZaC7t1Eoi/r8mf/M5pLbilCBADohVM7hyDG0Z3Cphr2xsuufKCja9TmOmFrkGSHceE1o4e114d6+n+35vEr7kuXRdGBIwvzDP87TfhYCfAfwqnOdO2scplJKFthSfslZKRCMDfnn93pNdTBh78zuUkTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=RY2cJPT2DuKBAZyNw5kHWHKyp85TgM9AMgzuoSwPygA=; b=O+TpY+Cj0UPDemZEEHdeNPnaJfJICKPem3dQaE3uZd2ZgQpV08sDv3+RgVCHos9AhEVkTfPlS6/6kbNs2zRRLuqT3TxS0ooPDVlfGeynF0jnx/e+7Fji9I6asMaklq+oDeUQqOGYIrvdn56ztDIaFcXm0MOis7JHR0I5YLrEtgIE3+WEsB9Z8dlmQj77iFH1xY72mO/e+fq/AaalzAaFRH0r7cPrS5FMo9uH2iA6mQtDscaXz/W5hBvNh41CX5A+MvW8TQPb4ueuKqX8B/4HU4xRGSKy5fe5Z92z1KmX0E5yj6v4fWHtiuHR5b3hkNA7wxyTtkdgDaqJU3gdwnbRUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none Received: from TYAPR01MB6025.jpnprd01.prod.outlook.com (2603:1096:402:36::13) by TYAPR01MB4397.jpnprd01.prod.outlook.com (2603:1096:404:12d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Tue, 14 Sep 2021 00:44:17 +0000 Received: from TYAPR01MB6025.jpnprd01.prod.outlook.com ([fe80::cde6:2645:63a1:51b]) by TYAPR01MB6025.jpnprd01.prod.outlook.com ([fe80::cde6:2645:63a1:51b%9]) with mapi id 15.20.4500.019; Tue, 14 Sep 2021 00:44:17 +0000 To: "'Lucas A. M. Magalhaes'" , Noah Goldstein , Wilco Dijkstra , "libc-alpha@sourceware.org" Subject: RE: [PATCH v3 2/5] benchtests: Add memset zero fill benchtest Thread-Topic: [PATCH v3 2/5] benchtests: Add memset zero fill benchtest Thread-Index: AQHXic6jy6USnJyx5kO37MI1gLA1squd9IkAgANfZaCAAOkzAIAArxWg Date: Tue, 14 Sep 2021 00:44:17 +0000 Message-ID: References: <20210805074733.433430-1-naohirot@fujitsu.com> <20210805075053.433538-1-naohirot@fujitsu.com> <163130642274.404689.6991051609396665932@localhost.localdomain> <163154191414.705584.12050866556951422556@localhost.localdomain> In-Reply-To: <163154191414.705584.12050866556951422556@localhost.localdomain> Accept-Language: en-001, ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-securitypolicycheck: OK by SHieldMailChecker v2.6.3 x-shieldmailcheckermailid: 71043e79b4b04217b95febf9bf3018ce msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=true; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2021-09-14T00:31:53Z; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED?; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ActionId=7aa6e784-89af-409a-b415-35431e35d0f9; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4481b58e-ae6c-4034-0cf7-08d97718c849 x-ms-traffictypediagnostic: TYAPR01MB4397: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dvk+9jZcGREdp9w5hW0dmSyuS49beniv5Od5nnSPdlB0ciDr7rtWb+IRAwxJ3e3PeGA81kfMmy92jnylZahBclX2jtC0GDh5CVOEb98aW4PNDx6zeqPca9lgVGHJtiKdOb3rQ6K9eQTKEBkhlpfa+IfNL81iYx8xQbF7V5R67zohxLH7YEdLnR7gscLBtPCImERZ/m1L+rPFxbLCBx45lqgZFm9Zu2DoNzBCyeEAp1A2vds6BcrepKxywyYrioZffNHMJchWqBPlXbe4FXBL/sfM94iWsr+DQL/MmQm+mHe+HoFyuhpcIqIvNWuUpn0FMDN/slIlBb5WkY6NCxLWeQBKl82iI5CpSJycDY/BNzyExe/fVso4L0VoPyh1HDt71A4oEbUv4ByeGK8+3Xt5AkR/gexj456QVycVoH6p0w+tke0zE5K4nJByMKJeVYiupg/YdvC+OfREhKsiMCEb96An+fpj6OKLzp6KvvvaRnOEC/UfX2GEoMo/DmYXF2s5iGO8+22b9ttH5XzmOOs9zZ2hoYvbDzxNBu7VXHe1bHb6aLxrLMcVr4TaJqbSC6KKXsrlnfk2Fvds1LuehyY7GvtgqodaO+Gow3/CGvHz8xw3ULms0MkPJDukxeIp182z6xIw6DbYS04gvNkSVrUySyfQCDPnqZUtQzQLHqiA0zKzUnDvkhJgd52sbLbHGxHtd3wZIFa3Yr+nMumfWAm9AVw+e7e7/xqwGWU04SrPuvRhWNV+7aCJdMLoUK93wVX0AvcJ/8FHqZWOQhrTakVyTvQ0wqqpq1AIiaixKu+4ems= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYAPR01MB6025.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(366004)(396003)(39860400002)(346002)(38070700005)(9686003)(5660300002)(38100700002)(66946007)(6506007)(76116006)(33656002)(55016002)(8936002)(66476007)(66556008)(64756008)(66446008)(110136005)(2906002)(966005)(71200400001)(316002)(7696005)(478600001)(4744005)(85182001)(86362001)(8676002)(122000001)(52536014)(186003)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?blAvbWlkMmFzRTVEUjNJa1hKT3VmZGZwdFgyWkhsbEd6TmtDS29jem1M?= =?iso-2022-jp?B?cmpWSGFoNHVzVDE4MS9RNXYwd1M5NENlQWtwVUNuQzd1bDlCVUZxbmJD?= =?iso-2022-jp?B?cDdRNnFOZThsYUY5amh3ZS9LZEtqWUVhNkptdEtSSDhaUEVlWEFlTXdH?= =?iso-2022-jp?B?VkNDdDNPODJwSXVJNlN3N1VVdWxuS2FBNWJLS1hNR1Qyb2VaUlFMeUt4?= =?iso-2022-jp?B?LzYzMmtIU2VVTlArWVBSOW1OSmU2d25ZMEdieTlyd1gwRHdNNVhmZTNN?= =?iso-2022-jp?B?Zmd0aHQzcVBuM2ZsMEVMUTV0OWZhNVg0MXpwR0JpbGRZbUcrYmFvOEtK?= =?iso-2022-jp?B?Mzh6VC8ySjVtRWUwellKWHhIYmdxbDZiVkNlZnlsNDdYSGpjZ0dZNlhy?= =?iso-2022-jp?B?MFdSdEgyQkQxRkVNcWE5MHJ1ditTKzFRVnVaRlZzc0dNWTV5Kzk3OHNh?= =?iso-2022-jp?B?eHI2VEJYdzhCVU9uMWdHZ0JFTGVCWUluR0x6UUtxZGFXdyt6WldxVUhj?= =?iso-2022-jp?B?UjlDcGVlSXdEQVJHWDFxTHkyb0t2SUxackRCbmllSml6T1RjcjRHVGE5?= =?iso-2022-jp?B?Y3J6eis0ZjJiOEt0U1R4M2h4VGxndkYrNjRtL3FEKzVKejhXM3ZibVBx?= =?iso-2022-jp?B?NWhUL0EvM3VUSHROWEJsMGw1Qk1CZUxud2ROclBtZFp3ZXBsU0pzdDIv?= =?iso-2022-jp?B?RkxCV09hS2ljVnFhem5mQXpOT2syYWl5WklNekxOZFdva2FyS1NnbEsy?= =?iso-2022-jp?B?SzJqNlN3V1N1K3diK2VZbFJWcEcvY3M5dHArQnhaQTJUazFrYzExeDNu?= =?iso-2022-jp?B?Q21NcG85QXNNaDhRWDBMM252UUIxU2RQK0ZkVjgraEo0cS95cGhPUU1V?= =?iso-2022-jp?B?eWFSRHpncVlHQlp1SWd2cHUyc1o2ZCtxd0VrYVZuL096aS9OM0h5SVFU?= =?iso-2022-jp?B?N0s4MnBzazZOUk9NWVFvd3dPSFQzNy82RmZnK2FIQVFLTGJrSDJLeXlr?= =?iso-2022-jp?B?MW8vSHltRExEQXpvWlhPRTBwdlBRUzlUVkMrVlhxeHJzVDVvNzdncXFz?= =?iso-2022-jp?B?a2s3WHZqbXJCajR1cmY3aTlpc09rMmJvbkxuM3ZwVERnU2xuaFlVUXoy?= =?iso-2022-jp?B?cVM2bGp6OWN1aTJ6SmFMbllxVEt1SnZaVmtwQjBHR1RkejN6QitUakFp?= =?iso-2022-jp?B?OWlSNDNPaW1tYlBMR2k2Y01yMjBET01CYVR1dXBOMUdXL0hNZ2t6YWJS?= =?iso-2022-jp?B?bThudTdBK0tpSmpTMC9KQ0s1MkxBbzZwSmZ3NDVpRTJETSsvTzkvUlNy?= =?iso-2022-jp?B?WmtyYjZocDFlVlNSK05rbXZ5Q1FvcWlCa1plbzhjNnU4Qk9uVjVjOFpm?= =?iso-2022-jp?B?VmtlWlFoZkNPVHArSEo1ampEL0JGRE1aR3VyOHJlck5HRHNvS200bkN5?= =?iso-2022-jp?B?WUduS1U5bElpRzhPeTdpejBtMUhzYTk5MkFuNGhDWCtJNXpWUlI4a1Za?= =?iso-2022-jp?B?czMrQythbndIalJUNlZFMUNWMkJsL05wNVcrQTVTOWhiME5QdTNZbElv?= =?iso-2022-jp?B?eFlLb1hEY24yYSt3L3BkQ083SlRNNFZkeSt5VWlXRjIzaDdQT25Vd05W?= =?iso-2022-jp?B?d01HVjV4Z2FsWE5pZnViQ0ZJOWpGZTcrejlQQkU2cXl6TFliNnZvVHNV?= =?iso-2022-jp?B?U1dRMENZRk81dHo0RVJ4Y1FmeEF6QmxiVkY4a0R2Smp6cGxtK1VScDBY?= =?iso-2022-jp?B?NzJPL25VU1lpblN5SG5INzR4cnFmQzFmc1l0M204Nk52TkR3QzlvTEFz?= =?iso-2022-jp?B?bDYzaStpYWd5SUZKdmkxU3c2RHR6MEVEQTJmdTA4cWs4cTVxQisvMUJ5?= =?iso-2022-jp?B?dG9zWVN5ZStSS1V2RUFYVDVGN0pyRE9OT1ZjTzVxdEtwbGhtNHl0VlRP?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB6025.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4481b58e-ae6c-4034-0cf7-08d97718c849 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2021 00:44:17.2314 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vVH6p1a6dORv8LY2JPy3BIn6zDiKVKu9Nqsn5am+6mgwUzyFwvSQoscNDmwRXnpEMSBXeKobAfIZGCQNvQv5IA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB4397 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: naohirot--- via Libc-alpha Reply-To: "naohirot@fujitsu.com" Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Hi Lucas, > From: Lucas A. M. Magalhaes > Sent: Monday, September 13, 2021 11:05 PM > > Thanks for clarifying, now I got it. Please can you add a comment on the > code explaining this patterns and the reason behind them? >=20 > With that said this patch LGTM. Thank you for the review! I just submitted V4 patch by adding the comment. Please find it [1] and merge if it's OK. Changes from V3: > Reviewed-by: Lucas A. M. Magalhaes > Reviewed-by: Noah Goldstein > Reviewed-by: Wilco Dijkstra > + // To analyze zero fill performance by comparing among the following 4 > + // patterns from 256B to 64MB(RAM) through L1, L2 and L3 caches. > + // - zero-over-zero: c1=3D0, c2=3D0 > + // - zero-over-one: c1=3D0, c2=3D1 > + // - one-over-zero: c1=3D1, c2=3D0 > + // - one-over-one: c1=3D1, c2=3D1 [1] https://sourceware.org/pipermail/libc-alpha/2021-September/130946.html Thanks. Naohiro