From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E3B1D1F8C6 for ; Wed, 8 Sep 2021 01:47:11 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 072E53851C35 for ; Wed, 8 Sep 2021 01:47:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 072E53851C35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631065630; bh=p9WSpb0rt3ToznkU41AaKn6lWBp+eAw1/scbBNJ8Qmc=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=KqZcmXY5uGKfl4eFh7NLC5aboVXkCGZoEWQpJ1gbjLOv9AGhLnn/HL+C4UhqPufnp VDgTJJZI5KtjHMhA3jEoAeOU5DO0rdISeojs635SUeFqs8qJ9IWfwkb6Mh/pL7SZSZ tEjnFyloOTNKGEJYHF+lIFq92iL9QnvWWYPdKgb4= Received: from esa16.fujitsucc.c3s2.iphmx.com (esa16.fujitsucc.c3s2.iphmx.com [216.71.158.33]) by sourceware.org (Postfix) with ESMTPS id 045353858C60 for ; Wed, 8 Sep 2021 01:46:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 045353858C60 X-IronPort-AV: E=McAfee;i="6200,9189,10100"; a="38699790" X-IronPort-AV: E=Sophos;i="5.85,276,1624287600"; d="scan'208";a="38699790" Received: from mail-os2jpn01lp2059.outbound.protection.outlook.com (HELO JPN01-OS2-obe.outbound.protection.outlook.com) ([104.47.92.59]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 10:46:48 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WWLm7gW2FYGqMQZPHjUHAKjDLnANCoaZhMa6GlIsQmWcWPhBaTnkCgtYdnEnnoo5HDM1Y4ez9UsZoqfmt1CCeTZ2IuMpg/5oYe4Cc+jtBOqsQXcoH1JedtttXrxCT5d9F0GG6ob60guuWIlsrmiWtveXqDAzFiwmYqxC83P4c43CSniOgdQUyxTjOd5kFvPQlzCpGRI2SX6qLYhj02zZ+5pU4U3Dw6EnhSFdZsEIfOyr8UYParK8rIUNT6fUnFfyK5CLeZuzHLqSDI7yX+pdtM75DLcmwpfQN/r9ZlUFzGZpHA11V2fEcojKAV/VOyw/ZtiqyK5b559BPBoLlq+nYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=p9WSpb0rt3ToznkU41AaKn6lWBp+eAw1/scbBNJ8Qmc=; b=XmKUYzEgLtNwS3i6PMMl7QE46iEv1+rOxYUFbhdm1D/Pg4FeNbCkjU8Xwrg+sef5l8jrQsJL2Y7JuQFLdZJsdStaQw+yl37aJEh0YM5tEBxajUSh1U2OUXRO+8ByKlnWLQJ+zQa+D0s4/DMPnTXAcgoI1mYJL25EOGkotu8zGeyzC/xBvcSKRIHQ1KyV82WvTil0al006wKXoNfiMvS8OgXMnuRB7IHDw5m/nd7y5+EKLWqFN1FBaOeIrh93WBkjFqCzkrbJu2bTpowsy1QZGoElK4633/XVfob8eEWT7h5CpeouRyvlpwsa6NVQJ76kg1YoE55e4OMQmLTb4K0Z+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none Received: from TYAPR01MB6025.jpnprd01.prod.outlook.com (2603:1096:402:36::13) by TYCPR01MB5614.jpnprd01.prod.outlook.com (2603:1096:400:b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 01:46:45 +0000 Received: from TYAPR01MB6025.jpnprd01.prod.outlook.com ([fe80::cde6:2645:63a1:51b]) by TYAPR01MB6025.jpnprd01.prod.outlook.com ([fe80::cde6:2645:63a1:51b%9]) with mapi id 15.20.4478.025; Wed, 8 Sep 2021 01:46:45 +0000 To: 'Siddhesh Poyarekar' , "libc-alpha@sourceware.org" Subject: RE: [PATCH v3 1/5] benchtests: Enable scripts/plot_strings.py to read stdin Thread-Topic: [PATCH v3 1/5] benchtests: Enable scripts/plot_strings.py to read stdin Thread-Index: AQHXic6DebJROPwIDU2FCYXWSgDO9Ktki0uAgDUGjUA= Date: Wed, 8 Sep 2021 01:46:45 +0000 Message-ID: References: <20210805074733.433430-1-naohirot@fujitsu.com> <20210805074953.433483-1-naohirot@fujitsu.com> <0d7d4e65-0286-420f-654d-7151a349ba8f@gotplt.org> In-Reply-To: <0d7d4e65-0286-420f-654d-7151a349ba8f@gotplt.org> Accept-Language: en-001, ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-securitypolicycheck: OK by SHieldMailChecker v2.6.3 x-shieldmailcheckermailid: 337f249cc1f64f719babca2943ae5554 msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=true; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2021-09-08T01:42:06Z; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED?; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ActionId=fbf72e70-1f27-44ab-9407-fd724174289a; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd8f7cb7-76f5-4ec2-4200-08d9726a83db x-ms-traffictypediagnostic: TYCPR01MB5614: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0WNeWw0VQ9itX/WfW3uhJ0Qxo4xMPOvXbGbG5SpZhdIgvDhv8NF91sVBeXpdKjvkuKdTAzI6BpSlRPLinzNyFkLhP6zSk6qjVHcfRrhRAdvSLINf/OfOxkGQcCHfsxbJPN6anisukKIY0cFAFsj3egoFcGW55RfsCo47andvGDgAKwM6SX54TZwI902f3ZnNXYt40otzLEy8MSbTRAjb5YWaFytwKMhl4ELKdAdPHrHBkOcKL3TxgxIwrWtCpybRRM/Sq4BAXp/UzWKK0sJfJiYNj071rK/sgIPMzr8tTxUExmrmYpnVmYs4XrQcczKJY1Kb7cDFXgMM+Yfa7hUKsOHzF3e0SjW8nS8/TS4Q2hbCWSQsoTI2WXWodP33xV5wEdKnb7EYBsI7p6fgKezlIIjyMnH0n8c9BVBTuI4dntjwMt3tsQMcYh8HJJ8OjE7dQmjBiSpFZFNSaFXKpX5jUTKYoN8pTfKm6/gkDGHJ2ZRgmmzX8DXEjZXyUNdK8hYhoQPdWLSF8nCqeGaqWwHUfsV5aklAtkTqM9lODGhkOQEb7CkCtVdgHTjGN6qA2fiLNCmOwhdoJ1uXXkyDqs7kHTKwINqzfRBZml1zhv18rT8MKYsKoH0dnopAZIlISno0mK0NmBSQw+SbGBVkxe5HIp489JPkPvv2LIQ0/I88fAEKQeNGnVXquaJwQBa7ysGf3MoQqyQkyoTIvEr+1ltjz0swkNeac2RhiOhMSYx8VSz1MKJbkhpn8e5W5NN8A2ZsJU6QsLEfAK9xf1KHjBl8R+yZy9TCVgBG/efpIa5Xxok= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYAPR01MB6025.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(110136005)(7696005)(71200400001)(52536014)(508600001)(38100700002)(2906002)(316002)(53546011)(6506007)(85182001)(55016002)(966005)(86362001)(8676002)(26005)(33656002)(76116006)(186003)(66556008)(64756008)(83380400001)(66476007)(66446008)(5660300002)(66946007)(8936002)(38070700005)(9686003)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?RjhUK2oyQ1BSL3VKZ082QzAyeUlSL3pwZmZUT1RIM2Y1WWI3cjlIVmVz?= =?iso-2022-jp?B?dDBKUlVlUnMxYnQzZ20vSGZkcnUxbmVZR3lKb25HRnhybk11RGxKYkNh?= =?iso-2022-jp?B?Q1B5b3BBN1gyc3VvOFNnS2dmeGJHOWhLekZUT25LakZTQXJzaWQ1Rk5y?= =?iso-2022-jp?B?YUtibGdCTy9NemtMZTZyc3pKRlNETGRIYkdTVTZhbENxMmprTlRMcU83?= =?iso-2022-jp?B?Z0tLV01YUVFlVWV4SVJmZ0xDSitoaExNejZLNW5CWGZKTGUzcGxOWlBw?= =?iso-2022-jp?B?ekhRK254WXZmbTk4amdZV1pKZFFMMGJjQjg1bDdERHVWR0x5bytmZ1NR?= =?iso-2022-jp?B?SnlEU1RkeU5CcG4vVWhqbHFOSnhyTDhVbHZPcmNpUVZsaVJ0RnpnSVgy?= =?iso-2022-jp?B?NHFvcytVbW1kUG5GWDJid1lPRnhlYmp6YmtvN05SanZRWHVRdWcwSHFS?= =?iso-2022-jp?B?L3h3Q2dCZlVYSnQzR0NZMnVaTHo1cTNhclUyTWZCNnoyc3F5TW1lK24y?= =?iso-2022-jp?B?M0hLdWRKR2dRZTByYmpBSjVvZDBiYmNnN2hOODFMR1RrejdtLy9hWmJW?= =?iso-2022-jp?B?QnFkRDk4dk15YWgyNjZaR0ZZb1NkbHU0VjRYZHFibGF6aFJmNFFTMDMw?= =?iso-2022-jp?B?OUdrTEJZbE1TaWdSY082Y2dWTWNBZTk4U0laQ0xwcEJxR1ZpZTlqM1p5?= =?iso-2022-jp?B?YlFKM21EMjkrSWlrMDZ1a1RjVERzWm5nSi9rc25mUUZWTWY4MVZlei9z?= =?iso-2022-jp?B?Q2N5UkVtaEZ4SFowYzZNMU1xQ3grR0R6Mm03RFpVUnBlYkVuNzFmN3B0?= =?iso-2022-jp?B?ZVIxeUhQRCs3Ykh3b0F5d3RvVzFqNjcwM2theXZwYklROS96NzBmeTBP?= =?iso-2022-jp?B?dkVkOHRwOGdoVG5aNXdLQmZ1cEl2TEY5RXdZRnFZY2xVY0xFSk9PMUVv?= =?iso-2022-jp?B?cmliQzlJakNFUE5XbGdZeHpHQUZNVFNZdjFsVVdCZjR4bGpiSkprMnlD?= =?iso-2022-jp?B?WFRvNVhOK010aVZMTjJCeE55Z0EweTkzUjZKUUlTMXRZUDNhNGtWaUFS?= =?iso-2022-jp?B?RUhVVWFQaDVJYzdmWURtalhuQXhhQzBJMnlOU0ZQMjlLV2Y4dnBmUm5M?= =?iso-2022-jp?B?VUhSYm1iN0s1bkZmSWFiSC9iUHcrN050ajZSWjhubzVEbUF2OTBSQ3FW?= =?iso-2022-jp?B?M3AwcUpYbk91YnM1NnhqTFBJc1pLejVRU2tnOXRWSU9kdW54MU1jSUZm?= =?iso-2022-jp?B?UENhU09zZDUrNFpyOUIxTWh6cTd5cjE3YkpnbWpKTmF2RDJtbHpsQUtu?= =?iso-2022-jp?B?YjUyYXNUN2cvSTVtZ1hwZC9pQ1pFSXNPdHdFV0UyQ1FKR2ZkWGRnZnJM?= =?iso-2022-jp?B?ejlraXZmV3V5b0x5NzJVOVR3VnpybHRva29PUWNhOFNRMFp5WVlhVElh?= =?iso-2022-jp?B?Wi8zMkpMdGd5S1JrbnAxNS8wOVl0YXcxdWI1dVgzWHFEY3hVV1hVZEVH?= =?iso-2022-jp?B?YWJuNlBRSlVHcDZJWWN6UEl2L0N5QjRpMXRPZTJ3Q0xNSlVWU0E0RG5u?= =?iso-2022-jp?B?ZFptVkFnMCtPQWJxOW1PbW1vZ09QSnhhbjY3K2JSZHpRbVVTZ0hhelQz?= =?iso-2022-jp?B?RnhoNnhEYm9yTnByU0UwM3RwMnZtQWlCeWU1S3lmdXUvWmI3RmNJL0tL?= =?iso-2022-jp?B?Mi9WRG9vcE5pT3hPQ2xFcldxK0QrL1NaaHcrUktFckRCekYwSzlnazVn?= =?iso-2022-jp?B?S3NXN1IwTElmeVVMeDhYMXNja1BGTGlnalVzeDV6TFFyRTllNjNValQz?= =?iso-2022-jp?B?eXpqQTZZR3pzd29JZDMybzZLdFZFb2k4OHpXeW9MYkZaNFdxZWtxbTNB?= =?iso-2022-jp?B?T3pXRDExRDRhRkFhUUp6TkdweU11SXFkOGFYTUczclBIUyttWGlnUmJz?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB6025.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd8f7cb7-76f5-4ec2-4200-08d9726a83db X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 01:46:45.2625 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /v6CPRlEI7Bx1lvBu6vV0lxMhM8u3mfSoQZmCFt9VKDmzVoLB25YCCVocjhoeMSBCFbH9MGWfsPVWoKQmXHm3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB5614 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: naohirot--- via Libc-alpha Reply-To: "naohirot@fujitsu.com" Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Hi Siddhesh, Thank you for the review comment. Hi all, is there any other comment? https://sourceware.org/pipermail/libc-alpha/2021-August/129838.html Thanks. Naohiro > -----Original Message----- > From: Siddhesh Poyarekar > Sent: Thursday, August 5, 2021 4:57 PM > To: Tamura, Naohiro/=1B$BEDB<=1B(B =1B$BD>9-=1B(B ;= libc-alpha@sourceware.org > Subject: Re: [PATCH v3 1/5] benchtests: Enable scripts/plot_strings.py to= read stdin >=20 > On 8/5/21 1:19 PM, Naohiro Tamura via Libc-alpha wrote: > > This patch enables scripts/plot_strings.py to read a benchmark result > > file from stdin. > > To keep backward compatibility, that is to keep accepting multiple of > > benchmark result files in argument, blank argument doesn't mean stdin, > > but '-' does. > > Therefore nargs parameter of ArgumentParser.add_argument() method is > > not changed to '?', but keep '+'. > > > > ex: > > $ jq '.' bench-memset.out | plot_strings.py - > > $ jq '.' bench-memset.out | plot_strings.py - bench-memset-large.out > > $ plot_strings.py bench-memset.out bench-memset-large.out > > > > error ex: > > $ jq '.' bench-memset.out | plot_strings.py > > --- > > benchtests/scripts/plot_strings.py | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) >=20 > Very nice! LGTM. >=20 > Reviewed-by: Siddhesh Poyarekar >=20 > > > > diff --git a/benchtests/scripts/plot_strings.py b/benchtests/scripts/pl= ot_strings.py > > index c71f0804e4de..ec634692d9ad 100755 > > --- a/benchtests/scripts/plot_strings.py > > +++ b/benchtests/scripts/plot_strings.py > > @@ -31,6 +31,7 @@ import json > > import matplotlib as mpl > > import numpy as np > > import os > > +import sys > > > > try: > > import jsonschema as validator > > @@ -331,8 +332,11 @@ def main(args): > > for filename in args.bench: > > bench =3D None > > > > - with open(filename, "r") as f: > > - bench =3D json.load(f) > > + if filename =3D=3D '-': > > + bench =3D json.load(sys.stdin) > > + else: > > + with open(filename, "r") as f: > > + bench =3D json.load(f) > > > > validator.validate(bench, schema) > > > > @@ -354,7 +358,8 @@ if __name__ =3D=3D "__main__": > > > > # Required parameter > > parser.add_argument("bench", nargs=3D"+", > > - help=3D"benchmark results file(s) in json form= at") > > + help=3D"benchmark results file(s) in json form= at, " \ > > + "and/or '-' as a benchmark result file from st= din") > > > > # Optional parameters > > parser.add_argument("-b", "--baseline", type=3Dstr, > >