From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C8A3F1F8C6 for ; Wed, 8 Sep 2021 01:55:54 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7427D3851C3B for ; Wed, 8 Sep 2021 01:55:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7427D3851C3B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631066153; bh=Tu+0njycSH7CqdtE8wdES1w16ZjtiNeif4KU4sqe8FQ=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ANMFivlzjncgr5WW3xjvkMFMNNALjAVEsVJga8gc5I5V+H0Df/3OmB756WjhSI3eQ ZMny8MA0h53iaad7XsDoR8cbAAP9xaJ2Ztj8TotH8olp8qof2MOj46ps30H646+dSv qc9VWUce+zwWqU/LUgUQzZrWdbgL1AVB/Ym76cWk= Received: from esa14.fujitsucc.c3s2.iphmx.com (esa14.fujitsucc.c3s2.iphmx.com [68.232.156.101]) by sourceware.org (Postfix) with ESMTPS id 52CFE385782E for ; Wed, 8 Sep 2021 01:55:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 52CFE385782E X-IronPort-AV: E=McAfee;i="6200,9189,10100"; a="38638207" X-IronPort-AV: E=Sophos;i="5.85,276,1624287600"; d="scan'208";a="38638207" Received: from mail-os2jpn01lp2051.outbound.protection.outlook.com (HELO JPN01-OS2-obe.outbound.protection.outlook.com) ([104.47.92.51]) by ob1.fujitsucc.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 10:55:31 +0900 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GYuFOuCP5TdfZQ9Vb9/FWOcqds5KKcVFihGwU0PHw7V1rbrageQ0xRWdpAbVUNXXVRqO1Rs1L88nvJOJmJ9ATOhIkzvtfAL6OUWkTotBP1atlVvvnEWIo7wg+yFeDx3OPPtmyh6nvNGdBjMWmqZlPiCWVw2b1EOHdbReZpAT6SjuU1VVLo/rjmJkLEaqLlV0EPqqiXrv2749haSWWhdPxsVuPZ3fYOGJwbBc43QvIK+DVGE1eHkEKczYOu9vXniM3fkkrBkL6MmQGCIVDYufq9e6RWlZvf854GGArzrc6yhx24xpq1xgA3h0fOGrRWUC3XECLC0ayinCvoGjpr20hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Tu+0njycSH7CqdtE8wdES1w16ZjtiNeif4KU4sqe8FQ=; b=KWRpuxMl6PRfPZahUatWfAtnBOexSWoyEbt41fwMzhl7zz0/SWmZ8AOaDYCsw8jZHdh1gQ9WBE9WvRorge5k6jjMSIXSDEHUCdSNLeMrzc5Vo8izUhQMivQsCyWpkFiCB/e8N60UNFFEZgR9Yc7+9mCAv2W+sQBsVDyL0VUQ/NaWRsFdtWwrDEpqjDkctSywVXfKbVZmu+DvDLGWRuh6XrmodIFOkPHIFM/jmS9xik/YflPXj6h2VDvEKNwFR4Sle5aWAO17EpzeyQVtTsASdawDwq10edUs+BC6WW4CCvuXzJkxD94k+ApNRJvwyAc+xOCufhEu7w0Et7B+5BlubQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fujitsu.com; dmarc=pass action=none header.from=fujitsu.com; dkim=pass header.d=fujitsu.com; arc=none Received: from TYAPR01MB6025.jpnprd01.prod.outlook.com (2603:1096:402:36::13) by TYAPR01MB5005.jpnprd01.prod.outlook.com (2603:1096:404:12c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 01:55:28 +0000 Received: from TYAPR01MB6025.jpnprd01.prod.outlook.com ([fe80::cde6:2645:63a1:51b]) by TYAPR01MB6025.jpnprd01.prod.outlook.com ([fe80::cde6:2645:63a1:51b%9]) with mapi id 15.20.4478.025; Wed, 8 Sep 2021 01:55:28 +0000 To: "libc-alpha@sourceware.org" Subject: RE: [PATCH v3 4/5] benchtests: Fix validate_benchout.py exceptions Thread-Topic: [PATCH v3 4/5] benchtests: Fix validate_benchout.py exceptions Thread-Index: AQHXic7Bp/iXfsAbo02ySKj9XMNU3quZlRVw Date: Wed, 8 Sep 2021 01:55:28 +0000 Message-ID: References: <20210805074733.433430-1-naohirot@fujitsu.com> <20210805075144.433644-1-naohirot@fujitsu.com> In-Reply-To: <20210805075144.433644-1-naohirot@fujitsu.com> Accept-Language: en-001, ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-securitypolicycheck: OK by SHieldMailChecker v2.6.3 x-shieldmailcheckermailid: 936421c228c94d50bfbefb059ede1532 msip_labels: MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Enabled=true; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SetDate=2021-09-08T01:53:42Z; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Method=Standard; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_Name=FUJITSU-RESTRICTED?; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_SiteId=a19f121d-81e1-4858-a9d8-736e267fd4c7; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ActionId=1327bf15-ef78-48fe-aea2-8312a7f7aeb4; MSIP_Label_a7295cc1-d279-42ac-ab4d-3b0f4fece050_ContentBits=0 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cb69a834-ee34-4dd6-b2a6-08d9726bbbac x-ms-traffictypediagnostic: TYAPR01MB5005: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1443; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y4/MgkcDSbEKK+e15PSUFSRUks8Arzy0dd+7N+1K6WION9OflLtlJNnAp25oll+35Libaw7my/spwBGuiEpneZpC2L1LPEFaSwHdDkX1/iNj8/+NGRwmYkWGfrzX3glg0C1ppOF17H7YtrVYE8M8//hD7I4XG0zpuk0IrGmP8gwB28QeoXU3IoL4tVvq8rtmYyaRphSrvUglHk4GuJNo0EggWkBFJFxPu4SzOHaRiTyhvwUm5OOEuyEPzgZTW6rT3ZhKHeAqglsJdeH/ipid9Pj/9i6ExzRn06rT2ouNYJd0d5GVp3jpNrh1PEnvRx0v7A9G7eQ2fbno7Z57WcooKm9LNSrnZf7sslcQoky40+o+Kp1nApnPP3M670cR+yYmKEp8G9lHcgz5ppIgqUcyngq4QELQBK12Is7PDQOkVuURy9MKsbDiGJSffQUL8O+e/Ch2sQHbO/FJovVSoEJtRXZxwSbgPmLUu4BtFO8V4sSaJW22wApvnuuOKroizHHFiFYL623MgqWBo0LsrkEeKUQzhtHUoVcDpeUmpr/cvHfHbdaC8yQhZBl3oNego3GPstzat7lIc0vWQesTPsncZDUeYwE6EFvnOXxEIN9m+zFpUJrqz4E3ymStzJG3qVNDmY+qLI9jmb9yGTWLuS4QhACGxA06Cl4K7YMdyi6Ylvxaqf5pwZWj0IQTREc8Rr0rcKmYzgACEDkVBHISaGpOHp9ciKC9NkmAPN1nbY9uShMsUibB5Z6LpmDdKThv/NKUpuegNuPGu5Wtq4CyQ4Idy/Z4fljhEUo7XO0cW09wrpg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYAPR01MB6025.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(39860400002)(366004)(136003)(15650500001)(9686003)(6506007)(55016002)(26005)(478600001)(6916009)(966005)(33656002)(53546011)(38070700005)(186003)(52536014)(66476007)(86362001)(2906002)(7696005)(71200400001)(66446008)(85182001)(8676002)(122000001)(8936002)(38100700002)(64756008)(83380400001)(5660300002)(316002)(66556008)(66946007)(76116006); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?M3l1bFowVU16ZSt3R2k4ZjN6eXdycm1QM0srQmJMcloyZlpmZWNrYkRQ?= =?iso-2022-jp?B?VGw4cHRJOHNoVGs4MXluK1FOeVVBY2thZ0R3Q3lFUkZYVEx4Z25QdTlO?= =?iso-2022-jp?B?SS9kS1d2b01Ua0JNbGFVTGpkR1pYZEs5R09QZmZJWFBSUnpENFBxZ3dO?= =?iso-2022-jp?B?QjhuOFFzWmRkKzdtUmdCekF2SzJNMlJRNUU2R3RVYnBiZXQxQmdid1Ay?= =?iso-2022-jp?B?dDBJYURKRmtVVVpqZWhHM043MUFXVDMzNXVhNENsV2t6NjdBeVVlUk1M?= =?iso-2022-jp?B?SFNaZFFHajZSSnY1SjhjbzR2d0NzRC9mOG4zZTg4RWV4c1FYWUltRFFY?= =?iso-2022-jp?B?SGtYSmdMQ0pySitzQnJnRDFpcWNNa3NXaE0vSVc5ZUgrdldhSitMS2FO?= =?iso-2022-jp?B?NFQzYWJBUnlCUGRDc01qakNMQUExaVY4Mzk2SExiK1Y3ditsNnZ0b1RJ?= =?iso-2022-jp?B?YWkzMHpuR2lERVUycDNrK0xING5pSzBMUXR0L2l5MGNBKzg2R3lGdUhx?= =?iso-2022-jp?B?aHFEUmRSU25xQkwzcG9peXY1UStRTmFWcVI5QW9kRVZ6VENKTkZsMXlU?= =?iso-2022-jp?B?eW1XejQvMytoaG8wUUVaYVZsdHZqZnFLaDFzTHg4M2dyQStIM2Q4V2xY?= =?iso-2022-jp?B?TmtYbWRyaHRBL0xHZ3FhN0FnNGkyQUk1S3FwMERkN0ZSNFlSdWp6RzZv?= =?iso-2022-jp?B?ZnFaeXlQdnF1NzZXc2h3M3JoUmFRMEtHNDVaaVJ0RkhSMkwrUUVzeTZk?= =?iso-2022-jp?B?eGVDWng5L2YxZ1FyS3M5UmcyaTgzbVpFS0FmQWIzaUZ4TTRMTTQ2b0hO?= =?iso-2022-jp?B?UEdnbFY1RE5ONE5lYXR2Nk5RZHM4b1NJUEg1TlJodXg3UWR3RGdRallr?= =?iso-2022-jp?B?c3B1TERwKzRzVFp2cFc2MGlUQSt4ZGUwOW92QitlNEkydDIrMVRJSUNL?= =?iso-2022-jp?B?L3pOcHRqNnNjdDVId0NidDJSbEZTaGlOUTdMZTk4OFAyMFBCeUtLaTRn?= =?iso-2022-jp?B?M2lUTlRHLzBkbklUZzRuUFNUbzBPbmZqMWlzQmhMTGY5RXNHOHB0cDdH?= =?iso-2022-jp?B?aTdZWkVnZ2FKcjd6RFY5a25jSUVMSnllVXNhYndWZG44NFZER29hSzJC?= =?iso-2022-jp?B?MWU5Zm5BdFpOSTFqVWh1c0hHOHZRWnpQaTVxTENtVGEvOS9mdFZQWGJQ?= =?iso-2022-jp?B?T2YrQ29RaUdENkREaVllZS9rd3hJZW4ydTZ0bXN1QWJmOXhHdnBycjdy?= =?iso-2022-jp?B?NHlPTENPWFJpYitiZ3h0dVNRQWw2MzhBM3B0djZQNjBHU3hGQXdOQ2hk?= =?iso-2022-jp?B?WXFXQ3VPM1l3dFZVeHBkTHR0b0oyRGVxekFYY1N6U1JxOUVYZTIvWXFp?= =?iso-2022-jp?B?WjRySzI0TXZzU2pzUTQxWEZiRmpyVnZWUFRLZ0xJditXdGFkVEpsZ2pv?= =?iso-2022-jp?B?bkpvdm5ScnJIaXNORXU4cEZXemxCNnNSdW1hVzZ3aENFWVM3Y1BETnFp?= =?iso-2022-jp?B?OXBpaW1jZ2JSbVdNMnJSaXVHL0wvdDNzSjNOb0ZJSlpLVDRJTWd1Wkd4?= =?iso-2022-jp?B?T0pBQmZyQStnUmJzM2FsMHlmRTc5MGN1ZU8zSGV6b0FKaVFlemFadnpS?= =?iso-2022-jp?B?VHE4Smpoa0E0c2xhNkNOaVRudG1YQlA2QTBhRnlML1lYT2hrZ1ZvMXlC?= =?iso-2022-jp?B?V0pCdTBMamduSFQzOU9pNUdRSldKa2ZuV1VlS2k3ZlJPa3JVcUl5NzB5?= =?iso-2022-jp?B?UXFTZXRMNzZkMnZPbFFxVDBMS3FmTEFCTFNzUUZwcXcwTHlzL3FSa1Nz?= =?iso-2022-jp?B?RUthTFltWldOaERnL3A4R1JWaUlsSmFTTjZiYStmT2pkQWhlQ1QxZ2NM?= =?iso-2022-jp?B?UmRYRDEwdlZBbDIvNzFaVDF1MlY4N2NaUHBGNU1HTmN5SXRoTFVYV0Iv?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: fujitsu.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB6025.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb69a834-ee34-4dd6-b2a6-08d9726bbbac X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 01:55:28.4514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a19f121d-81e1-4858-a9d8-736e267fd4c7 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TjzO4CVVTX4uZESzV1OFukwJm7s3jKjF3WJ8SFHXxzgxS0V1BhB8X73hN0tIfk1A1hmSNWk4qDUWPlWCpAkqaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB5005 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: naohirot--- via Libc-alpha Reply-To: "naohirot@fujitsu.com" Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" Hi all, is there any comment? https://sourceware.org/pipermail/libc-alpha/2021-August/129841.html Thanks. Naohiro > -----Original Message----- > From: Naohiro Tamura > Sent: Thursday, August 5, 2021 4:52 PM > To: libc-alpha@sourceware.org > Cc: Tamura, Naohiro/=1B$BEDB<=1B(B =1B$BD>9-=1B(B > Subject: [PATCH v3 4/5] benchtests: Fix validate_benchout.py exceptions >=20 > This patch fixed validate_benchout.py two exceptions, AttributeError > if benchout_strings.schema.json is specified and > json.decoder.JSONDecodeError if benchout is not JSON. > --- > benchtests/scripts/import_bench.py | 5 ++++- > benchtests/scripts/validate_benchout.py | 6 +++++- > 2 files changed, 9 insertions(+), 2 deletions(-) >=20 > diff --git a/benchtests/scripts/import_bench.py b/benchtests/scripts/impo= rt_bench.py > index a799b4e1b7dc..e3337ca5d638 100644 > --- a/benchtests/scripts/import_bench.py > +++ b/benchtests/scripts/import_bench.py > @@ -104,7 +104,10 @@ def do_for_all_timings(bench, callback): > """ > for func in bench['functions'].keys(): > for k in bench['functions'][func].keys(): > - if 'timings' not in bench['functions'][func][k].keys(): > + try: > + if 'timings' not in bench['functions'][func][k].keys(): > + continue > + except AttributeError: > continue >=20 > callback(bench, func, k) > diff --git a/benchtests/scripts/validate_benchout.py b/benchtests/scripts= /validate_benchout.py > index 47df33ed0252..00d5fa0ee5eb 100755 > --- a/benchtests/scripts/validate_benchout.py > +++ b/benchtests/scripts/validate_benchout.py > @@ -73,11 +73,15 @@ def main(args): >=20 > except bench.validator.ValidationError as e: > return print_and_exit("Invalid benchmark output: %s" % e.message= , > - os.EX_DATAERR) > + os.EX_DATAERR) >=20 > except bench.validator.SchemaError as e: > return print_and_exit("Invalid schema: %s" % e.message, os.EX_DA= TAERR) >=20 > + except json.decoder.JSONDecodeError as e: > + return print_and_exit("Benchmark output in %s is not JSON." % ar= gs[0], > + os.EX_DATAERR) > + > print("Benchmark output in %s is valid." % args[0]) > return os.EX_OK >=20 > -- > 2.17.1