unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Dragan Mladjenovic <dmladjenovic@wavecomp.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
	Joseph Myers <joseph@codesourcery.com>,
	Carlos O'Donell <carlos@redhat.com>,
	"Maciej W. Rozycki" <macro@linux-mips.org>,
	Faraz Shahbazker <fshahbazker@wavecomp.com>,
	Paul Burton <pburton@wavecomp.com>
Subject: Re: [PATCH 0/3] Mips support for PT_GNU_STACK
Date: Fri, 28 Jun 2019 12:21:23 +0000	[thread overview]
Message-ID: <CY4PR22MB01197C1AE6384B737F28A4E0B3FC0@CY4PR22MB0119.namprd22.prod.outlook.com> (raw)
In-Reply-To: <87lfxmp0q1.fsf@oldenburg2.str.redhat.com>

Thanks for the comment.

>> The form of detection the patch proposes is not yet provided by the
>> kernel. Instead, this version of the patch does kernel version check
>> at runtime and provides compatible behavior if it cannot detect the
>> 4.8 kernel or newer.
>
> People patch their kernels to lie about the version, so I don't think
> this is correct.

I'm not particularly fond of doing version checks, but this something
that is already done to enforce minimum kernel version supported 
by the glibc. Not sure this would be more broken that that. 

> Kernel developers also think it's acceptable to change compatibility
> mechanisms that have already been deployed in binutils or glibc, so I
> really think this needs to wait until some signal has been added to the
> the auxiliary vector in a mainline kernel.

I don't think that any new change on kernel side will make this change
obsolete or broken. At best if some kind of the signal gets provided by 
the kernel in the future that would allow us the have a real non-executable stack
on pre-4.8 kernel + 4.8 patch + future patch that provides the signal.

Best regards,

Dragan

  reply	other threads:[~2019-06-28 12:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 21:49 [PATCH 0/3] Mips support for PT_GNU_STACK Dragan Mladjenovic
2019-06-27 21:50 ` [PATCH 1/3] [ELF] Allow the machine to override stack permissions via USE_DL_EXEC_STACK_OVERRIDE Dragan Mladjenovic
2019-07-08 11:33   ` Joseph Myers
2019-07-09 21:35     ` Dragan Mladjenovic
2019-07-08 11:50   ` Florian Weimer
2019-06-27 21:50 ` [PATCH 2/3] [MIPS] Define USE_DL_EXEC_STACK_OVERRIDE on Mips Dragan Mladjenovic
2019-06-27 21:50 ` [PATCH 3/3] [RFC][MIPS] Define GNU_STACK ABI Dragan Mladjenovic
2019-06-28  8:34 ` [PATCH 0/3] Mips support for PT_GNU_STACK Florian Weimer
2019-06-28 12:21   ` Dragan Mladjenovic [this message]
2019-06-28 16:19   ` Faraz Shahbazker
2019-07-05 12:52     ` Dragan Mladjenovic
2019-07-05 16:16       ` Maciej W. Rozycki
2019-07-08 12:01     ` Florian Weimer
2019-07-09 22:39       ` Dragan Mladjenovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR22MB01197C1AE6384B737F28A4E0B3FC0@CY4PR22MB0119.namprd22.prod.outlook.com \
    --to=dmladjenovic@wavecomp.com \
    --cc=carlos@redhat.com \
    --cc=fshahbazker@wavecomp.com \
    --cc=fweimer@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=macro@linux-mips.org \
    --cc=pburton@wavecomp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).