From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C0D9A1F601 for ; Fri, 2 Dec 2022 14:05:14 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="yyjC7NEt"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DB022385840D for ; Fri, 2 Dec 2022 14:05:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB022385840D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669989912; bh=wJsT/xj/B7eHI8bQUCP+nE8bz9flpw/yLM+MWSZu5Fk=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=yyjC7NEt18wwurfrPoHA0lDNUM/ooZ5Gn0eJRHsosgBkNef/JfBYnxMdTW48Nfuf4 zx8fA86e506R5EZsFtLMeOvBTOwUmtVU/7l7D1sBTlwdvPxXlP8JDUdjh035Oz5hQ5 3mRzs71dZHQ8hZURA12Zhj7I5SSL8JDjB//dYWVQ= Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 2FFC93858D28 for ; Fri, 2 Dec 2022 14:04:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2FFC93858D28 Received: by mail-ot1-x333.google.com with SMTP id r9-20020a05683001c900b0066e6e7a751eso2984733ota.0 for ; Fri, 02 Dec 2022 06:04:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wJsT/xj/B7eHI8bQUCP+nE8bz9flpw/yLM+MWSZu5Fk=; b=4Ft7UlbPTbVbI0FQEtJyUz5dz0B4+xIYs+ArbTw8mwVigqbkP226nJPrzg/K4r/Bv4 bcmLzzaIxEyH4ZQEeA45C7GKb06zH97B6sdPeA6RYvuN+HY3tRmottLwoZbhJbc3h0Yz coj4LLTsMXRW/iQJOXZn2A2tOt+16k803+8g6aj3s73ZsGGRAf4BpNllYQgotAygmTfF V0KfqKkEBYKmm4Uzk+7+V7AfuxitMQnxnQau2XxVwRvO72j0dlYzLBMMAmwgN53FnupD KZSDRcss4H9Ilxy7Gna1Ou7S9fr9mg24OReybQcj2sqwaYR66w77wFAaEn/r90Za/K3L lLAQ== X-Gm-Message-State: ANoB5pl8vhvfBgEsVKwCD+8+YYBrIBLQZSjPIaq1pfwN2ChNNG8xkAE/ lqY5REjcqp0jLgLISSxV480rPaI4N1e9MorOq09xxlrh3nNwWdAH5LFhBQ== X-Google-Smtp-Source: AA0mqf6/iEZTQp6TRGs8fncn63QcvKIQCMwNxsaCiFqRrZXFGeskUKm+ZTI4Z0ulJAnn2djDAKyBqoIC6NnMPATRWKk= X-Received: by 2002:a05:6830:134a:b0:661:a273:f0c4 with SMTP id r10-20020a056830134a00b00661a273f0c4mr25509013otq.120.1669989890066; Fri, 02 Dec 2022 06:04:50 -0800 (PST) MIME-Version: 1.0 References: <20221202135558.23781-1-bugaevc@gmail.com> In-Reply-To: <20221202135558.23781-1-bugaevc@gmail.com> Date: Fri, 2 Dec 2022 17:04:38 +0300 Message-ID: Subject: Re: [PATCH v3] hurd: Make getrandom cache the server port To: bug-hurd@gnu.org, libc-alpha@sourceware.org, samuel.thibault@gnu.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bugaev via Libc-alpha Reply-To: Sergey Bugaev Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Fri, Dec 2, 2022 at 4:56 PM Sergey Bugaev wrote: > + switch (flags) > + { > + case 0: > + cached_server = &urandom_server; > + break; > + case GRND_RANDOM: > + cached_server = &random_server; > + break; > + case GRND_NONBLOCK: > + cached_server = &urandom_server_nonblock; > + break; > + case GRND_RANDOM | GRND_NONBLOCK: > + cached_server = &random_server_nonblock; > + break; > + default: > + return __hurd_fail (EINVAL); > + } > + > + if (flags & GRND_RANDOM) > + random_source = "/dev/random"; > + if (flags & GRND_NONBLOCK) > + open_flags |= O_NONBLOCK; > + /* No point in passing either O_NOCTTY, O_IGNORE_CTTY, or O_CLOEXEC > + to file_name_lookup, since we're not making an fd. */ Ooops, the indentation is off here, and of course I'm only seeing this after having sent the patch. Nor did GCC warn me. Sigh. If the patch is otherwise alright, could you please fix that when committing? If it's not, I'll fix it in v4. Sergey