From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 04ED71F451 for ; Wed, 3 Jan 2024 21:25:19 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=a46ME4t7; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 250DB3857C49 for ; Wed, 3 Jan 2024 21:25:19 +0000 (GMT) Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31]) by sourceware.org (Postfix) with ESMTPS id 26B5E3858C62 for ; Wed, 3 Jan 2024 21:24:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26B5E3858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26B5E3858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704317083; cv=none; b=mZ0FTN5QrGBktYfHQY6unJN3g013dQnX6AbEANQFziQbe4UaN1MBDgT+mdlDV1iTGnt76GVF3m0LuZ1YNkRGmbLBZhn0F8XN1/7XGlo6l8ypaEZngGwf1C2noC50RNS1shHqAKIDgVSq4hP+CdrW40KGVdxTOrCrgUUl3j33W2s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704317083; c=relaxed/simple; bh=VqlsNUnKZXrRzECrAb+xJs8BytLD9uPAp0r7OZkG6WM=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=jXM9K/iYHtgo15QfEdAkImQ/jfbhGLAdEluN+/U+gy1ADN7kOccA7Z6dT4iQBBgiild/qNVqZCXcMJlOMdgyCwcD4DJQmDmd9tXQVLOH6Dx+GJ+fmzzU42sj+oUNB8fAT8voB5T0C6NrQmZsbo+d3wsJZo8CJK5HXO1uHMtd7kY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-203fb334415so6368187fac.2 for ; Wed, 03 Jan 2024 13:24:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704317081; x=1704921881; darn=sourceware.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VqlsNUnKZXrRzECrAb+xJs8BytLD9uPAp0r7OZkG6WM=; b=a46ME4t7eOuwNdIFEbVFE1jZTadsSODm8MPF76wamlEnRAut6npbtfx/rPWycXccCf HITL9lGgTcCe1hkS3U5EY9eJxXaDNacRBENypu8dl8ntz9jPh5VjOl8YbqcOSoSb67qz MXXd7qkps+QZM82rqxDuAASGgAAhaCaOhfajbem5yVsOg9IMjcV0q7npgNM9INdLXKwz 1nMgu6usorRBlU8EmlWeSz9fkbKMX4DctQ/XegWGVlDjg1z76UkPnT0OBrcUFuyZc61y 180WXNsEF3T/dsVQCO3T8+TQxUO89EPIH6sp0qLhLMK6uoPV0WLi//uDuN/VYag4F6XJ kSKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704317081; x=1704921881; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VqlsNUnKZXrRzECrAb+xJs8BytLD9uPAp0r7OZkG6WM=; b=gbf71QNFGo6k2oy98g2kyw/xyO96nxhd1FanKNs/dkMOa0nnpH0ST0H07Asow/2yj8 ottCYch61skER1Qxtk5x8w4Y+yLl0wx63Awb1KBZizNjJE9LDUpDE+eWoloxP4sX6R3L Qr9d8+cY4PiYA9VCTA6s2J4tt6lMYwlu03kGGO6DLVi+/+8SN1S8zwFitR1s/N/Qq7n0 RXzRpsMVVvmtyvP8emEzHu/zfahxl8gnVA9jmN41HUFdMv6AbjuPTM8uIKeJqBvKSWTf 5maaPmlEI8lyCa10OXh/iOclrvjXi7mQQF4YPXrrFLmH26TQeJBUP5DCZ3AGk8fh3WSp KlEQ== X-Gm-Message-State: AOJu0YzHmDILCoNZxEtn8hxL00t61HosW7XKk3BO42oVMmGeMD0QaIwJ QlXxuDo3Bhi4zL1KrXBSmE7u5h6yamp8Eff99/QJ31+y13Y= X-Google-Smtp-Source: AGHT+IHNjKpekqhh/mOOpmQsS0PWObsj8tyWOdAA45JjTKSF58QbRDyQL06jEk2V0YlFmr39NA1XmGQ//7gXbdEPWNU= X-Received: by 2002:a05:6870:a70c:b0:204:aeb:3d33 with SMTP id g12-20020a056870a70c00b002040aeb3d33mr25043117oam.40.1704317081431; Wed, 03 Jan 2024 13:24:41 -0800 (PST) MIME-Version: 1.0 References: <20240103171502.1358371-1-bugaevc@gmail.com> <20240103171502.1358371-2-bugaevc@gmail.com> <20240103204314.wpyy2tv33x4sdl37@begin> In-Reply-To: From: Sergey Bugaev Date: Thu, 4 Jan 2024 00:24:30 +0300 Message-ID: Subject: Re: [PATCH 01/23] hurd: Add some missing includes To: Samuel Thibault Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On Thu, Jan 4, 2024 at 12:08=E2=80=AFAM Sergey Bugaev w= rote: > This is testing installed headers, isn't it? =E2=80=94 then > how come sysdeps/hurd/include/hurd.h is what gets found for ? > I'm rather sure the installed is a different file. So it > would look like the test setup is broken, and this patch just exposes > that. Should the include be guarded by ifndef _ISOMAC perhaps? And if we indeed move the inline functions to the internal hurd.h, they'd also be guarded by ifndef _ISOMAC? But really, why doesn't the test filter out the internal include directorie= s? Sergey