From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 6A95B1F55B for ; Thu, 28 May 2020 12:29:10 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1FD9239730EA; Thu, 28 May 2020 12:29:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1FD9239730EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1590668949; bh=3kPFZ+UP+mXBXM+5bdAi5k5F2KfcAeQ2PDO+MY0AEW0=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xSDof3W0d0MZai0ar9l2SKE49WEUUR6H2+BHT/LdwZfkMYx6Q2J6FwJK66mlZ4WpF b1T3WccqoIymXReSl8hHbeOPQVymyaSB+IpzZQ+L1YfNs8bN/9+eGzrsh0HjbbeDJe P9j948RebDz7+39BUxOHTVYkH2RZs6ioN09qY5TY= Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by sourceware.org (Postfix) with ESMTPS id 60425386F831 for ; Thu, 28 May 2020 12:29:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 60425386F831 Received: by mail-io1-xd2b.google.com with SMTP id f3so29771433ioj.1 for ; Thu, 28 May 2020 05:29:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3kPFZ+UP+mXBXM+5bdAi5k5F2KfcAeQ2PDO+MY0AEW0=; b=bwwqeoo2C5s0gqyyZJXaI+H/1kAn+GmjblVvpqd2UfvYQLbHwuF5I7SiN31bERSGdF IuZpeOQ4o6mRseOcGVdLH8moroh7jhdKP/bKGnaJXvKfPHZ9db6MNyh5tOPyM8LuHtsx JMcHJR32GP45ZOrxwq2o97HGXT5BFSSe5s63E01MswppW88AHOETBezV5h8H6FuCqHoE sNKdRU0qiCQVsfItLRWYfNmwT+Wkaw5p5nOajeREedpV2y89Y7ZmSlskij300mPpf0d3 JVet29gdFh0KS5WPw5S4xXEUUMekmlZpD5QqABPll8k9Yk0SVcL1T9A0aCvRpJSO2/lq Gs3Q== X-Gm-Message-State: AOAM531Nl6pcRTuM1H/6afOHxty4iPeXSQLI/FUnjIifQwgDsPbwgxMK 2ZrUfr8+stlvVgKAJODnyUleQFpgdEq8CExJd6o= X-Google-Smtp-Source: ABdhPJzglnHXPTAA2/lXIM0ssq6w5zJGmT1ehN2+wdwbY+r6jUXKNT3BlftJahYZOb8sT4zPJHH29PBWDl2EUtZ7xt0= X-Received: by 2002:a6b:39c3:: with SMTP id g186mr1995016ioa.91.1590668945885; Thu, 28 May 2020 05:29:05 -0700 (PDT) MIME-Version: 1.0 References: <20200505181605.22346-1-lukma@denx.de> <87v9kkmgcw.fsf@igel.home> <87367lk0nk.fsf@oldenburg2.str.redhat.com> <87y2pdiltl.fsf@oldenburg2.str.redhat.com> In-Reply-To: <87y2pdiltl.fsf@oldenburg2.str.redhat.com> Date: Thu, 28 May 2020 05:28:30 -0700 Message-ID: Subject: [PATCH] Fix __clock_gettime64 with _ISOMAC in sysdeps/generic/hp-timing.h To: Florian Weimer Content-Type: multipart/mixed; boundary="00000000000079f78405a6b47938" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "H.J. Lu via Libc-alpha" Reply-To: "H.J. Lu" Cc: Andreas Schwab , Alistair Francis , "H.J. Lu via Libc-alpha" , Joseph Myers Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" --00000000000079f78405a6b47938 Content-Type: text/plain; charset="UTF-8" On Wed, May 27, 2020 at 5:50 AM Florian Weimer wrote: > > * H. J. Lu: > > > On Wed, May 27, 2020 at 5:44 AM Florian Weimer wrote: > >> > >> * Andreas Schwab: > >> > >> > I don't think it make sense for benchtests to define _ISMAC if it uses > >> > glibc internal interfaces. > >> > >> We have some internal interfaces that are available for !_ISOMAC, > >> e.g. pretty much the entire support/ directory. > >> > >> I assume this is about ? We could decide that it should be > >> in this category as well. > > > > To be precise, it is sysdeps/generic/hp-timing.h: > > > > #define HP_TIMING_NOW(var) \ > > ({ \ > > struct __timespec64 tv; \ > > __clock_gettime64 (CLOCK_MONOTONIC, &tv); \ > > (var) = (tv.tv_nsec + UINT64_C(1000000000) * tv.tv_sec); \ > > }) > > Okay, then we could add an #ifdef _ISOMAC and use clock_gettime outside > glibc. Temporarily, until we have clock_gettime64 available outside > glibc, too. > Like this? -- H.J. --00000000000079f78405a6b47938 Content-Type: application/x-patch; name="0001-Fix-__clock_gettime64-with-_ISOMAC-in-sysdeps-generi.patch" Content-Disposition: attachment; filename="0001-Fix-__clock_gettime64-with-_ISOMAC-in-sysdeps-generi.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kaqr62w30 RnJvbSAxNTM2ZjNjZDQ5NzY0MTFhZGJiYzI2MjVhY2QxNjAxZTllMGRjMjM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiSC5KLiBMdSIgPGhqbC50b29sc0BnbWFpbC5jb20+CkRhdGU6 IFNhdCwgMjMgTWF5IDIwMjAgMTA6MDQ6MjAgLTA3MDAKU3ViamVjdDogW1BBVENIXSBGaXggX19j bG9ja19nZXR0aW1lNjQgd2l0aCBfSVNPTUFDIGluCiBzeXNkZXBzL2dlbmVyaWMvaHAtdGltaW5n LmgKTUlNRS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVU Ri04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCmNvbW1pdCBlOTY5ODE3NWIwYjYw NDA3ZGIxZTg5YmNmMjk0MzdhYjIyNGJjYTBiCkF1dGhvcjogTHVrYXN6IE1hamV3c2tpIDxsdWtt YUBkZW54LmRlPgpEYXRlOiAgIE1vbiBNYXIgMTYgMDg6MzE6NDEgMjAyMCArMDEwMAoKICAgIHky MDM4OiBSZXBsYWNlIF9fY2xvY2tfZ2V0dGltZSB3aXRoIF9fY2xvY2tfZ2V0dGltZTY0CgpicmVh a3MgYmVuY2h0ZXN0cyB3aXRoIHN5c2RlcHMvZ2VuZXJpYy9ocC10aW1pbmcuaDoKCkluIGZpbGUg aW5jbHVkZWQgZnJvbSAuL2JlbmNoLXRpbWluZy5oOjIzLAogICAgICAgICAgICAgICAgIGZyb20g Li9iZW5jaC1za2VsZXRvbi5jOjI1LAogICAgICAgICAgICAgICAgIGZyb20KL2V4cG9ydC9idWls ZC9nbnUvdG9vbHMtYnVpbGQvZ2xpYmMtZ2l0bGFiL2J1aWxkLXg4Nl82NC1saW51eC9iZW5jaHRl c3RzL2JlbmNoLXJpbnQuYzo0NToKLi9iZW5jaC1za2VsZXRvbi5jOiBJbiBmdW5jdGlvbiDigJht YWlu4oCZOgouLi9zeXNkZXBzL2dlbmVyaWMvaHAtdGltaW5nLmg6Mzc6MjM6IGVycm9yOiBzdG9y YWdlIHNpemUgb2Yg4oCYdHbigJkgaXNu4oCZdCBrbm93bgogICAzNyB8ICAgc3RydWN0IF9fdGlt ZXNwZWM2NCB0djsgICAgICBcCiAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgIF5+CgpXZSBz aG91bGQgdXNlIGNsb2NrX2dldHRpbWUgaW4gc3lzZGVwcy9nZW5lcmljL2hwLXRpbWluZy5oIGlm IF9JU09NQUMgaXMKZGVmaW5lZC4gIERvbid0IGRlZmluZSBfX2Nsb2NrX2dldHRpbWUgaW4gYmVu Y2h0ZXN0cy9iZW5jaC10aW1pbmcuaCBzaW5jZQppdCBpcyBubyBsb25nZXIgbmVlZGVkLgotLS0K IGJlbmNodGVzdHMvYmVuY2gtdGltaW5nLmggICB8IDEgLQogc3lzZGVwcy9nZW5lcmljL2hwLXRp bWluZy5oIHwgNSArKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKCmRpZmYgLS1naXQgYS9iZW5jaHRlc3RzL2JlbmNoLXRpbWluZy5oIGIvYmVuY2h0 ZXN0cy9iZW5jaC10aW1pbmcuaAppbmRleCBhMGQ2ZjgyNDY1Li5kMDE3NmZiNzZlIDEwMDY0NAot LS0gYS9iZW5jaHRlc3RzL2JlbmNoLXRpbWluZy5oCisrKyBiL2JlbmNodGVzdHMvYmVuY2gtdGlt aW5nLmgKQEAgLTE4LDcgKzE4LDYgQEAKIAogI3VuZGVmIGF0dHJpYnV0ZV9oaWRkZW4KICNkZWZp bmUgYXR0cmlidXRlX2hpZGRlbgotI2RlZmluZSBfX2Nsb2NrX2dldHRpbWUgX19jbG9ja19nZXR0 aW1lNjQKICNpbmNsdWRlIDxocC10aW1pbmcuaD4KICNpbmNsdWRlIDxzdGRpbnQuaD4KIApkaWZm IC0tZ2l0IGEvc3lzZGVwcy9nZW5lcmljL2hwLXRpbWluZy5oIGIvc3lzZGVwcy9nZW5lcmljL2hw LXRpbWluZy5oCmluZGV4IGFmOWQ5MmY3ZjcuLjk5YjEyOTk1ZjEgMTAwNjQ0Ci0tLSBhL3N5c2Rl cHMvZ2VuZXJpYy9ocC10aW1pbmcuaAorKysgYi9zeXNkZXBzL2dlbmVyaWMvaHAtdGltaW5nLmgK QEAgLTI0LDYgKzI0LDExIEBACiAjaW5jbHVkZSA8c3RkaW50Lmg+CiAjaW5jbHVkZSA8aHAtdGlt aW5nLWNvbW1vbi5oPgogCisjaWZkZWYgX0lTT01BQworIyBkZWZpbmUgX190aW1lc3BlYzY0IHRp bWVzcGVjCisjIGRlZmluZSBfX2Nsb2NrX2dldHRpbWU2NCBjbG9ja19nZXR0aW1lCisjZW5kaWYK KwogLyogSXQgc2hvdWxkIG5vdCBiZSB1c2VkIGZvciBsZC5zby4gICovCiAjZGVmaW5lIEhQX1RJ TUlOR19JTkxJTkUJKDApCiAKLS0gCjIuMjYuMgoK --00000000000079f78405a6b47938--