unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
To: "Wang, Pengfei" <pengfei.wang@intel.com>
Cc: "llvm-dev@lists.llvm.org" <llvm-dev@lists.llvm.org>,
	GNU C Library <libc-alpha@sourceware.org>,
	GCC Patches <gcc-patches@gcc.gnu.org>,
	IA32 System V Application Binary Interface
	<ia32-abi@googlegroups.com>,
	Joseph Myers <joseph@codesourcery.com>
Subject: Re: [llvm-dev] [PATCH] Add optional _Float16 support
Date: Tue, 13 Jul 2021 08:04:36 -0700	[thread overview]
Message-ID: <CAMe9rOrXar1Ajfqs010Dv3e-tENPVb7o1zyL34XHy43SaOaVpg@mail.gmail.com> (raw)
In-Reply-To: <DM6PR11MB3003C3EAC12FBD2DA8AFA04288149@DM6PR11MB3003.namprd11.prod.outlook.com>

On Tue, Jul 13, 2021 at 7:48 AM Wang, Pengfei <pengfei.wang@intel.com> wrote:
>
> Hi H.J.,
>
> Our LLVM implementation currently use %xmm0 for both _Complex's real part and imaginary part. Do we have special reason to use two registers?
> We are using one register on X64. Considering the performance, especially the register pressure, should it be better to use one register for _Complex _Float16 on 32 bits target?

x86-64 psABI is unrelated to i386 psABI.  Using a pair of registers is
more natural for
complex _Float16.  Since it is only used for function return value, I
don't think there is
a register pressure issue.

> Thanks
> Pengfei
>
> -----Original Message-----
> From: H.J. Lu <hjl.tools@gmail.com>
> Sent: Tuesday, July 13, 2021 10:26 PM
> To: Wang, Pengfei <pengfei.wang@intel.com>; llvm-dev@lists.llvm.org
> Cc: Joseph Myers <joseph@codesourcery.com>; GCC Patches <gcc-patches@gcc.gnu.org>; GNU C Library <libc-alpha@sourceware.org>; IA32 System V Application Binary Interface <ia32-abi@googlegroups.com>
> Subject: Re: [llvm-dev] [PATCH] Add optional _Float16 support
>
> On Mon, Jul 12, 2021 at 8:59 PM Wang, Pengfei <pengfei.wang@intel.com> wrote:
> >
> > > Return _Float16 and _Complex _Float16 values in %xmm0/%xmm1 registers.
> >
> > Can you please explain the behavior here? Is there difference between
> > _Float16 and _Complex _Float16 when return? I.e., 1, In which case will _Float16 values return in both %xmm0 and %xmm1?
> > 2, For a single _Float16 value, are both real part and imaginary part returned in %xmm0? Or returned in %xmm0 and %xmm1 respectively?
>
> Here is the v2 patch to add the missing _Float16 bits.   The PDF file is at
>
> https://gitlab.com/x86-psABIs/i386-ABI/-/wikis/Intel386-psABI
>
> > Thanks
> > Pengfei
> >
> > -----Original Message-----
> > From: llvm-dev <llvm-dev-bounces@lists.llvm.org> On Behalf Of H.J. Lu
> > via llvm-dev
> > Sent: Friday, July 2, 2021 6:28 AM
> > To: Joseph Myers <joseph@codesourcery.com>
> > Cc: llvm-dev@lists.llvm.org; GCC Patches <gcc-patches@gcc.gnu.org>;
> > GNU C Library <libc-alpha@sourceware.org>; IA32 System V Application
> > Binary Interface <ia32-abi@googlegroups.com>
> > Subject: Re: [llvm-dev] [PATCH] Add optional _Float16 support
> >
> > On Thu, Jul 1, 2021 at 3:10 PM Joseph Myers <joseph@codesourcery.com> wrote:
> > >
> > > On Thu, 1 Jul 2021, H.J. Lu via Gcc-patches wrote:
> > >
> > > > 2. Return _Float16 and _Complex _Float16 values in %xmm0/%xmm1 registers.
> > >
> > > That restricts use of _Float16 to processors with SSE.  Is that what
> > > we want in the ABI, or should _Float16 be available with base 32-bit
> > > x86 architecture features only, much like _Float128 and the decimal
> > > FP types
> >
> > Yes, _Float16 requires XMM registers.
> >
> > > are?  (If it is restricted to SSE, we can of course ensure relevant
> > > libgcc functions are built with SSE enabled, and likewise in glibc
> > > if that gains
> > > _Float16 functions, though maybe with some extra complications to
> > > get relevant testcases to run whenever possible.)
> > >
> >
> > _Float16 functions in libgcc should be compiled with SSE enabled.
> >
> > BTW, _Float16 software emulation may require more than just SSE since we need to do _Float16 load and store with XMM registers.
> > There is no 16bit load/store for XMM registers without AVX512FP16.
> >
> > --
> > H.J.
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev@lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
>
>
> --
> H.J.



-- 
H.J.

  reply	other threads:[~2021-07-13 15:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01 21:05 [PATCH] Add optional _Float16 support H.J. Lu via Libc-alpha
2021-07-01 22:10 ` Joseph Myers
2021-07-01 22:27   ` H.J. Lu via Libc-alpha
2021-07-01 22:40     ` Joseph Myers
2021-07-01 23:01       ` H.J. Lu via Libc-alpha
2021-07-01 23:05         ` [llvm-dev] " Craig Topper via Libc-alpha
2021-07-01 23:33     ` Jacob Lifshay via Libc-alpha
2021-07-02  7:45       ` Richard Biener via Libc-alpha
2021-07-02  8:03         ` Hongtao Liu via Libc-alpha
2021-07-02  9:21         ` Jakub Jelinek via Libc-alpha
2021-07-13  3:59     ` Wang, Pengfei via Libc-alpha
2021-07-13 14:26       ` H.J. Lu via Libc-alpha
2021-07-13 14:48         ` Wang, Pengfei via Libc-alpha
2021-07-13 15:04           ` H.J. Lu via Libc-alpha [this message]
2021-07-13 15:41         ` Joseph Myers
2021-07-13 16:24           ` H.J. Lu via Libc-alpha
2021-07-29 13:39             ` H.J. Lu via Libc-alpha
2021-08-24  5:55               ` John McCall via Libc-alpha
2021-08-25 12:35                 ` H.J. Lu via Libc-alpha
2021-08-25 20:32                   ` John McCall via Libc-alpha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMe9rOrXar1Ajfqs010Dv3e-tENPVb7o1zyL34XHy43SaOaVpg@mail.gmail.com \
    --to=libc-alpha@sourceware.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=ia32-abi@googlegroups.com \
    --cc=joseph@codesourcery.com \
    --cc=llvm-dev@lists.llvm.org \
    --cc=pengfei.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).