From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E445B1F910 for ; Sat, 19 Nov 2022 00:08:53 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="bs5KXjrh"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 160EC38432C9 for ; Sat, 19 Nov 2022 00:08:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 160EC38432C9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668816532; bh=XDIl09XJYi9ZpGSynQWnYBoOI5YYhkttyDX+6QraKr0=; h=References:In-Reply-To:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=bs5KXjrhV3QWdUTV+p9o0+nDVl/I5zkUF1gapmHbyzl+h/CjomECXLkGqs2PjZ5PK seVzN7703MKXSRlCgxW4kvYhiWzzbZ9XEXROrjqgFtDkmWdo/TU+Thcw2I2zU7hoYE 4Q+sD+DSukuNaKfjaLk7u6f1Qtg/eA0XjwqFcdgo= Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by sourceware.org (Postfix) with ESMTPS id 6C59038432C9 for ; Sat, 19 Nov 2022 00:08:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6C59038432C9 Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-14286d5ebc3so4507753fac.3 for ; Fri, 18 Nov 2022 16:08:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XDIl09XJYi9ZpGSynQWnYBoOI5YYhkttyDX+6QraKr0=; b=TGwPRbI6IPKveV5kWvgFtxnqpD+IvBMWvqxr3k3ktQSEM+1dBzJMFZcKpDk6O/QVc1 1YucQctoRkQt/FL+F9PbKTM2HIaF6F5AkYKtiQyRG/RBX+0TpyxQXe+G+5nt/j8VOcby 3+w82Ri4mn1IOIFwI+fOXyUqErIJSlJK42kTWivdZRIO5BL0u4qnPhedmAwW+zC8FWph q0icM6E8jlrcr0b3m8/oZu9zCH+OKHXHj0BeSxQWmbnyCuqhbfYBrcdVUvmkFSOFlk5m sj55tqeQGxZx5ucVZRPIlc2NH4Kuu0fg8SnDP+5tcWCWKiWUTkxh6d9uKmsSMDezY7eG zNVg== X-Gm-Message-State: ANoB5pm6g0VW6pn+M/oF8EyAYR+6jlearxCuyvcJkVDVYVfbtumBqy80 zLwe6ZmiCIoynEzOlznf4mCYPPE/tgQOaz1dDRQ= X-Google-Smtp-Source: AA0mqf7hXvowuis3zHet1UcsLpp19tHS8HXZWNv5IFHXJtVi8nnP66RO5LEHFvBa/qXB6CtXobvzY0f+Ig2j/QUmfpQ= X-Received: by 2002:a05:6871:4501:b0:13c:5da4:7229 with SMTP id nj1-20020a056871450100b0013c5da47229mr5386950oab.266.1668816511829; Fri, 18 Nov 2022 16:08:31 -0800 (PST) MIME-Version: 1.0 References: <20221118190835.1033248-1-goldstein.w.n@gmail.com> <20221118212255.1305681-1-goldstein.w.n@gmail.com> <20221118212255.1305681-3-goldstein.w.n@gmail.com> In-Reply-To: Date: Fri, 18 Nov 2022 16:07:56 -0800 Message-ID: Subject: Re: [PATCH v4 3/3] x86/fpu: Factor out shared avx2/avx512 code in svml_{s|d}_wrapper_impl.h To: Noah Goldstein Cc: libc-alpha@sourceware.org, andrey.kolesov@intel.com, carlos@systemhalted.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "H.J. Lu via Libc-alpha" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On Fri, Nov 18, 2022 at 1:59 PM Noah Goldstein wrote: > > On Fri, Nov 18, 2022 at 1:28 PM H.J. Lu wrote: > > > > On Fri, Nov 18, 2022 at 1:23 PM Noah Goldstein wrote: > > > > > > Code is exactly the same for the two so better to only maintain one > > > version. > > > > > > All math and mathvec tests pass on x86. > > > > Is the output of "objdump -dw" on libmvec.so the same before and after > > the patch? > > > > Yes for both libmvec.so and libm.so. Please mention this in the commit log. OK with the change. Thanks. -- H.J.