From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5FE831F5AE for ; Wed, 21 Apr 2021 14:29:47 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4D5B03892463; Wed, 21 Apr 2021 14:29:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D5B03892463 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619015386; bh=llrn2cEuCD2N17yVr8E/hitspbd+u/kFte0UCv/P7ic=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SbrjYFCAz5O08fLUidEc8zh1WoGmRAZidEetKhzZneBFHD5z8mRmJLoZGorHbR5Kp ZGwNB8G0DHi76gPJ3ZWMrXjRT9nsC+GNhQhZRocnTLvCPEpQoRdUHpB11KFvviY/fH lqfMbm//zMQCBwDwXcv2yB7XRBMXGx0kYgHNbltw= Received: from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com [IPv6:2607:f8b0:4864:20::c2d]) by sourceware.org (Postfix) with ESMTPS id B1E3C383801F for ; Wed, 21 Apr 2021 14:29:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B1E3C383801F Received: by mail-oo1-xc2d.google.com with SMTP id c6-20020a4aacc60000b02901e6260b12e2so6752948oon.3 for ; Wed, 21 Apr 2021 07:29:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=llrn2cEuCD2N17yVr8E/hitspbd+u/kFte0UCv/P7ic=; b=Mwl7Obk1DyURdlO6f6vjO7ak2oCsY56/XMZlQdfaK6i5puVSuGiuKtQNG3Fp+9D1CU UoOirUtU+uW91SGY/ecxqcPyL1813asy1+Tm9BRhaP+PmRPMCb89bQWgB6nuwVi91qkt kAg6rP+ITc6KVuJtWfgRGZp1eEkY+40Z5bL2gGL9PkINb6KoHbhKoQ64JZy5q/m5E/og xy6ewdbsfuUXZvMVrSGE8v+XoI5C0J2bcWSqUVSYxECprIOcarKCTKF/0LNqcNVGALSg Z2PiItdsac/s1TrFT14pV6qBwGjbn0g7U/MKuTncAsonwxk4u4Tzrii1TMneJqBDLCro ivSg== X-Gm-Message-State: AOAM5327PcOX6krZyGFGSbE5/BeYJFzwvbQBNopkUf9rdRHiCKhYPv9m ZDQ3792muA4LvG3emsNk4qvy0sKArs14Ocf/Np12ZkwXLq0= X-Google-Smtp-Source: ABdhPJwGM2o24/ytgLAAhmlhelJ7YNu9vRpF0S5LAJSkTrKefnNniYzc9XlC5E4/qSNuk0f5ZrsbOUUceDq7DrjNxAM= X-Received: by 2002:a4a:d65c:: with SMTP id y28mr3772763oos.58.1619015374190; Wed, 21 Apr 2021 07:29:34 -0700 (PDT) MIME-Version: 1.0 References: <87a6prbxu7.fsf@igel.home> In-Reply-To: <87a6prbxu7.fsf@igel.home> Date: Wed, 21 Apr 2021 07:28:58 -0700 Message-ID: Subject: Re: Fix argv overrun in getconf (bug 27761) To: Andreas Schwab Content-Type: text/plain; charset="UTF-8" X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "H.J. Lu via Libc-alpha" Reply-To: "H.J. Lu" Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On Wed, Apr 21, 2021 at 7:20 AM Andreas Schwab wrote: > > Correct argument counter accounting when processing the -v option with the > argument directly attached. > --- > posix/getconf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/posix/getconf.c b/posix/getconf.c > index efc9623b3b..4dccc9cbf2 100644 > --- a/posix/getconf.c > +++ b/posix/getconf.c > @@ -519,7 +519,7 @@ environment SPEC.\n\n")); > else > { > argv += 1; > - argc += 1; > + argc -= 1; > } > } > #else > @@ -544,7 +544,7 @@ environment SPEC.\n\n")); > { > spec = &argv[1][2]; > argv += 1; > - argc += 1; > + argc -= 1; > } > } > else > -- > 2.31.1 > LGTM. Thanks. -- H.J.