From: "H.J. Lu" <hjl.tools@gmail.com>
To: Rafal Luzynski <digitalfreak@lingonborough.com>
Cc: Florian Weimer <fweimer@redhat.com>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Add tests with a local IFUNC resolver [BZ #23937]
Date: Thu, 28 Feb 2019 17:52:32 -0800 [thread overview]
Message-ID: <CAMe9rOr-3tWtcAWO9ctp0pJ+8JdrCmdhdPCpT8f6H5FRxTjjbw@mail.gmail.com> (raw)
In-Reply-To: <14742246.106524.1551401420668@poczta.nazwa.pl>
On Thu, Feb 28, 2019 at 4:50 PM Rafal Luzynski
<digitalfreak@lingonborough.com> wrote:
>
> Florian,
>
> 27.02.2019 11:27 Florian Weimer <fweimer@redhat.com> wrote:
> >
> > * Florian Weimer:
> >
> > > The existing tests all use global symbols (but with different
> > > visibility). Local symbols could be treated differently by the
> > > compiler and linker (as was the case on POWER ELFv2, causing
> > > bug 23937), and we did not have test coverage for this.
> > >
> > > Tested on x86-64 and POWER ELFv2 little-endian, with and without
> > > --disable-multi-arch. On POWER, the test cases elf/ifuncmain9,
> > > elf/ifuncmain9pic, elf/ifuncmain9pie reproduce bug 23937 with older
> > > binutils.
> > >
> > > 2019-02-20 Florian Weimer <fweimer@redhat.com>
> > >
> > > [BZ #23937]
> > > elf: Add test with a local IFUNC resolver.
> > > * elf/ifuncmain9.c: New file.
> > > * elf/ifuncmain9pic.c: Likewise.
> > > * elf/ifuncmain9picstatic.c: Likewise.
> > > * elf/ifuncmain9pie.c: Likewise.
> > > * elf/ifuncmain9static.c: Likewise.
> > > * elf/Makefile [multi-arch] (tests-ifuncstatic): Add
> > > ifuncmain9static, ifuncmain9picstatic.
> > > * elf/Makefile [multi-arch && build-shared] (tests-internal):
> > > Add ifuncmain9, ifuncmain9pic.
> > > * elf/Makefile [multi-arch && build-shared && have-fpie]
> > > (ifunc-pie-tests): Add ifuncmain9pie.
> > > (CFLAGS-ifuncmain9pic.c): Add $(pic-ccflag).
> > > (CFLAGS-ifuncmain9picstatic.c): Likewise.
> > > (CFLAGS-ifuncmain9pie.c): Add $(pie-ccflag).
>
> All those tests fail at my test machine:
You left out the most relevant info. What is your test machine?
> FAIL: elf/ifuncmain9
> FAIL: elf/ifuncmain9pic
> FAIL: elf/ifuncmain9picstatic
> FAIL: elf/ifuncmain9pie
> FAIL: elf/ifuncmain9static
>
> $ cat elf/ifuncmain9.out
> info: initial value of resolver_called: 0
> error: invalid magic value: 0x400630
> info: resolver_called value: 1
> info: implementation_called value: 0
> error: invalid implementation_called value (must be 1)
> $ cat elf/ifuncmain9pic.out
> info: initial value of resolver_called: 0
> error: invalid magic value: 0x400640
> info: resolver_called value: 1
> info: implementation_called value: 0
> error: invalid implementation_called value (must be 1)
> $ cat elf/ifuncmain9picstatic.out
> info: initial value of resolver_called: 0
> error: invalid magic value: 0x400c70
> info: resolver_called value: 1
> info: implementation_called value: 0
> error: invalid implementation_called value (must be 1)
> $ cat elf/ifuncmain9pie.out
> info: initial value of resolver_called: 0
> error: invalid magic value: 0x5ef358e0
> info: resolver_called value: 1
> info: implementation_called value: 0
> error: invalid implementation_called value (must be 1)
> $ cat elf/ifuncmain9static.out
> info: initial value of resolver_called: 0
> error: invalid magic value: 0x400c60
> info: resolver_called value: 1
> info: implementation_called value: 0
> error: invalid implementation_called value (must be 1)
>
> I hope it helps. Feel free to ask more questions.
>
> Regards,
>
> Rafal
--
H.J.
next prev parent reply other threads:[~2019-03-01 1:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 12:53 [PATCH] elf: Add tests with a local IFUNC resolver [BZ #23937] Florian Weimer
2019-02-20 13:16 ` H.J. Lu
2019-02-20 13:29 ` Florian Weimer
2019-02-20 14:01 ` Szabolcs Nagy
2019-02-27 10:27 ` Florian Weimer
2019-03-01 0:50 ` Rafal Luzynski
2019-03-01 1:52 ` H.J. Lu [this message]
2019-03-01 8:25 ` Rafal Luzynski
2019-03-01 8:41 ` Florian Weimer
2019-03-01 11:03 ` Rafal Luzynski
2019-03-01 12:37 ` H.J. Lu
2019-03-02 0:34 ` Rafal Luzynski
2019-03-02 16:54 ` H.J. Lu
2019-03-04 9:47 ` Rafal Luzynski
2019-03-11 11:16 ` Rafal Luzynski
2019-03-11 13:55 ` Florian Weimer
2019-03-11 21:56 ` Rafal Luzynski
2019-03-12 1:12 ` H.J. Lu
2019-03-13 21:10 ` Florian Weimer
2019-03-13 11:47 ` Rafal Luzynski
2019-03-13 21:15 ` Florian Weimer
2019-02-27 21:23 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOr-3tWtcAWO9ctp0pJ+8JdrCmdhdPCpT8f6H5FRxTjjbw@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=digitalfreak@lingonborough.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).