On Mon, Oct 12, 2020 at 3:04 PM Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Sat, 10 Oct 2020, H.J. Lu via Libc-alpha wrote:
>
> > +* Add _SC_MINSIGSTKSZ and _SC_SIGSTKSZ.  When _SC_SIGSTKSZ_SOURCE is
> > +  defined, MINSIGSTKSZ and SIGSTKSZ are no longer constant on Linux.
> > +  MINSIGSTKSZ is redefined to sysconf(_SC_MINSIGSTKSZ) and SIGSTKSZ
> > +  is redefined to sysconf (_SC_SIGSTKSZ).
>
> I don't think the _SC_SIGSTKSZ_SOURCE option is a good idea.  But in any
> case, all feature test macros need to be documented in creature.texi, and
> the new _SC_* constants would need documenting in conf.texi, with
> appropriate documentation that they are GNU extensions.

Fixed.

> > +#ifdef __USE_SC_SIGSTKSZ
>
> And the internal macros for new feature test macros ought to be tested via
> __GLIBC_USE (thus, always defined to either 0 or 1) rather than #ifdef.
>

Fixed.

Here is the updated patch with the conform/data/unistd.h-data change
removed.

-- 
H.J.