* [PATCH] x86-64: Require BMI2 for __strlen_evex and __strnlen_evex
@ 2021-04-19 14:18 H.J. Lu via Libc-alpha
2021-04-19 14:29 ` Florian Weimer via Libc-alpha
0 siblings, 1 reply; 3+ messages in thread
From: H.J. Lu via Libc-alpha @ 2021-04-19 14:18 UTC (permalink / raw)
To: libc-alpha
I am committing this patch as an obvious fix.
H.J.
---
Since __strlen_evex and __strnlen_evex use sarx
c4 e2 6a f7 c0 sarx %edx,%eax,%eax
require BMI2 for __strlen_evex and __strnlen_evex in ifunc-impl-list.c.
ifunc-avx2.h already requires BMI2 for EVEX implementation.
---
sysdeps/x86_64/multiarch/ifunc-impl-list.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
index 770986e41a..f1a755b1d6 100644
--- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c
+++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c
@@ -293,7 +293,8 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
__strlen_avx2_rtm)
IFUNC_IMPL_ADD (array, i, strlen,
(CPU_FEATURE_USABLE (AVX512VL)
- && CPU_FEATURE_USABLE (AVX512BW)),
+ && CPU_FEATURE_USABLE (AVX512BW)
+ && CPU_FEATURE_USABLE (BMI2)),
__strlen_evex)
IFUNC_IMPL_ADD (array, i, strlen, 1, __strlen_sse2))
@@ -308,7 +309,8 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array,
__strnlen_avx2_rtm)
IFUNC_IMPL_ADD (array, i, strnlen,
(CPU_FEATURE_USABLE (AVX512VL)
- && CPU_FEATURE_USABLE (AVX512BW)),
+ && CPU_FEATURE_USABLE (AVX512BW)
+ && CPU_FEATURE_USABLE (BMI2)),
__strnlen_evex)
IFUNC_IMPL_ADD (array, i, strnlen, 1, __strnlen_sse2))
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86-64: Require BMI2 for __strlen_evex and __strnlen_evex
2021-04-19 14:18 [PATCH] x86-64: Require BMI2 for __strlen_evex and __strnlen_evex H.J. Lu via Libc-alpha
@ 2021-04-19 14:29 ` Florian Weimer via Libc-alpha
2021-04-19 14:53 ` H.J. Lu via Libc-alpha
0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer via Libc-alpha @ 2021-04-19 14:29 UTC (permalink / raw)
To: H.J. Lu via Libc-alpha
* H. J. Lu via Libc-alpha:
> I am committing this patch as an obvious fix.
Can you add a reference to the commit that is fixed? Thanks.
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86-64: Require BMI2 for __strlen_evex and __strnlen_evex
2021-04-19 14:29 ` Florian Weimer via Libc-alpha
@ 2021-04-19 14:53 ` H.J. Lu via Libc-alpha
0 siblings, 0 replies; 3+ messages in thread
From: H.J. Lu via Libc-alpha @ 2021-04-19 14:53 UTC (permalink / raw)
To: Florian Weimer; +Cc: H.J. Lu via Libc-alpha
On Mon, Apr 19, 2021 at 7:29 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu via Libc-alpha:
>
> > I am committing this patch as an obvious fix.
>
> Can you add a reference to the commit that is fixed? Thanks.
Here is the commit message I am checking in:
---
Since __strlen_evex and __strnlen_evex added by
commit 1fd8c163a83d96ace1ff78fa6bac7aee084f6f77
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Fri Mar 5 06:24:52 2021 -0800
x86-64: Add ifunc-avx2.h functions with 256-bit EVEX
use sarx:
c4 e2 6a f7 c0 sarx %edx,%eax,%eax
require BMI2 for __strlen_evex and __strnlen_evex in ifunc-impl-list.c.
ifunc-avx2.h already requires BMI2 for EVEX implementation.
---
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-19 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-19 14:18 [PATCH] x86-64: Require BMI2 for __strlen_evex and __strnlen_evex H.J. Lu via Libc-alpha
2021-04-19 14:29 ` Florian Weimer via Libc-alpha
2021-04-19 14:53 ` H.J. Lu via Libc-alpha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).